<p>keith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/20534">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Prevent Crash in show pdp-context from vty<br><br>Don't compare EOF with 'true' which resulted in calling<br>show_one_pdp() with an uninitialised pdp_t<br><br>Change-Id: Ic40429939b185f97c020dd3904e054fe860b91e8<br>---<br>M ggsn/ggsn_vty.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/34/20534/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c</span><br><span>index 5e4feae..d074c20 100644</span><br><span>--- a/ggsn/ggsn_vty.c</span><br><span>+++ b/ggsn/ggsn_vty.c</span><br><span>@@ -929,13 +929,15 @@</span><br><span> </span><br><span>       if (argc > 2) {</span><br><span>           nsapi = atoi(argv[2]);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (gtp_pdp_getimsi(ggsn->gsn, &pdp, imsi, nsapi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Below returns 0 if found, EOF if not found */</span><br><span style="color: hsl(120, 100%, 40%);">+              if (0 == gtp_pdp_getimsi(ggsn->gsn, &pdp, imsi, nsapi)) {</span><br><span>                     show_one_pdp(vty, pdp);</span><br><span>                      num_found++;</span><br><span>                 }</span><br><span>    } else {</span><br><span>             for (nsapi = 0; nsapi < PDP_MAXNSAPI; nsapi++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (gtp_pdp_getimsi(ggsn->gsn, &pdp, imsi, nsapi))</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* Below returns EOF if not found. */</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (EOF == gtp_pdp_getimsi(ggsn->gsn, &pdp, imsi, nsapi))</span><br><span>                             continue;</span><br><span>                    show_one_pdp(vty, pdp);</span><br><span>                      num_found++;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/20534">change 20534</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/20534"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic40429939b185f97c020dd3904e054fe860b91e8 </div>
<div style="display:none"> Gerrit-Change-Number: 20534 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>