<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20509">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: Fix parsing of SNS-{ADD,DEL,CHANGE_WEIGHT}<br><br>Change-Id: I94c12986f8255e4373b13b1a8fae3df08004ad96<br>Related: OS#4791<br>---<br>M src/gb/gprs_ns2.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index aca8994..b82fd0d 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -875,8 +875,8 @@</span><br><span>    case SNS_PDUT_CHANGE_WEIGHT:</span><br><span>         case SNS_PDUT_DELETE:</span><br><span>                /* weird layout: NSEI TLV, then value-only transaction IE, then TLV again */</span><br><span style="color: hsl(0, 100%, 40%);">-            rc = ns2_tlv_parse(&tp, nsh->data+1,</span><br><span style="color: hsl(0, 100%, 40%);">-                                msgb_l2len(msg) - sizeof(*nsh)-1, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = ns2_tlv_parse(&tp, nsh->data+5,</span><br><span style="color: hsl(120, 100%, 40%);">+                              msgb_l2len(msg) - sizeof(*nsh)-5, 0, 0);</span><br><span>          if (rc < 0) {</span><br><span>                     LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span>                     return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20509">change 20509</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20509"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I94c12986f8255e4373b13b1a8fae3df08004ad96 </div>
<div style="display:none"> Gerrit-Change-Number: 20509 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>