<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20506">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_udp: Avoid dangling freed struct in list if binding fails<br><br>Change-Id: Ic54434b7cfc40136788257e768cae7a2b5d5bc79<br>---<br>M src/gb/gprs_ns2_udp.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/20506/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c</span><br><span>index 3ce0508..207febf 100644</span><br><span>--- a/src/gb/gprs_ns2_udp.c</span><br><span>+++ b/src/gb/gprs_ns2_udp.c</span><br><span>@@ -303,8 +303,6 @@</span><br><span>      priv->addr = *local;</span><br><span>      INIT_LLIST_HEAD(&bind->nsvc);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        llist_add(&bind->list, &nsi->binding);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         rc = osmo_sock_init_osa_ofd(&priv->fd, SOCK_DGRAM, IPPROTO_UDP,</span><br><span>                                local, NULL,</span><br><span>                                 OSMO_SOCK_F_BIND);</span><br><span>@@ -325,6 +323,7 @@</span><br><span>                            dscp, rc, errno);</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ llist_add(&bind->list, &nsi->binding);</span><br><span>         ns2_vty_bind_apply(bind);</span><br><span> </span><br><span>        if (result)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20506">change 20506</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20506"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic54434b7cfc40136788257e768cae7a2b5d5bc79 </div>
<div style="display:none"> Gerrit-Change-Number: 20506 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>