<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20498">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_l1_if: use network byte order for all ports<br><br>Having all connection information in network byte order<br>make it more consistent to me.<br>Change-Id: I675cc2564eab5125e08291e44b6cb66082f694b9<br><br>Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7<br>---<br>M src/pcu_l1_if.cpp<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/20498/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index b2a44d7..fb9cd12 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -586,20 +586,20 @@</span><br><span> case PCU_IF_ADDR_TYPE_IPV4:</span><br><span> local_sockaddr.u.sin.sin_family = AF_INET;</span><br><span> local_sockaddr.u.sin.sin_addr.s_addr = INADDR_ANY;</span><br><span style="color: hsl(0, 100%, 40%);">- local_sockaddr.u.sin.sin_port = htons(info_ind->local_port[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ local_sockaddr.u.sin.sin_port = info_ind->local_port[i];</span><br><span> </span><br><span> remote_sockaddr.u.sin.sin_family = AF_INET;</span><br><span> remote_sockaddr.u.sin.sin_addr = info_ind->remote_ip[i].v4;</span><br><span style="color: hsl(0, 100%, 40%);">- remote_sockaddr.u.sin.sin_port = htons(info_ind->remote_port[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ remote_sockaddr.u.sin.sin_port = info_ind->remote_port[i];</span><br><span> break;</span><br><span> case PCU_IF_ADDR_TYPE_IPV6:</span><br><span> local_sockaddr.u.sin6.sin6_family = AF_INET6;</span><br><span> local_sockaddr.u.sin6.sin6_addr = in6addr_any;</span><br><span style="color: hsl(0, 100%, 40%);">- local_sockaddr.u.sin6.sin6_port = htons(info_ind->local_port[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ local_sockaddr.u.sin6.sin6_port = info_ind->local_port[i];</span><br><span> </span><br><span> remote_sockaddr.u.sin6.sin6_family = AF_INET6;</span><br><span> remote_sockaddr.u.sin6.sin6_addr = info_ind->remote_ip[i].v6;</span><br><span style="color: hsl(0, 100%, 40%);">- remote_sockaddr.u.sin6.sin6_port = htons(info_ind->remote_port[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ remote_sockaddr.u.sin6.sin6_port = info_ind->remote_port[i];</span><br><span> break;</span><br><span> default:</span><br><span> continue;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20498">change 20498</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20498"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7 </div>
<div style="display:none"> Gerrit-Change-Number: 20498 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>