<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20479">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: correct parse the NM_ATT_OSMO_NS_LINK_CFG field address_family<br><br>The address_family is 8 bit and have a padding byte afterwards.<br>By using osmo_load16be it's encoding it wrong and result in an<br>empty/invalid NSVC configuration.<br><br>Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2<br>---<br>M src/common/oml.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 1f74cac..5394e8a 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -1277,12 +1277,13 @@</span><br><span> </span><br><span>  if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) {</span><br><span>                const uint8_t *cur = TLVP_VAL(tp, NM_ATT_OSMO_NS_LINK_CFG);</span><br><span style="color: hsl(0, 100%, 40%);">-             uint16_t address_family;</span><br><span style="color: hsl(120, 100%, 40%);">+              uint8_t address_family;</span><br><span> </span><br><span>          memset(&nsvc->local, 0, sizeof(nsvc->local));</span><br><span>              memset(&nsvc->remote, 0, sizeof(nsvc->remote));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           address_family = osmo_load16be(cur);</span><br><span style="color: hsl(120, 100%, 40%);">+          address_family = *cur;</span><br><span style="color: hsl(120, 100%, 40%);">+                /* 1byte padding */</span><br><span>          cur += 2;</span><br><span> </span><br><span>                memcpy(&nsvc->local.u.sin.sin_port, cur, 2);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20479">change 20479</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20479"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2 </div>
<div style="display:none"> Gerrit-Change-Number: 20479 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>