<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20345">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">compl l3: move Paging Response handling out of bsc_find_msc()<br><br>Instead of iterating the llist of gsm_paging_requests first to find an MSC, and<br>then again right away to mark the paging as served, do both in the same step.<br><br>Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041<br>---<br>M include/osmocom/bsc/paging.h<br>M src/osmo-bsc/gsm_08_08.c<br>M src/osmo-bsc/paging.c<br>3 files changed, 61 insertions(+), 116 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h</span><br><span>index 2be71c3..449a2eb 100644</span><br><span>--- a/include/osmocom/bsc/paging.h</span><br><span>+++ b/include/osmocom/bsc/paging.h</span><br><span>@@ -59,11 +59,7 @@</span><br><span> int paging_request_bts(struct gsm_bts *bts, struct bsc_subscr *bsub, int type,</span><br><span> struct bsc_msc_data *msc);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* stop paging requests */</span><br><span style="color: hsl(0, 100%, 40%);">-void paging_request_stop(struct llist_head *bts_list,</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts *_bts, struct bsc_subscr *bsub,</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg);</span><br><span style="color: hsl(120, 100%, 40%);">+struct bsc_msc_data *paging_request_stop(struct gsm_bts *bts, struct bsc_subscr *bsub);</span><br><span> </span><br><span> /* update paging load */</span><br><span> void paging_update_buffer_space(struct gsm_bts *bts, uint16_t);</span><br><span>@@ -71,8 +67,6 @@</span><br><span> /* pending paging requests */</span><br><span> unsigned int paging_pending_requests_nr(struct gsm_bts *bts);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct bsc_msc_data *paging_get_msc(struct gsm_bts *bts, struct bsc_subscr *bsub);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc);</span><br><span> void paging_flush_network(struct gsm_network *net, struct bsc_msc_data *msc);</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 4c53918..984e830 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -196,11 +196,9 @@</span><br><span> struct bsc_msc_data *msc_round_robin_next = NULL;</span><br><span> struct bsc_msc_data *msc_round_robin_first = NULL;</span><br><span> uint8_t round_robin_next_nr;</span><br><span style="color: hsl(0, 100%, 40%);">- struct bsc_subscr *subscr;</span><br><span> bool is_emerg = false;</span><br><span> int16_t nri_v = -1;</span><br><span> bool is_null_nri = false;</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts *bts;</span><br><span> </span><br><span> if (msgb_l3len(msg) < sizeof(*gh)) {</span><br><span> LOGP(DRSL, LOGL_ERROR, "There is no GSM48 header here.\n");</span><br><span>@@ -213,27 +211,6 @@</span><br><span> </span><br><span> is_emerg = (pdisc == GSM48_PDISC_MM && mtype == GSM48_MT_MM_CM_SERV_REQ) && is_cm_service_for_emerg(msg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Has the subscriber been paged from a connected MSC? */</span><br><span style="color: hsl(0, 100%, 40%);">- bts = conn_get_bts(conn);</span><br><span style="color: hsl(0, 100%, 40%);">- if (bts && pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) {</span><br><span style="color: hsl(0, 100%, 40%);">- subscr = bsc_subscr_find_by_mi(conn->network->bsc_subscribers, mi);</span><br><span style="color: hsl(0, 100%, 40%);">- if (subscr) {</span><br><span style="color: hsl(0, 100%, 40%);">- msc_target = paging_get_msc(bts, subscr);</span><br><span style="color: hsl(0, 100%, 40%);">- bsc_subscr_put(subscr);</span><br><span style="color: hsl(0, 100%, 40%);">- if (is_msc_usable(msc_target, is_emerg)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG, "%s matches earlier Paging from msc %d\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_mobile_identity_to_str_c(OTC_SELECT, mi), msc_target->nr);</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&msc_target->msc_ctrs->ctr[MSC_CTR_MSCPOOL_SUBSCR_PAGED]);</span><br><span style="color: hsl(0, 100%, 40%);">- return msc_target;</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">- "%s matches earlier Paging from msc %d, but this MSC is not connected\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_mobile_identity_to_str_c(OTC_SELECT, mi), msc_target->nr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- msc_target = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define LOG_NRI(LOGLEVEL, FORMAT, ARGS...) \</span><br><span> LOGP(DMSC, LOGLEVEL, "%s NRI(%d)=0x%x=%d: " FORMAT, osmo_mobile_identity_to_str_c(OTC_SELECT, mi), \</span><br><span> net->nri_bitlen, nri_v, nri_v, ##ARGS)</span><br><span>@@ -347,34 +324,6 @@</span><br><span> #undef LOG_NRI</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int handle_page_resp(struct gsm_subscriber_connection *conn, struct msgb *msg,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct osmo_mobile_identity *mi)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct bsc_subscr *subscr = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts *bts = conn_get_bts(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!bts) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* should never happen */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DRSL, LOGL_ERROR, "Paging Response without lchan\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return -1;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (mi->type == GSM_MI_TYPE_NONE)</span><br><span style="color: hsl(0, 100%, 40%);">- return -1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- subscr = bsc_subscr_find_by_mi(conn->network->bsc_subscribers, mi);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!subscr) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DMSC, LOGL_ERROR, "Non active subscriber got paged.\n");</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&conn->lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&conn->network->bsc_ctrs->ctr[BSC_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span style="color: hsl(0, 100%, 40%);">- return -1;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- paging_request_stop(&conn->network->bts_list, bts, subscr, conn, msg);</span><br><span style="color: hsl(0, 100%, 40%);">- bsc_subscr_put(subscr);</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static void parse_powercap(struct gsm_subscriber_connection *conn, struct msgb *msg)</span><br><span> {</span><br><span> struct gsm48_hdr *gh = msgb_l3(msg);</span><br><span>@@ -433,6 +382,7 @@</span><br><span> {</span><br><span> struct gsm_subscriber_connection *conn;</span><br><span> struct bsc_subscr *bsub = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *paged_from_msc;</span><br><span> struct bsc_msc_data *msc;</span><br><span> struct msgb *create_l3;</span><br><span> struct gsm0808_speech_codec_list scl;</span><br><span>@@ -454,6 +404,9 @@</span><br><span> pdisc = gsm48_hdr_pdisc(gh);</span><br><span> mtype = gsm48_hdr_msg_type(gh);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ bts = lchan->ts->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (osmo_mobile_identity_decode_from_l3(&mi, msg, false)) {</span><br><span> LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "Cannot extract Mobile Identity: %s\n",</span><br><span> msgb_hexdump_c(OTC_SELECT, msg));</span><br><span>@@ -482,8 +435,37 @@</span><br><span> </span><br><span> log_set_context(LOG_CTX_BSC_SUBSCR, conn->bsub);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* When receiving a Paging Response, stop Paging for this subscriber on all cells, and figure out which MSC</span><br><span style="color: hsl(120, 100%, 40%);">+ * sent the Paging Request, if any. */</span><br><span style="color: hsl(120, 100%, 40%);">+ paged_from_msc = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) {</span><br><span style="color: hsl(120, 100%, 40%);">+ paged_from_msc = paging_request_stop(bts, conn->bsub);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!paged_from_msc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* This looks like an unsolicited Paging Response. It is required to pick any MSC, because any</span><br><span style="color: hsl(120, 100%, 40%);">+ * MT-CSFB calls were Paged by the MSC via SGs, and hence are not listed in the BSC. */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ "%s Unsolicited Paging Response, possibly an MT-CSFB call.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_mobile_identity_to_str_c(OTC_SELECT, &mi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&bsc_gsmnet->bsc_ctrs->ctr[BSC_CTR_PAGING_NO_ACTIVE_PAGING]);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (is_msc_usable(paged_from_msc, false)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG, "%s matches earlier Paging from msc %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_mobile_identity_to_str_c(OTC_SELECT, &mi), paged_from_msc->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&paged_from_msc->msc_ctrs->ctr[MSC_CTR_MSCPOOL_SUBSCR_PAGED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ "%s matches earlier Paging from msc %d, but this MSC is not connected\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_mobile_identity_to_str_c(OTC_SELECT, &mi), paged_from_msc->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ paged_from_msc = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* find the MSC link we want to use */</span><br><span style="color: hsl(0, 100%, 40%);">- msc = bsc_find_msc(conn, msg, &mi);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (paged_from_msc)</span><br><span style="color: hsl(120, 100%, 40%);">+ msc = paged_from_msc;</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ msc = bsc_find_msc(conn, msg, &mi);</span><br><span> if (!msc) {</span><br><span> LOGP(DMSC, LOGL_ERROR, "Failed to find a MSC for a connection.\n");</span><br><span> rc = -1;</span><br><span>@@ -494,18 +476,7 @@</span><br><span> if (osmo_bsc_sigtran_new_conn(conn, msc) != BSC_CON_SUCCESS)</span><br><span> goto early_fail;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- bts = conn_get_bts(conn);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!bts) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* should never happen */</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "%s: internal error: Compl L3 without BTS\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_mobile_identity_to_str_c(OTC_SELECT, &mi));</span><br><span style="color: hsl(0, 100%, 40%);">- rc = -1;</span><br><span style="color: hsl(0, 100%, 40%);">- goto early_fail;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> parse_powercap(conn, msg);</span><br><span style="color: hsl(0, 100%, 40%);">- if (pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP)</span><br><span style="color: hsl(0, 100%, 40%);">- handle_page_resp(conn, msg, &mi);</span><br><span> </span><br><span> /* Send the Create Layer 3. */</span><br><span> use_scl = NULL;</span><br><span>diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c</span><br><span>index 37ec61c..0e5bf9f 100644</span><br><span>--- a/src/osmo-bsc/paging.c</span><br><span>+++ b/src/osmo-bsc/paging.c</span><br><span>@@ -387,13 +387,9 @@</span><br><span> * to notify the paging originator that paging has completed.</span><br><span> * \param[in] bts BTS on which we shall stop paging</span><br><span> * \param[in] bsub subscriber which we shall stop paging</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] conn connection to the subscriber (if any)</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] msg message received from subscrbier (if any)</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns 0 if an active paging request was stopped, an error code otherwise. */</span><br><span style="color: hsl(0, 100%, 40%);">-/* we consciously ignore the type of the request here */</span><br><span style="color: hsl(0, 100%, 40%);">-static int _paging_request_stop(struct gsm_bts *bts, struct bsc_subscr *bsub,</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns the MSC that paged the subscriber, if there was a pending request.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+static struct bsc_msc_data *paging_request_stop_bts(struct gsm_bts *bts, struct bsc_subscr *bsub)</span><br><span> {</span><br><span> struct gsm_bts_paging_state *bts_entry = &bts->paging;</span><br><span> struct gsm_paging_request *req, *req2;</span><br><span>@@ -403,51 +399,47 @@</span><br><span> llist_for_each_entry_safe(req, req2, &bts_entry->pending_requests,</span><br><span> entry) {</span><br><span> if (req->bsub == bsub) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *from_msc = req->msc;</span><br><span> /* now give up the data structure */</span><br><span> paging_remove_request(&bts->paging, req);</span><br><span> LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s\n", bsc_subscr_name(bsub));</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ return from_msc;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return -ENOENT;</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span> }</span><br><span> </span><br><span> /*! Stop paging on all other bts'</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] bts_list list of BTSs to iterate</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] _bts BTS which has received a paging response</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] bts BTS which has received a paging response</span><br><span> * \param[in] bsub subscriber</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] msgb L3 message that we have received from \a bsub on \a _bts */</span><br><span style="color: hsl(0, 100%, 40%);">-void paging_request_stop(struct llist_head *bts_list,</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts *_bts, struct bsc_subscr *bsub,</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns the MSC that paged the subscriber, if there was a pending request.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+struct bsc_msc_data *paging_request_stop(struct gsm_bts *bts, struct bsc_subscr *bsub)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_bts *bts;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts_i;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *paged_from_msc;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(bts);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- log_set_context(LOG_CTX_BSC_SUBSCR, bsub);</span><br><span style="color: hsl(0, 100%, 40%);">- conn->bsub = bsc_subscr_get(bsub);</span><br><span style="color: hsl(0, 100%, 40%);">- gscon_update_id(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+ paged_from_msc = paging_request_stop_bts(bts, bsub);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (paged_from_msc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Stop this first and dispatch the request */</span><br><span style="color: hsl(0, 100%, 40%);">- if (_bts) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (_paging_request_stop(_bts, bsub, conn, msg) == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&_bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&_bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry(bts_i, &bsc_gsmnet->bts_list, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct bsc_msc_data *paged_from_msc2 = paging_request_stop_bts(bts_i, bsub);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!paged_from_msc && paged_from_msc2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If this happened, it would be a bit weird: it means there was no Paging Request</span><br><span style="color: hsl(120, 100%, 40%);">+ * pending on the BTS that sent the Paging Reponse, but there *is* a Paging Request</span><br><span style="color: hsl(120, 100%, 40%);">+ * pending on a different BTS. But why not return an MSC when we found one. */</span><br><span style="color: hsl(120, 100%, 40%);">+ paged_from_msc = paged_from_msc2;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure to cancel this everywhere else */</span><br><span style="color: hsl(0, 100%, 40%);">- llist_for_each_entry(bts, bts_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Sort of an optimization. */</span><br><span style="color: hsl(0, 100%, 40%);">- if (bts == _bts)</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">- _paging_request_stop(bts, bsub, NULL, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- log_set_context(LOG_CTX_BSC_SUBSCR, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+ return paged_from_msc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*! Update the BTS paging buffer slots on given BTS */</span><br><span> void paging_update_buffer_space(struct gsm_bts *bts, uint16_t free_slots)</span><br><span> {</span><br><span>@@ -472,18 +464,6 @@</span><br><span> return requests;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! Find any paging data for the given subscriber at the given BTS. */</span><br><span style="color: hsl(0, 100%, 40%);">-struct bsc_msc_data *paging_get_msc(struct gsm_bts *bts, struct bsc_subscr *bsub)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_paging_request *req;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- llist_for_each_entry(req, &bts->paging.pending_requests, entry)</span><br><span style="color: hsl(0, 100%, 40%);">- if (req->bsub == bsub)</span><br><span style="color: hsl(0, 100%, 40%);">- return req->msc;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*! Flush all paging requests at a given BTS for a given MSC (or NULL if all MSC should be flushed). */</span><br><span> void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20345">change 20345</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20345"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I447e61afc9934f3a5a82f6076e41c155d3328041 </div>
<div style="display:none"> Gerrit-Change-Number: 20345 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>