<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20469">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_vty: parse the return code to make coverity happy<br><br>The missing return code isn't a problem atm because remote.af is checked<br>and remote.af is only set when osmo_Sockaddr_str_from_sockaddr() returns success.<br>However check the return code to be safe also in the future.<br><br>Found-by: Coverity<br>Fixes: CID#214863<br>Change-Id: I621360cab1e12c22248e33d62a9929995053ce04<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/20469/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index dec8277..7be6aeb 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -773,8 +773,8 @@</span><br><span>             vty_out(vty, "  gprs nsvc %u local udp port %u%s", i,</span><br><span>                      nsvc->local_port, VTY_NEWLINE);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          osmo_sockaddr_str_from_sockaddr(&remote, &nsvc->remote.u.sas);</span><br><span style="color: hsl(0, 100%, 40%);">-               if (remote.af != AF_UNSPEC) {</span><br><span style="color: hsl(120, 100%, 40%);">+         if (osmo_sockaddr_str_from_sockaddr(&remote, &nsvc->remote.u.sas) ||</span><br><span style="color: hsl(120, 100%, 40%);">+                               remote.af != AF_UNSPEC) {</span><br><span>                    vty_out(vty, "  gprs nsvc %u remote ip %s%s", i,</span><br><span>                           remote.ip, VTY_NEWLINE);</span><br><span>             }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20469">change 20469</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20469"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I621360cab1e12c22248e33d62a9929995053ce04 </div>
<div style="display:none"> Gerrit-Change-Number: 20469 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>