<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h">File include/osmo-bts/bts.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h@148">Patch Set #1, Line 148:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* NM BTS Site Manager FSM */<br> struct osmo_fsm_inst *fi;<br> bool opstart_success;<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">why don't we move this into the gsm_abis_mo? Shouldn't every one of them have a fsm_inst and some s […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes I guess I can move it inside.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h">File include/osmo-bts/nm_bts_sm_fsm.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">nm_bts_sm_fsm</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why not 'nm_bts_site_mgr_fsm'?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not nm_bts_site_manager? Or xyz? nm_bts_sm_fsm looks good for me.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c">File src/common/bts.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@224">Patch Set #1, Line 224:</a> <code style="font-family:monospace,monospace"> LOGL_INFO, NULL);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">alignment</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@225">Patch Set #1, Line 225:</a> <code style="font-family:monospace,monospace">bts_sm%d</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">fixeria is correct. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes indeed the SiteManager is for all BTS, but since we only support one BTS and the site_mgr struct is inlined inside the gsm_bts one, I simply put it that way. I don't see a big issue with it but I can remove the %d part sure.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c">File src/common/oml.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c@1624">Patch Set #1, Line 1624:</a> <code style="font-family:monospace,monospace">obj = bts</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I am not getting this... Site manager != BTS.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah sure, but anyway we don't really have a separate site_mgr struct (it's inlined inside bts) so it was easier to pass arorund the BTS object which contains all the information.<br>I could add a site_mgr->bts backpointer and keep this as site_mgr if you want.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20408">change 20408</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20408"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iab2d17c45c9642860cd2d5d523c1baae24502243 </div>
<div style="display:none"> Gerrit-Change-Number: 20408 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Oct 2020 09:20:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>