<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20391">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: status ind: add additional flags (first and persistent)<br><br>Both flags are required to allow the NS user to sent BVC RESET for persistent NSE.<br>On persistent NSE with persistent NS alive configuration (no RESET/UNBLOCK/BLOCK) the<br>PCU can't detect if the SGSN has restartet or crashed.<br><br>Change-Id: Iaad7b53d44338e5dd81dc2202f23bdcb715af804<br>---<br>M include/osmocom/gprs/gprs_ns2.h<br>M src/gb/gprs_ns2.c<br>M src/gb/gprs_ns2_internal.h<br>3 files changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h</span><br><span>index 6b88c72..036c594 100644</span><br><span>--- a/include/osmocom/gprs/gprs_ns2.h</span><br><span>+++ b/include/osmocom/gprs/gprs_ns2.h</span><br><span>@@ -78,6 +78,12 @@</span><br><span> enum gprs_ns2_affecting_cause cause;</span><br><span> /* 48.016 5.2.2.6 transfer capability */</span><br><span> int transfer;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* osmocom specific */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Persistent NSE/NSVC are configured by vty */</span><br><span style="color: hsl(120, 100%, 40%);">+ bool persistent;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Only true on the first time it's available.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Allow the BSSGP layer to reset persistent NSE */</span><br><span style="color: hsl(120, 100%, 40%);">+ bool first;</span><br><span> } status;</span><br><span> } u;</span><br><span> };</span><br><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 53500d1..aca8994 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -353,6 +353,8 @@</span><br><span> nsp.bvci = bvci;</span><br><span> nsp.u.status.cause = cause;</span><br><span> nsp.u.status.transfer = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ nsp.u.status.first = nse->first;</span><br><span style="color: hsl(120, 100%, 40%);">+ nsp.u.status.persistent = nse->persistent;</span><br><span> osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_STATUS,</span><br><span> PRIM_OP_INDICATION, NULL);</span><br><span> nse->nsi->cb(&nsp.oph, nse->nsi->cb_data);</span><br><span>@@ -559,6 +561,7 @@</span><br><span> </span><br><span> nse->nsei = nsei;</span><br><span> nse->nsi = nsi;</span><br><span style="color: hsl(120, 100%, 40%);">+ nse->first = true;</span><br><span> llist_add(&nse->list, &nsi->nse);</span><br><span> INIT_LLIST_HEAD(&nse->nsvc);</span><br><span> </span><br><span>@@ -931,6 +934,7 @@</span><br><span> /* this is the first unblocked NSVC on an unavailable NSE */</span><br><span> nse->alive = true;</span><br><span> ns2_prim_status_ind(nse, 0, NS_AFF_CAUSE_RECOVERY);</span><br><span style="color: hsl(120, 100%, 40%);">+ nse->first = false;</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h</span><br><span>index 1980ef8..3d0f96d 100644</span><br><span>--- a/src/gb/gprs_ns2_internal.h</span><br><span>+++ b/src/gb/gprs_ns2_internal.h</span><br><span>@@ -120,6 +120,10 @@</span><br><span> /*! true if this NSE was created by VTY or pcu socket) */</span><br><span> bool persistent;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /*! true if this NSE wasn't yet alive at all.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Will be true after the first status ind with NS_AFF_CAUSE_RECOVERY */</span><br><span style="color: hsl(120, 100%, 40%);">+ bool first;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! true if this NSE has at least one alive VC */</span><br><span> bool alive;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20391">change 20391</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20391"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaad7b53d44338e5dd81dc2202f23bdcb715af804 </div>
<div style="display:none"> Gerrit-Change-Number: 20391 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>