<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/20415">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cgit: osmo-commit-filter.py: migrate from deprecated cgi.escape to html.escape<br><br>Our error.log is full of:<br><br>/usr/local/lib/cgit/filters/osmo-commit-filter.py:18: DeprecationWarning: cgi.escape is deprecated, use html.escape instead<br>  return '<a href="%s">%s</a>' % (url, cgi.escape(txt))<br><br>Change-Id: I97707519029d4f8d703d2df1b8beab15665d49b1<br>---<br>M cgit/osmo-commit-filter.py<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/cgit/osmo-commit-filter.py b/cgit/osmo-commit-filter.py</span><br><span>index 7488bb5..2172840 100755</span><br><span>--- a/cgit/osmo-commit-filter.py</span><br><span>+++ b/cgit/osmo-commit-filter.py</span><br><span>@@ -12,26 +12,26 @@</span><br><span> </span><br><span> import re</span><br><span> import sys</span><br><span style="color: hsl(0, 100%, 40%);">-import cgi</span><br><span style="color: hsl(120, 100%, 40%);">+import html</span><br><span> </span><br><span> def hyperlink(txt, url):</span><br><span style="color: hsl(0, 100%, 40%);">-    return '<a href="%s">%s</a>' % (url, cgi.escape(txt))</span><br><span style="color: hsl(120, 100%, 40%);">+    return '<a href="%s">%s</a>' % (url, html.escape(txt))</span><br><span> </span><br><span> def chgid_repl(matchobj):</span><br><span>     chg_id = matchobj.group(1)</span><br><span style="color: hsl(0, 100%, 40%);">-    url = GERRIT_URL % cgi.escape(chg_id)</span><br><span style="color: hsl(120, 100%, 40%);">+    url = GERRIT_URL % html.escape(chg_id)</span><br><span>     return hyperlink(chg_id, url)</span><br><span> </span><br><span> def relates_repl(matchobj):</span><br><span>     def process_item(x):</span><br><span>         def repl_os(m):</span><br><span style="color: hsl(0, 100%, 40%);">-            url = REDMINE_OS_URL % cgi.escape(m.group(1))</span><br><span style="color: hsl(120, 100%, 40%);">+            url = REDMINE_OS_URL % html.escape(m.group(1))</span><br><span>             return hyperlink(m.group(0), url)</span><br><span>         def repl_sys(m):</span><br><span style="color: hsl(0, 100%, 40%);">-            url = REDMINE_SYS_URL % cgi.escape(m.group(1))</span><br><span style="color: hsl(120, 100%, 40%);">+            url = REDMINE_SYS_URL % html.escape(m.group(1))</span><br><span>             return hyperlink(m.group(0), url)</span><br><span>         def repl_rt(m):</span><br><span style="color: hsl(0, 100%, 40%);">-            url = RT_URL % cgi.escape(m.group(1))</span><br><span style="color: hsl(120, 100%, 40%);">+            url = RT_URL % html.escape(m.group(1))</span><br><span>             return hyperlink(m.group(0), url)</span><br><span>         x = re.sub(r"OS#(\d+)", repl_os, x)</span><br><span>         x = re.sub(r"SYS#(\d+)", repl_sys, x)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/20415">change 20415</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/20415"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I97707519029d4f8d703d2df1b8beab15665d49b1 </div>
<div style="display:none"> Gerrit-Change-Number: 20415 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>