<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20401">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce NM BTS FSM<br><br>Change-Id: I7756a8ce90b6cc8a502b5665889a7987d7f749cb<br>---<br>M include/osmocom/bsc/Makefile.am<br>M include/osmocom/bsc/bts.h<br>A include/osmocom/bsc/nm_bts_fsm.h<br>M include/osmocom/bsc/signal.h<br>M src/ipaccess/Makefile.am<br>M src/osmo-bsc/Makefile.am<br>M src/osmo-bsc/abis_nm.c<br>M src/osmo-bsc/abis_om2000.c<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/bts.c<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>M src/osmo-bsc/bts_nokia_site.c<br>M src/osmo-bsc/gsm_data.c<br>A src/osmo-bsc/nm_bts_fsm.c<br>M src/utils/Makefile.am<br>M tests/abis/Makefile.am<br>M tests/acc/Makefile.am<br>M tests/acc/acc_test.ok<br>M tests/bsc/Makefile.am<br>M tests/gsm0408/Makefile.am<br>M tests/handover/Makefile.am<br>M tests/nanobts_omlattr/Makefile.am<br>22 files changed, 548 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/20401/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am</span><br><span>index b25c95a..59ac91a 100644</span><br><span>--- a/include/osmocom/bsc/Makefile.am</span><br><span>+++ b/include/osmocom/bsc/Makefile.am</span><br><span>@@ -36,6 +36,7 @@</span><br><span>     neighbor_ident.h \</span><br><span>   network_listen.h \</span><br><span>   nm_bts_sm_fsm.h \</span><br><span style="color: hsl(120, 100%, 40%);">+     nm_bts_fsm.h \</span><br><span>       openbscdefines.h \</span><br><span>   osmo_bsc.h \</span><br><span>         osmo_bsc_grace.h \</span><br><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index 063a531..564e2b8 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -410,7 +410,14 @@</span><br><span>   /* Abis network management O&M handle */</span><br><span>         struct abis_nm_h *nmh;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      struct gsm_abis_mo mo;</span><br><span style="color: hsl(120, 100%, 40%);">+        struct {</span><br><span style="color: hsl(120, 100%, 40%);">+              struct osmo_fsm_inst *fi;</span><br><span style="color: hsl(120, 100%, 40%);">+             bool opstart_sent;</span><br><span style="color: hsl(120, 100%, 40%);">+            bool adm_unlock_sent;</span><br><span style="color: hsl(120, 100%, 40%);">+         bool set_bts_attr_sent;</span><br><span style="color: hsl(120, 100%, 40%);">+               bool set_bts_attr_ack_received;</span><br><span style="color: hsl(120, 100%, 40%);">+               struct gsm_abis_mo mo;</span><br><span style="color: hsl(120, 100%, 40%);">+        } nm;</span><br><span> </span><br><span>    /* number of this BTS on given E1 link */</span><br><span>    uint8_t bts_nr;</span><br><span>diff --git a/include/osmocom/bsc/nm_bts_fsm.h b/include/osmocom/bsc/nm_bts_fsm.h</span><br><span>new file mode 100644</span><br><span>index 0000000..3b99762</span><br><span>--- /dev/null</span><br><span>+++ b/include/osmocom/bsc/nm_bts_fsm.h</span><br><span>@@ -0,0 +1,44 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* NM BTS FSM. Following 3GPP TS 12.21 Figure 2/GSM 12.21:</span><br><span style="color: hsl(120, 100%, 40%);">+  GSM 12.21 Objects' Operational state and availability status behaviour during initialization */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* (C) 2020 by sysmocom - s.m.f.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nm_bts_op_fsm_states {</span><br><span style="color: hsl(120, 100%, 40%);">+    NM_BTS_ST_OP_DISABLED_NOTINSTALLED,</span><br><span style="color: hsl(120, 100%, 40%);">+   NM_BTS_ST_OP_DISABLED_DEPENDENCY,</span><br><span style="color: hsl(120, 100%, 40%);">+     NM_BTS_ST_OP_DISABLED_OFFLINE,</span><br><span style="color: hsl(120, 100%, 40%);">+        NM_BTS_ST_OP_ENABLED,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nm_bts_op_fsm_events {</span><br><span style="color: hsl(120, 100%, 40%);">+      NM_BTS_EV_SW_ACT_REP,</span><br><span style="color: hsl(120, 100%, 40%);">+ NM_BTS_EV_STATE_CHG_REP,</span><br><span style="color: hsl(120, 100%, 40%);">+      NM_BTS_EV_SET_ATTR_ACK,</span><br><span style="color: hsl(120, 100%, 40%);">+       NM_BTS_EV_OPSTART_ACK,</span><br><span style="color: hsl(120, 100%, 40%);">+        NM_BTS_EV_OPSTART_NACK,</span><br><span style="color: hsl(120, 100%, 40%);">+       NM_BTS_EV_OML_DOWN,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct osmo_fsm nm_bts_fsm;</span><br><span>diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h</span><br><span>index abda67e..4922ac8 100644</span><br><span>--- a/include/osmocom/bsc/signal.h</span><br><span>+++ b/include/osmocom/bsc/signal.h</span><br><span>@@ -75,6 +75,7 @@</span><br><span>       S_NM_OPSTART_NACK,      /* Received OPSTART NACK, arg is struct msgb *oml_msg */</span><br><span>     S_NM_GET_ATTR_REP,      /* Received Get Attributes Response, arg is struct msgb *oml_msg */</span><br><span>  S_NM_SET_RADIO_ATTR_ACK, /* Received Set Radio Carrier Attributes Ack, arg is struct msgb *oml_msg */</span><br><span style="color: hsl(120, 100%, 40%);">+ S_NM_SET_BTS_ATTR_ACK,  /* Received Set BTS Attributes Ack, arg is struct msgb *oml_msg */</span><br><span> };</span><br><span> </span><br><span> /* SS_LCHAN signals */</span><br><span>diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am</span><br><span>index 08d6dd1..55d7408 100644</span><br><span>--- a/src/ipaccess/Makefile.am</span><br><span>+++ b/src/ipaccess/Makefile.am</span><br><span>@@ -55,6 +55,7 @@</span><br><span>      $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(OSMO_LIBS) \</span><br><span>       $(NULL)</span><br><span> </span><br><span>@@ -67,8 +68,10 @@</span><br><span>     $(top_builddir)/src/osmo-bsc/abis_nm.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/acc.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(OSMO_LIBS) \</span><br><span>       $(NULL)</span><br><span>diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am</span><br><span>index 48e38a0..e6fe3f9 100644</span><br><span>--- a/src/osmo-bsc/Makefile.am</span><br><span>+++ b/src/osmo-bsc/Makefile.am</span><br><span>@@ -73,6 +73,7 @@</span><br><span>     neighbor_ident_vty.c \</span><br><span>       net_init.c \</span><br><span>         nm_bts_sm_fsm.c \</span><br><span style="color: hsl(120, 100%, 40%);">+     nm_bts_fsm.c \</span><br><span>       gsm_08_08.c \</span><br><span>        osmo_bsc_bssap.c \</span><br><span>   osmo_bsc_ctrl.c \</span><br><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 769f73b..0ff1a88 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -842,11 +842,19 @@</span><br><span>       return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int abis_nm_rx_set_bts_attr_ack(struct msgb *mb)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        struct abis_om_fom_hdr *foh = msgb_l3(mb);</span><br><span style="color: hsl(120, 100%, 40%);">+    DEBUGPFOH(DNM, foh, "Set BTS Attributes ACK\n");</span><br><span style="color: hsl(120, 100%, 40%);">+    osmo_signal_dispatch(SS_NM, S_NM_SET_BTS_ATTR_ACK, mb);</span><br><span style="color: hsl(120, 100%, 40%);">+       return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> bool all_trx_rsl_connected_unlocked(const struct gsm_bts *bts)</span><br><span> {</span><br><span>        const struct gsm_bts_trx *trx;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if (bts->mo.nm_state.administrative == NM_STATE_LOCKED)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (bts->nm.mo.nm_state.administrative == NM_STATE_LOCKED)</span><br><span>                return false;</span><br><span> </span><br><span>    if (bts->gprs.mode != BTS_GPRS_NONE) {</span><br><span>@@ -978,7 +986,7 @@</span><br><span>              osmo_signal_dispatch(SS_NM, S_NM_IPACC_RESTART_NACK, NULL);</span><br><span>          break;</span><br><span>       case NM_MT_SET_BTS_ATTR_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">-            DEBUGPFOH(DNM, foh, "Set BTS Attribute ACK\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             abis_nm_rx_set_bts_attr_ack(mb);</span><br><span>             break;</span><br><span>       case NM_MT_GET_ATTR_RESP:</span><br><span>            ret = abis_nm_rx_get_attr_resp(mb, gsm_bts_trx_num(bts, (foh)->obj_inst.trx_nr));</span><br><span>diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c</span><br><span>index a3f689a..b8c71e8 100644</span><br><span>--- a/src/osmo-bsc/abis_om2000.c</span><br><span>+++ b/src/osmo-bsc/abis_om2000.c</span><br><span>@@ -898,7 +898,7 @@</span><br><span>              nm_state = &bts->rbs2000.con.mo.nm_state;</span><br><span>             break;</span><br><span>       case OM2K_MO_CLS_CF:</span><br><span style="color: hsl(0, 100%, 40%);">-            nm_state = &bts->mo.nm_state;</span><br><span style="color: hsl(120, 100%, 40%);">+          nm_state = &bts->nm.mo.nm_state;</span><br><span>              break;</span><br><span>       case OM2K_MO_CLS_TX:</span><br><span>                 trx = gsm_bts_trx_num(bts, mo->inst);</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 8808c20..1d35dc2 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -457,7 +457,7 @@</span><br><span>          vty_out(vty, "  Skip Reset: %d%s",</span><br><span>                         bts->nokia.skip_reset, VTY_NEWLINE);</span><br><span>      vty_out(vty, "  NM State: ");</span><br><span style="color: hsl(0, 100%, 40%);">- net_dump_nmstate(vty, &bts->mo.nm_state);</span><br><span style="color: hsl(120, 100%, 40%);">+      net_dump_nmstate(vty, &bts->nm.mo.nm_state);</span><br><span>  vty_out(vty, "  Site Mgr NM State: ");</span><br><span>     net_dump_nmstate(vty, &bts->site_mgr.mo.nm_state);</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 16cd51e..7396117 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -24,6 +24,7 @@</span><br><span> #include <osmocom/bsc/bts.h></span><br><span> #include <osmocom/bsc/debug.h></span><br><span> #include <osmocom/bsc/nm_bts_sm_fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_fsm.h></span><br><span> </span><br><span> const struct value_string bts_attribute_names[] = {</span><br><span>   OSMO_VALUE_STRING(BTS_TYPE_VARIANT),</span><br><span>@@ -153,6 +154,10 @@</span><br><span>          osmo_fsm_inst_free(bts->site_mgr.fi);</span><br><span>             bts->site_mgr.fi = NULL;</span><br><span>  }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (bts->nm.fi) {</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fsm_inst_free(bts->nm.fi);</span><br><span style="color: hsl(120, 100%, 40%);">+            bts->nm.fi = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span>    return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -178,7 +183,10 @@</span><br><span> </span><br><span>        bts->ms_max_power = 15;      /* dBm */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   gsm_mo_init(&bts->mo, bts, NM_OC_BTS,</span><br><span style="color: hsl(120, 100%, 40%);">+  bts->nm.fi = osmo_fsm_inst_alloc(&nm_bts_fsm, bts, bts,</span><br><span style="color: hsl(120, 100%, 40%);">+                                              LOGL_INFO, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_fsm_inst_update_id_f(bts->nm.fi, "bts%d", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+      gsm_mo_init(&bts->nm.mo, bts, NM_OC_BTS,</span><br><span>                      bts->nr, 0xff, 0xff);</span><br><span> </span><br><span>         bts->site_mgr.fi = osmo_fsm_inst_alloc(&nm_bts_sm_fsm, bts, bts,</span><br><span>@@ -581,7 +589,7 @@</span><br><span>        struct gsm_bts_trx *trx;</span><br><span>     unsigned int i;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     gsm_abis_mo_reset(&bts->mo);</span><br><span style="color: hsl(120, 100%, 40%);">+   gsm_abis_mo_reset(&bts->nm.mo);</span><br><span>       gsm_abis_mo_reset(&bts->site_mgr.mo);</span><br><span>         for (i = 0; i < ARRAY_SIZE(bts->gprs.nsvc); i++)</span><br><span>               gsm_abis_mo_reset(&bts->gprs.nsvc[i].mo);</span><br><span>@@ -641,7 +649,7 @@</span><br><span>       if (!bts->oml_link)</span><br><span>               return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return bts->mo.nm_state.operational == NM_OPSTATE_ENABLED;</span><br><span style="color: hsl(120, 100%, 40%);">+ return bts->nm.mo.nm_state.operational == NM_OPSTATE_ENABLED;</span><br><span> }</span><br><span> </span><br><span> int bts_depend_check(struct gsm_bts *bts)</span><br><span>diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>index df968ed..f450a16 100644</span><br><span>--- a/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>@@ -47,6 +47,7 @@</span><br><span> #include <osmocom/bsc/timeslot_fsm.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span> #include <osmocom/bsc/nm_bts_sm_fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_fsm.h></span><br><span> </span><br><span> static int bts_model_nanobts_start(struct gsm_network *net);</span><br><span> static void bts_model_nanobts_e1line_bind_ops(struct e1inp_line *line);</span><br><span>@@ -142,7 +143,7 @@</span><br><span> </span><br><span>         /* S_NM_STATECHG_ADM is called after we call chg_adm_state() and would create</span><br><span>         * endless loop */</span><br><span style="color: hsl(0, 100%, 40%);">-      if (evt != S_NM_STATECHG_OPER)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (obj_class != NM_OC_BTS && evt != S_NM_STATECHG_OPER)</span><br><span>             return 0;</span><br><span> </span><br><span>        switch (obj_class) {</span><br><span>@@ -152,16 +153,7 @@</span><br><span>          break;</span><br><span>       case NM_OC_BTS:</span><br><span>              bts = obj;</span><br><span style="color: hsl(0, 100%, 40%);">-              if (new_state->availability == NM_AVSTATE_DEPENDENCY) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      msgb = nanobts_attr_bts_get(bts);</span><br><span style="color: hsl(0, 100%, 40%);">-                       abis_nm_set_bts_attr(bts, msgb->data, msgb->len);</span><br><span style="color: hsl(0, 100%, 40%);">-                 msgb_free(msgb);</span><br><span style="color: hsl(0, 100%, 40%);">-                        abis_nm_chg_adm_state(bts, obj_class,</span><br><span style="color: hsl(0, 100%, 40%);">-                                         bts->bts_nr, 0xff, 0xff,</span><br><span style="color: hsl(0, 100%, 40%);">-                                             NM_STATE_UNLOCKED);</span><br><span style="color: hsl(0, 100%, 40%);">-                       abis_nm_opstart(bts, obj_class,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 bts->bts_nr, 0xff, 0xff);</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(120, 100%, 40%);">+             osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_STATE_CHG_REP, nsd);</span><br><span>                 break;</span><br><span>       case NM_OC_CHANNEL:</span><br><span>          ts = obj;</span><br><span>@@ -258,6 +250,9 @@</span><br><span>      case NM_OC_SITE_MANAGER:</span><br><span>             osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_SW_ACT_REP, NULL);</span><br><span>          break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_OC_BTS:</span><br><span style="color: hsl(120, 100%, 40%);">+               osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_SW_ACT_REP, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+            break;</span><br><span>       case NM_OC_BASEB_TRANSC:</span><br><span>             if (!(trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr)))</span><br><span>                  return -EINVAL;</span><br><span>@@ -319,6 +314,9 @@</span><br><span>        case NM_OC_SITE_MANAGER:</span><br><span>             osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_ACK, NULL);</span><br><span>                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_OC_BTS:</span><br><span style="color: hsl(120, 100%, 40%);">+               osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_OPSTART_ACK, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span>       case NM_OC_CHANNEL:</span><br><span>          nm_rx_opstart_ack_chan(oml_msg);</span><br><span>             break;</span><br><span>@@ -336,11 +334,28 @@</span><br><span>       case NM_OC_SITE_MANAGER:</span><br><span>             osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_NACK, NULL);</span><br><span>                break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_OC_BTS:</span><br><span style="color: hsl(120, 100%, 40%);">+               osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_OPSTART_ACK, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span>       default:</span><br><span>             break;</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void nm_rx_set_bts_attr_ack(struct msgb *oml_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+       struct abis_om_fom_hdr *foh = msgb_l3(oml_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+       struct e1inp_sign_link *sign_link = oml_msg->dst;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts *bts = sign_link->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    if (foh->obj_class != NM_OC_BTS) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOG_BTS(bts, DNM, LOGL_ERROR, "Set BTS Attr Ack received on non BTS object!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_SET_ATTR_ACK, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void nm_rx_set_radio_attr_ack(struct msgb *oml_msg)</span><br><span> {</span><br><span>       struct abis_om_fom_hdr *foh = msgb_l3(oml_msg);</span><br><span>@@ -375,6 +390,9 @@</span><br><span>        case S_NM_OPSTART_NACK:</span><br><span>              nm_rx_opstart_nack(signal_data);</span><br><span>             return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     case S_NM_SET_BTS_ATTR_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+           nm_rx_set_bts_attr_ack(signal_data);</span><br><span style="color: hsl(120, 100%, 40%);">+          return 0;</span><br><span>    case S_NM_SET_RADIO_ATTR_ACK:</span><br><span>                nm_rx_set_radio_attr_ack(signal_data);</span><br><span>               return 0;</span><br><span>@@ -460,6 +478,7 @@</span><br><span>              ipaccess_drop_rsl(trx, "OML link drop");</span><br><span> </span><br><span>       osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OML_DOWN, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_OML_DOWN, NULL);</span><br><span>     gsm_bts_all_ts_dispatch(bts, TS_EV_OML_DOWN, NULL);</span><br><span> </span><br><span>      bts->ip_access.flags = 0;</span><br><span>diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c</span><br><span>index 2b6f918..35a252b 100644</span><br><span>--- a/src/osmo-bsc/bts_nokia_site.c</span><br><span>+++ b/src/osmo-bsc/bts_nokia_site.c</span><br><span>@@ -1451,7 +1451,7 @@</span><br><span>         */</span><br><span>  struct gsm_bts_trx *trx;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    mo_ok(&bts->mo);</span><br><span style="color: hsl(120, 100%, 40%);">+       mo_ok(&bts->nm.mo);</span><br><span>   mo_ok(&bts->site_mgr.mo);</span><br><span> </span><br><span>         llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span>diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c</span><br><span>index 18fd5cf..1909d50 100644</span><br><span>--- a/src/osmo-bsc/gsm_data.c</span><br><span>+++ b/src/osmo-bsc/gsm_data.c</span><br><span>@@ -351,7 +351,7 @@</span><br><span> </span><br><span>  switch (obj_class) {</span><br><span>         case NM_OC_BTS:</span><br><span style="color: hsl(0, 100%, 40%);">-         mo = &bts->mo;</span><br><span style="color: hsl(120, 100%, 40%);">+         mo = &bts->nm.mo;</span><br><span>             break;</span><br><span>       case NM_OC_RADIO_CARRIER:</span><br><span>            if (obj_inst->trx_nr >= bts->num_trx) {</span><br><span>diff --git a/src/osmo-bsc/nm_bts_fsm.c b/src/osmo-bsc/nm_bts_fsm.c</span><br><span>new file mode 100644</span><br><span>index 0000000..0a580ad</span><br><span>--- /dev/null</span><br><span>+++ b/src/osmo-bsc/nm_bts_fsm.c</span><br><span>@@ -0,0 +1,363 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* NM BTS FSM */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* (C) 2020 by sysmocom - s.m.f.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <inttypes.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/tdef.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/protocol/gsm_12_21.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/signal.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/bts_ipaccess_nanobts_omlattr.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define X(s) (1 << (s))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define nm_bts_fsm_state_chg(fi, NEXT_STATE) \</span><br><span style="color: hsl(120, 100%, 40%);">+    osmo_fsm_inst_state_chg(fi, NEXT_STATE, 0, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+//////////////////////////</span><br><span style="color: hsl(120, 100%, 40%);">+// FSM STATE ACTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+//////////////////////////</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_notinstalled_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        bts->nm.set_bts_attr_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->nm.set_bts_attr_ack_received = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->nm.adm_unlock_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+   bts->nm.opstart_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+       struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_EV_SW_ACT_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+            break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_BTS_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+         nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        /*should not happen... */</span><br><span style="color: hsl(120, 100%, 40%);">+                     nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void configure_loop(struct gsm_bts *bts, struct gsm_nm_state *state, bool allow_opstart) {</span><br><span style="color: hsl(120, 100%, 40%);">+     struct msgb *msgb;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!bts->nm.set_bts_attr_sent && !bts->nm.set_bts_attr_ack_received) {</span><br><span style="color: hsl(120, 100%, 40%);">+         bts->nm.set_bts_attr_sent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+          msgb = nanobts_attr_bts_get(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+             abis_nm_set_bts_attr(bts, msgb->data, msgb->len);</span><br><span style="color: hsl(120, 100%, 40%);">+               msgb_free(msgb);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (state->administrative != NM_STATE_UNLOCKED && !bts->nm.adm_unlock_sent) {</span><br><span style="color: hsl(120, 100%, 40%);">+           bts->nm.adm_unlock_sent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+            abis_nm_chg_adm_state(bts, NM_OC_BTS,</span><br><span style="color: hsl(120, 100%, 40%);">+                               bts->bts_nr, 0xff, 0xff,</span><br><span style="color: hsl(120, 100%, 40%);">+                                   NM_STATE_UNLOCKED);</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (allow_opstart && state->administrative == NM_STATE_UNLOCKED &&</span><br><span style="color: hsl(120, 100%, 40%);">+     bts->nm.set_bts_attr_ack_received) {</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!bts->nm.opstart_sent) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       bts->nm.opstart_sent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+                       abis_nm_opstart(bts, NM_OC_BTS, bts->bts_nr, 0xff, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+                  }</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_dependency_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        /* nanoBTS is broken, doesn't follow TS 12.21. Opstart MUST be sent</span><br><span style="color: hsl(120, 100%, 40%);">+          during Dependency, so we simply move to OFFLINE state here to avoid</span><br><span style="color: hsl(120, 100%, 40%);">+           duplicating code */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (bts->type == GSM_BTS_TYPE_NANOBTS) {</span><br><span style="color: hsl(120, 100%, 40%);">+           nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+              return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     configure_loop(bts, &bts->nm.mo.nm_state, false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_dependency(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_EV_SET_ATTR_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+          bts->nm.set_bts_attr_ack_received = true;</span><br><span style="color: hsl(120, 100%, 40%);">+          bts->nm.set_bts_attr_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+         configure_loop(bts, &bts->nm.mo.nm_state, false);</span><br><span style="color: hsl(120, 100%, 40%);">+              return;</span><br><span style="color: hsl(120, 100%, 40%);">+       case NM_BTS_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+         nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* should not happen... */</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   configure_loop(bts, new_state, false);</span><br><span style="color: hsl(120, 100%, 40%);">+                        return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Warning: In here we may be acessing an state older than new_state</span><br><span style="color: hsl(120, 100%, 40%);">+     from prev (syncrhonous) FSM state */</span><br><span style="color: hsl(120, 100%, 40%);">+       configure_loop(bts, &bts->nm.mo.nm_state, true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_offline(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_EV_SET_ATTR_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+          bts->nm.set_bts_attr_ack_received = true;</span><br><span style="color: hsl(120, 100%, 40%);">+          bts->nm.set_bts_attr_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+         configure_loop(bts, &bts->nm.mo.nm_state, true);</span><br><span style="color: hsl(120, 100%, 40%);">+               return;</span><br><span style="color: hsl(120, 100%, 40%);">+       case NM_BTS_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+         nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* There's no point in moving back to Dependency in nanoBTS, since it's broken</span><br><span style="color: hsl(120, 100%, 40%);">+                           and it acts actually as if it was in Offline state */</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (bts->type != GSM_BTS_TYPE_NANOBTS) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                   } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                              /* Moreover, in nanoBTS we need to check here for tx</span><br><span style="color: hsl(120, 100%, 40%);">+                             Opstart since we may have gone Unlocked state</span><br><span style="color: hsl(120, 100%, 40%);">+                                 in this event, which means Opstart may be txed here. */</span><br><span style="color: hsl(120, 100%, 40%);">+                            configure_loop(bts, new_state, true);</span><br><span style="color: hsl(120, 100%, 40%);">+                 }</span><br><span style="color: hsl(120, 100%, 40%);">+                     return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   configure_loop(bts, new_state, true);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_enabled_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Reset state, we don't need it in this state and it will need to be</span><br><span style="color: hsl(120, 100%, 40%);">+       reused as soon as we move back to Disabled */</span><br><span style="color: hsl(120, 100%, 40%);">+       bts->nm.opstart_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+      bts->nm.adm_unlock_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+   bts->nm.set_bts_attr_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->nm.set_bts_attr_ack_received = false;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_enabled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+         nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED)</span><br><span style="color: hsl(120, 100%, 40%);">+                  return;</span><br><span style="color: hsl(120, 100%, 40%);">+               switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_EV_OPSTART_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+   case NM_BTS_EV_OPSTART_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+          /* TODO: if on state OFFLINE and rx NACK, try again? */</span><br><span style="color: hsl(120, 100%, 40%);">+               bts->nm.opstart_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_BTS_EV_OML_DOWN:</span><br><span style="color: hsl(120, 100%, 40%);">+              nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+         break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_fsm_state nm_bts_fsm_states[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+  [NM_BTS_ST_OP_DISABLED_NOTINSTALLED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+              .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_EV_SW_ACT_REP) |</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+           .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+                 X(NM_BTS_ST_OP_DISABLED_OFFLINE) |</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(NM_BTS_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+              .name = "DISABLED_NOTINSTALLED",</span><br><span style="color: hsl(120, 100%, 40%);">+            .onenter = st_op_disabled_notinstalled_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+              .action = st_op_disabled_notinstalled,</span><br><span style="color: hsl(120, 100%, 40%);">+        },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_ST_OP_DISABLED_DEPENDENCY] = {</span><br><span style="color: hsl(120, 100%, 40%);">+                .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_EV_STATE_CHG_REP) |</span><br><span style="color: hsl(120, 100%, 40%);">+                  X(NM_BTS_EV_SET_ATTR_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+            .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+                       X(NM_BTS_ST_OP_DISABLED_OFFLINE) |</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(NM_BTS_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+              .name = "DISABLED_DEPENDENCY",</span><br><span style="color: hsl(120, 100%, 40%);">+              .onenter = st_op_disabled_dependency_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+                .action = st_op_disabled_dependency,</span><br><span style="color: hsl(120, 100%, 40%);">+  },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_ST_OP_DISABLED_OFFLINE] = {</span><br><span style="color: hsl(120, 100%, 40%);">+           .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_EV_STATE_CHG_REP) |</span><br><span style="color: hsl(120, 100%, 40%);">+                  X(NM_BTS_EV_SET_ATTR_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+            .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+                       X(NM_BTS_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+                 X(NM_BTS_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+              .name = "DISABLED_OFFLINE",</span><br><span style="color: hsl(120, 100%, 40%);">+         .onenter = st_op_disabled_offline_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+           .action = st_op_disabled_offline,</span><br><span style="color: hsl(120, 100%, 40%);">+     },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_ST_OP_ENABLED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+    .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+              X(NM_BTS_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+   .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+             X(NM_BTS_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+               X(NM_BTS_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+         X(NM_BTS_ST_OP_DISABLED_OFFLINE),</span><br><span style="color: hsl(120, 100%, 40%);">+     .name = "ENABLED",</span><br><span style="color: hsl(120, 100%, 40%);">+  .onenter = st_op_enabled_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+    .action = st_op_enabled,</span><br><span style="color: hsl(120, 100%, 40%);">+      },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string nm_bts_fsm_event_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+      { NM_BTS_EV_SW_ACT_REP, "SW_ACT_REP" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { NM_BTS_EV_STATE_CHG_REP, "STATE_CHG_REP" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { NM_BTS_EV_SET_ATTR_ACK, "SET_ATTR_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { NM_BTS_EV_OPSTART_ACK, "OPSTART_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NM_BTS_EV_OPSTART_NACK, "OPSTART_NACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { NM_BTS_EV_OML_DOWN, "OML_DOWN" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct osmo_fsm nm_bts_fsm = {</span><br><span style="color: hsl(120, 100%, 40%);">+     .name = "NM_BTS_OP",</span><br><span style="color: hsl(120, 100%, 40%);">+        .states = nm_bts_fsm_states,</span><br><span style="color: hsl(120, 100%, 40%);">+  .num_states = ARRAY_SIZE(nm_bts_fsm_states),</span><br><span style="color: hsl(120, 100%, 40%);">+  .allstate_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                X(NM_BTS_EV_OPSTART_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+            X(NM_BTS_EV_OPSTART_NACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+           X(NM_BTS_EV_OML_DOWN),</span><br><span style="color: hsl(120, 100%, 40%);">+        .allstate_action = st_op_allstate,</span><br><span style="color: hsl(120, 100%, 40%);">+    .event_names = nm_bts_fsm_event_names,</span><br><span style="color: hsl(120, 100%, 40%);">+        .log_subsys = DNM,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static __attribute__((constructor)) void nm_bts_fsm_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(osmo_fsm_register(&nm_bts_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am</span><br><span>index 151437e..7040989 100644</span><br><span>--- a/src/utils/Makefile.am</span><br><span>+++ b/src/utils/Makefile.am</span><br><span>@@ -52,10 +52,12 @@</span><br><span>      $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/bts_siemens_bs11.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/e1_config.o \</span><br><span>   $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>@@ -124,9 +126,11 @@</span><br><span>         $(top_builddir)/src/osmo-bsc/abis_nm.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/acc.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>diff --git a/tests/abis/Makefile.am b/tests/abis/Makefile.am</span><br><span>index 28c284f..1a4b4d7 100644</span><br><span>--- a/tests/abis/Makefile.am</span><br><span>+++ b/tests/abis/Makefile.am</span><br><span>@@ -28,10 +28,12 @@</span><br><span>     $(top_builddir)/src/osmo-bsc/abis_nm.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/acc.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOABIS_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>diff --git a/tests/acc/Makefile.am b/tests/acc/Makefile.am</span><br><span>index 98362a9..b8372c1 100644</span><br><span>--- a/tests/acc/Makefile.am</span><br><span>+++ b/tests/acc/Makefile.am</span><br><span>@@ -28,10 +28,12 @@</span><br><span>  $(top_builddir)/src/osmo-bsc/abis_nm.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/acc.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOABIS_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>diff --git a/tests/acc/acc_test.ok b/tests/acc/acc_test.ok</span><br><span>index 6315a92..832c7f5 100644</span><br><span>--- a/tests/acc/acc_test.ok</span><br><span>+++ b/tests/acc/acc_test.ok</span><br><span>@@ -1,4 +1,5 @@</span><br><span> ===test_acc_mgr_no_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_no_ramp()</span><br><span>@@ -107,8 +108,10 @@</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> pcu_info_update(): t2=0x00 t3=0x00, allowed: 0 1 2 3 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_no_ramp()</span><br><span> ===test_acc_mgr_manual_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_manual_ramp()</span><br><span>@@ -347,8 +350,10 @@</span><br><span> (bts=0) ACC: New ACC allowed subset 0x24c (active_len=4, ramp_len=4, adm_len=4, perm_len=4, rotation=off)</span><br><span> pcu_info_update(): t2=0x01 t3=0xb3, allowed: 2 3 6 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_manual_ramp()</span><br><span> ===test_acc_mgr_rotate(true, 1)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -418,8 +423,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x001 -> 0x002 (active_len=1, ramp_len=10, adm_len=1, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xfd, allowed: 1</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 1)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -486,8 +493,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x100 -> 0x200 (active_len=1, ramp_len=10, adm_len=1, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x01 t3=0xff, allowed: 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 2)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -557,8 +566,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x101 -> 0x003 (active_len=2, ramp_len=10, adm_len=2, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xfc, allowed: 0 1</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 2)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -625,8 +636,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x180 -> 0x300 (active_len=2, ramp_len=10, adm_len=2, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0xff, allowed: 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 3)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -696,8 +709,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x181 -> 0x103 (active_len=3, ramp_len=10, adm_len=3, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0xfc, allowed: 0 1 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 3)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -764,8 +779,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1c0 -> 0x380 (active_len=3, ramp_len=10, adm_len=3, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x7f, allowed: 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 4)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -835,8 +852,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1c1 -> 0x183 (active_len=4, ramp_len=10, adm_len=4, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x7c, allowed: 0 1 7 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 4)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -903,8 +922,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1e0 -> 0x3c0 (active_len=4, ramp_len=10, adm_len=4, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x3f, allowed: 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -974,8 +995,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1e1 -> 0x1c3 (active_len=5, ramp_len=10, adm_len=5, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x3c, allowed: 0 1 6 7 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1042,8 +1065,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f0 -> 0x3e0 (active_len=5, ramp_len=10, adm_len=5, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x1f, allowed: 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 6)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1113,8 +1138,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f1 -> 0x1e3 (active_len=6, ramp_len=10, adm_len=6, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x1c, allowed: 0 1 5 6 7 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 6)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1181,8 +1208,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f8 -> 0x3f0 (active_len=6, ramp_len=10, adm_len=6, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x0f, allowed: 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 7)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1252,8 +1281,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f9 -> 0x1f3 (active_len=7, ramp_len=10, adm_len=7, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x0c, allowed: 0 1 4 5 6 7 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 7)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1320,8 +1351,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fc -> 0x3f8 (active_len=7, ramp_len=10, adm_len=7, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x07, allowed: 3 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 8)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1391,8 +1424,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fd -> 0x1fb (active_len=8, ramp_len=10, adm_len=8, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x04, allowed: 0 1 3 4 5 6 7 8</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 8)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1459,8 +1494,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fe -> 0x3fc (active_len=8, ramp_len=10, adm_len=8, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x03, allowed: 2 3 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 9)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span>@@ -1527,8 +1564,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1ff -> 0x3fe (active_len=9, ramp_len=10, adm_len=9, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x01, allowed: 1 2 3 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp()</span><br><span>@@ -1564,8 +1603,10 @@</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x1ff -> 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> pcu_info_update(): t2=0x00 t3=0x00, allowed: 0 1 2 3 4 5 6 7 8 9</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp()</span><br><span> ===test_acc_ramp2===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp2()</span><br><span>@@ -1583,8 +1624,10 @@</span><br><span> pcu_info_update(): t2=0x03 t3=0x80, allowed: 0 1 2 3 4 5 6</span><br><span> sys={15.000000}: select()</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp2()</span><br><span> ===test_acc_ramp3===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp3()</span><br><span>@@ -1618,8 +1661,10 @@</span><br><span> sys={45.000000}: select()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x15a -> 0x15a (active_len=5, ramp_len=10, adm_len=10, perm_len=5, rotation=off)</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp3()</span><br><span> ===test_acc_ramp_up_rotate(0, 100, 100)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span>@@ -1709,8 +1754,10 @@</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_up_rotate(0, 20, 50)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span>@@ -1800,8 +1847,10 @@</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_up_rotate(70, 80, 90)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span>@@ -1891,8 +1940,10 @@</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(80, 90, 0, 100, 15)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span>@@ -2012,8 +2063,10 @@</span><br><span> sys={7250.000000}: select(48): chan_load_avg=90</span><br><span> sys={7500.000000}: select(49): chan_load_avg=100</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(30, 50, 10, 100, 15)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span>@@ -2157,8 +2210,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x003 -> 0x006 (active_len=2, ramp_len=2, adm_len=10, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xf9, allowed: 1 2</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(50, 49, 0, 100, 10)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span>@@ -2312,8 +2367,10 @@</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x01c -> 0x038 (active_len=3, ramp_len=3, adm_len=10, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xc7, allowed: 3 4 5</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(30, 80, 30, 80, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span>@@ -2373,4 +2430,5 @@</span><br><span> sys={12250.000000}: select(48): chan_load_avg=70</span><br><span> sys={12500.000000}: select(49): chan_load_avg=75</span><br><span> NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_OP(bts0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span>diff --git a/tests/bsc/Makefile.am b/tests/bsc/Makefile.am</span><br><span>index 0c5f47f..1fd7396 100644</span><br><span>--- a/tests/bsc/Makefile.am</span><br><span>+++ b/tests/bsc/Makefile.am</span><br><span>@@ -39,6 +39,7 @@</span><br><span>  $(top_builddir)/src/osmo-bsc/osmo_bsc_filter.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/bsc_subscriber.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/handover_cfg.o \</span><br><span>@@ -46,6 +47,7 @@</span><br><span>    $(top_builddir)/src/osmo-bsc/neighbor_ident.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOVTY_LIBS) \</span><br><span>diff --git a/tests/gsm0408/Makefile.am b/tests/gsm0408/Makefile.am</span><br><span>index 5525670..1cbaca5 100644</span><br><span>--- a/tests/gsm0408/Makefile.am</span><br><span>+++ b/tests/gsm0408/Makefile.am</span><br><span>@@ -28,6 +28,7 @@</span><br><span>    $(top_builddir)/src/osmo-bsc/gsm_04_08_rr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/arfcn_range_encode.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span style="color: hsl(120, 100%, 40%);">+  $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>@@ -35,6 +36,7 @@</span><br><span>        $(top_builddir)/src/osmo-bsc/system_information.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/neighbor_ident.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am</span><br><span>index c4b6932..e478882 100644</span><br><span>--- a/tests/handover/Makefile.am</span><br><span>+++ b/tests/handover/Makefile.am</span><br><span>@@ -81,6 +81,7 @@</span><br><span>       $(top_builddir)/src/osmo-bsc/neighbor_ident_vty.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/osmo_bsc_ctrl.o \</span><br><span>       $(top_builddir)/src/osmo-bsc/osmo_bsc_lcls.o \</span><br><span>       $(top_builddir)/src/osmo-bsc/osmo_bsc_mgcp.o \</span><br><span>diff --git a/tests/nanobts_omlattr/Makefile.am b/tests/nanobts_omlattr/Makefile.am</span><br><span>index e4c9581..5f65337 100644</span><br><span>--- a/tests/nanobts_omlattr/Makefile.am</span><br><span>+++ b/tests/nanobts_omlattr/Makefile.am</span><br><span>@@ -30,6 +30,7 @@</span><br><span>  $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(top_builddir)/src/osmo-bsc/nm_bts_fsm.o \</span><br><span>  $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20401">change 20401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7756a8ce90b6cc8a502b5665889a7987d7f749cb </div>
<div style="display:none"> Gerrit-Change-Number: 20401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>