<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20385">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests: introduce TC_tch_dlci_link_id_sapi for OS#3716<br><br>The aim of this test case is to verify DLCI / RSL Link ID conversion<br>for MO/MT L3 messages on SAPI0/SAPI3. In particular, the test suite<br>verifies the following scenarios:<br><br> - RSL -> BSSAP:<br> - 16 MO messages on FACCH/F with SAPI0,<br> - 16 MO messages on SACCH/F with SAPI3;<br> - BSSAP -> RSL:<br> - 16 MT messages on FACCH/F with SAPI0,<br> - 16 MT messages on SACCH/F with SAPI3.<br><br>Change-Id: Ica69ae95b47a67ba99ba9cc36629b6bd210d11e4<br>Related: OS#3716<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/expected-results.xml<br>2 files changed, 60 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 0632852..20fcf36 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -2024,6 +2024,62 @@</span><br><span> f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify DLCI / RSL Link ID conversion for MO/MT messages on SAPI0/SAPI3 */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_tch_dlci_link_id_sapi(charstring id) runs on MSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_BSSAP ass_cmd := f_gen_ass_req();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);</span><br><span style="color: hsl(120, 100%, 40%);">+ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(ass_cmd, exp_compl);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SAPI0 has already been established by f_establish_fully(), establish SAPI3 */</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.send(ts_RSL_EST_IND(g_chan_nr, ts_RslLinkID_SACCH(3), '0904'O));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect BSSAP/DTAP on SAPI3 (DLCI IE) */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(PDU_BSSAP:{</span><br><span style="color: hsl(120, 100%, 40%);">+ discriminator := '1'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ spare := '0000000'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ dlci := 'C3'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ lengthIndicator := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ pdu := { dtap := '0904'O }</span><br><span style="color: hsl(120, 100%, 40%);">+ });</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send messages on DCCH/SAPI0 and ACCH/SAPI3 */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < 32; i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l3 := '09'O & f_rnd_octstring(14);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) RslLinkId link_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) OCT1 dlci;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i mod 2 == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SAPI0 on FACCH or SDCCH */</span><br><span style="color: hsl(120, 100%, 40%);">+ link_id := ts_RslLinkID_DCCH(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ dlci := '80'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SAPI3 on SACCH */</span><br><span style="color: hsl(120, 100%, 40%);">+ link_id := ts_RslLinkID_SACCH(3);</span><br><span style="color: hsl(120, 100%, 40%);">+ dlci := 'C3'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send MO message: RSL -> BSSAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_l3_transceive(link_id, dlci, l3);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send MT message: BSSAP -> RSL */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_l3_transceive(link_id, dlci, l3);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_tch_dlci_link_id_sapi() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var TestHdlrParams pars := f_gen_test_hdlr_pars();</span><br><span style="color: hsl(120, 100%, 40%);">+ var MSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(1, true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_tch_dlci_link_id_sapi), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown_helper();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_exp_sapi_n_reject(template (present) GsmSapi sapi := ?,</span><br><span> template myBSSMAP_Cause cause := ?,</span><br><span> float T_val := 2.0)</span><br><span>@@ -7624,6 +7680,9 @@</span><br><span> execute( TC_rll_est_ind_inval_sapi3() );</span><br><span> execute( TC_rll_est_ind_inval_sacch() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* DLCI / RSL Link ID conversion for MO/MT messages on SAPI0/SAPI3 */</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_tch_dlci_link_id_sapi() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* SAPI N Reject triggered by RLL establishment failures */</span><br><span> execute( TC_rll_rel_ind_sapi_n_reject() );</span><br><span> execute( TC_rll_err_ind_sapi_n_reject() );</span><br><span>diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml</span><br><span>index 5221eae..6ab542a 100644</span><br><span>--- a/bsc/expected-results.xml</span><br><span>+++ b/bsc/expected-results.xml</span><br><span>@@ -88,6 +88,7 @@</span><br><span> <testcase classname='BSC_Tests' name='TC_rll_est_ind_inval_sapi1' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rll_est_ind_inval_sapi3' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rll_est_ind_inval_sacch' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests' name='TC_tch_dlci_link_id_sapi' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rll_rel_ind_sapi_n_reject' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rll_err_ind_sapi_n_reject' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rll_timeout_sapi_n_reject' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20385">change 20385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20385"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ica69ae95b47a67ba99ba9cc36629b6bd210d11e4 </div>
<div style="display:none"> Gerrit-Change-Number: 20385 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>