<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409/2/include/osmo-bts/bts.h">File include/osmo-bts/bts.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409/2/include/osmo-bts/bts.h@139">Patch Set #2, Line 139:</a> <code style="font-family:monospace,monospace">bool</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">there we have the same change as in the last commit. one more reason to move thsoe into gsm_abis_mo itself.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409/2/include/osmo-bts/nm_bts_fsm.h">File include/osmo-bts/nm_bts_fsm.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409/2/include/osmo-bts/nm_bts_fsm.h@34">Patch Set #2, Line 34:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enum nm_bts_op_fsm_events {<br>   NM_BTS_EV_SW_ACT,<br>     NM_BTS_EV_OPSTART_ACK,<br>        NM_BTS_EV_OPSTART_NACK,<br>};<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">maybe all those OML MO FSMs should have a common/shared set of events, plus some extra MO-specific events as needed?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20409">change 20409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iae631bcc7acdf955296b124707e42d5e565af186 </div>
<div style="display:none"> Gerrit-Change-Number: 20409 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 02 Oct 2020 21:45:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>