<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20400">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce NM BTS Site Manager FSM<br><br>Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e<br>---<br>M include/osmocom/bsc/Makefile.am<br>M include/osmocom/bsc/bts.h<br>A include/osmocom/bsc/nm_bts_sm_fsm.h<br>M include/osmocom/bsc/signal.h<br>M src/ipaccess/Makefile.am<br>M src/osmo-bsc/Makefile.am<br>M src/osmo-bsc/abis_nm.c<br>M src/osmo-bsc/bts.c<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>A src/osmo-bsc/nm_bts_sm_fsm.c<br>M src/utils/Makefile.am<br>M tests/abis/Makefile.am<br>M tests/acc/Makefile.am<br>M tests/acc/acc_test.c<br>M tests/acc/acc_test.ok<br>M tests/bsc/Makefile.am<br>M tests/gsm0408/Makefile.am<br>M tests/handover/Makefile.am<br>M tests/nanobts_omlattr/Makefile.am<br>19 files changed, 465 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/20400/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am</span><br><span>index 1ee96ed..b25c95a 100644</span><br><span>--- a/include/osmocom/bsc/Makefile.am</span><br><span>+++ b/include/osmocom/bsc/Makefile.am</span><br><span>@@ -35,6 +35,7 @@</span><br><span>      misdn.h \</span><br><span>    neighbor_ident.h \</span><br><span>   network_listen.h \</span><br><span style="color: hsl(120, 100%, 40%);">+    nm_bts_sm_fsm.h \</span><br><span>    openbscdefines.h \</span><br><span>   osmo_bsc.h \</span><br><span>         osmo_bsc_grace.h \</span><br><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index 7f36904..063a531 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -426,6 +426,8 @@</span><br><span>    struct gsm_bts_trx *c0;</span><br><span> </span><br><span>  struct {</span><br><span style="color: hsl(120, 100%, 40%);">+              struct osmo_fsm_inst *fi;</span><br><span style="color: hsl(120, 100%, 40%);">+             bool opstart_sent;</span><br><span>           struct gsm_abis_mo mo;</span><br><span>       } site_mgr;</span><br><span> </span><br><span>diff --git a/include/osmocom/bsc/nm_bts_sm_fsm.h b/include/osmocom/bsc/nm_bts_sm_fsm.h</span><br><span>new file mode 100644</span><br><span>index 0000000..caa46d0</span><br><span>--- /dev/null</span><br><span>+++ b/include/osmocom/bsc/nm_bts_sm_fsm.h</span><br><span>@@ -0,0 +1,43 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* NM BTS Site Manager FSM. Following 3GPP TS 12.21 Figure 2/GSM 12.21:</span><br><span style="color: hsl(120, 100%, 40%);">+  GSM 12.21 Objects' Operational state and availability status behaviour during initialization */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* (C) 2020 by sysmocom - s.m.f.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nm_bts_sm_op_fsm_states {</span><br><span style="color: hsl(120, 100%, 40%);">+   NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED,</span><br><span style="color: hsl(120, 100%, 40%);">+        NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY,</span><br><span style="color: hsl(120, 100%, 40%);">+  NM_BTS_SM_ST_OP_DISABLED_OFFLINE,</span><br><span style="color: hsl(120, 100%, 40%);">+     NM_BTS_SM_ST_OP_ENABLED,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nm_bts_sm_op_fsm_events {</span><br><span style="color: hsl(120, 100%, 40%);">+        NM_BTS_SM_EV_SW_ACT_REP,</span><br><span style="color: hsl(120, 100%, 40%);">+      NM_BTS_SM_EV_STATE_CHG_REP,</span><br><span style="color: hsl(120, 100%, 40%);">+   NM_BTS_SM_EV_OPSTART_ACK,</span><br><span style="color: hsl(120, 100%, 40%);">+     NM_BTS_SM_EV_OPSTART_NACK,</span><br><span style="color: hsl(120, 100%, 40%);">+    NM_BTS_SM_EV_OML_DOWN,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct osmo_fsm nm_bts_sm_fsm;</span><br><span>diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h</span><br><span>index c7d7fe1..abda67e 100644</span><br><span>--- a/include/osmocom/bsc/signal.h</span><br><span>+++ b/include/osmocom/bsc/signal.h</span><br><span>@@ -72,6 +72,7 @@</span><br><span>         S_NM_STATECHG_ADM,      /* Administrative State changed */</span><br><span>   S_NM_OM2K_CONF_RES,     /* OM2K Configuration Result */</span><br><span>      S_NM_OPSTART_ACK,       /* Received OPSTART ACK, arg is struct msgb *oml_msg */</span><br><span style="color: hsl(120, 100%, 40%);">+       S_NM_OPSTART_NACK,      /* Received OPSTART NACK, arg is struct msgb *oml_msg */</span><br><span>     S_NM_GET_ATTR_REP,      /* Received Get Attributes Response, arg is struct msgb *oml_msg */</span><br><span>  S_NM_SET_RADIO_ATTR_ACK, /* Received Set Radio Carrier Attributes Ack, arg is struct msgb *oml_msg */</span><br><span> };</span><br><span>diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am</span><br><span>index 717a6a1..08d6dd1 100644</span><br><span>--- a/src/ipaccess/Makefile.am</span><br><span>+++ b/src/ipaccess/Makefile.am</span><br><span>@@ -54,6 +54,7 @@</span><br><span>         $(top_builddir)/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o \</span><br><span>        $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(OSMO_LIBS) \</span><br><span>       $(NULL)</span><br><span> </span><br><span>@@ -68,5 +69,6 @@</span><br><span>      $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(OSMO_LIBS) \</span><br><span>       $(NULL)</span><br><span>diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am</span><br><span>index c19d01b..48e38a0 100644</span><br><span>--- a/src/osmo-bsc/Makefile.am</span><br><span>+++ b/src/osmo-bsc/Makefile.am</span><br><span>@@ -72,6 +72,7 @@</span><br><span>     neighbor_ident.c \</span><br><span>   neighbor_ident_vty.c \</span><br><span>       net_init.c \</span><br><span style="color: hsl(120, 100%, 40%);">+  nm_bts_sm_fsm.c \</span><br><span>    gsm_08_08.c \</span><br><span>        osmo_bsc_bssap.c \</span><br><span>   osmo_bsc_ctrl.c \</span><br><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 7cd50ed..769f73b 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -826,6 +826,14 @@</span><br><span>        return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int abis_nm_rx_opstart_nack(struct msgb *mb)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    struct abis_om_fom_hdr *foh = msgb_l3(mb);</span><br><span style="color: hsl(120, 100%, 40%);">+    DEBUGPFOH(DNM, foh, "Opstart NACK\n");</span><br><span style="color: hsl(120, 100%, 40%);">+      osmo_signal_dispatch(SS_NM, S_NM_OPSTART_NACK, mb);</span><br><span style="color: hsl(120, 100%, 40%);">+   return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static int abis_nm_rx_set_radio_attr_ack(struct msgb *mb)</span><br><span> {</span><br><span>     struct abis_om_fom_hdr *foh = msgb_l3(mb);</span><br><span>@@ -947,7 +955,10 @@</span><br><span>            ret = abis_nm_rx_lmt_event(mb);</span><br><span>              break;</span><br><span>       case NM_MT_OPSTART_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">-         abis_nm_rx_opstart_ack(mb);</span><br><span style="color: hsl(120, 100%, 40%);">+           ret = abis_nm_rx_opstart_ack(mb);</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_MT_OPSTART_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+              ret = abis_nm_rx_opstart_nack(mb);</span><br><span>           break;</span><br><span>       case NM_MT_SET_CHAN_ATTR_ACK:</span><br><span>                DEBUGPFOH(DNM, foh, "Set Channel Attributes ACK\n");</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index ce1b200..16cd51e 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -23,6 +23,7 @@</span><br><span> #include <osmocom/bsc/gsm_data.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span> #include <osmocom/bsc/debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_sm_fsm.h></span><br><span> </span><br><span> const struct value_string bts_attribute_names[] = {</span><br><span>    OSMO_VALUE_STRING(BTS_TYPE_VARIANT),</span><br><span>@@ -146,6 +147,15 @@</span><br><span>  .initial_mcs = 6,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int gsm_bts_talloc_destructor(struct gsm_bts *bts)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     if (bts->site_mgr.fi) {</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_fsm_inst_free(bts->site_mgr.fi);</span><br><span style="color: hsl(120, 100%, 40%);">+              bts->site_mgr.fi = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+     return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Initialize those parts that don't require osmo-bsc specific dependencies.</span><br><span>  * This part is shared among the thin programs in osmo-bsc/src/utils/.</span><br><span>  * osmo-bsc requires further initialization that pulls in more dependencies (see</span><br><span>@@ -159,6 +169,8 @@</span><br><span>       if (!bts)</span><br><span>            return NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      talloc_set_destructor(bts, gsm_bts_talloc_destructor);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     bts->nr = bts_num;</span><br><span>        bts->num_trx = 0;</span><br><span>         INIT_LLIST_HEAD(&bts->trx_list);</span><br><span>@@ -168,6 +180,10 @@</span><br><span> </span><br><span>   gsm_mo_init(&bts->mo, bts, NM_OC_BTS,</span><br><span>                         bts->nr, 0xff, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    bts->site_mgr.fi = osmo_fsm_inst_alloc(&nm_bts_sm_fsm, bts, bts,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             LOGL_INFO, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_fsm_inst_update_id_f(bts->site_mgr.fi, "bts_sm%d", bts->nr);</span><br><span>    gsm_mo_init(&bts->site_mgr.mo, bts, NM_OC_SITE_MANAGER,</span><br><span>                       0xff, 0xff, 0xff);</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>index e02eabc..df968ed 100644</span><br><span>--- a/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>@@ -46,6 +46,7 @@</span><br><span> #include <osmocom/bsc/paging.h></span><br><span> #include <osmocom/bsc/timeslot_fsm.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_sm_fsm.h></span><br><span> </span><br><span> static int bts_model_nanobts_start(struct gsm_network *net);</span><br><span> static void bts_model_nanobts_e1line_bind_ops(struct e1inp_line *line);</span><br><span>@@ -147,11 +148,7 @@</span><br><span>        switch (obj_class) {</span><br><span>         case NM_OC_SITE_MANAGER:</span><br><span>             bts = container_of(obj, struct gsm_bts, site_mgr);</span><br><span style="color: hsl(0, 100%, 40%);">-              if ((new_state->operational == NM_OPSTATE_ENABLED &&</span><br><span style="color: hsl(0, 100%, 40%);">-              new_state->availability == NM_AVSTATE_OK) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                (new_state->operational == NM_OPSTATE_DISABLED &&</span><br><span style="color: hsl(0, 100%, 40%);">-                     new_state->availability == NM_AVSTATE_OFF_LINE))</span><br><span style="color: hsl(0, 100%, 40%);">-                        abis_nm_opstart(bts, obj_class, 0xff, 0xff, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_STATE_CHG_REP, nsd);</span><br><span>                break;</span><br><span>       case NM_OC_BTS:</span><br><span>              bts = obj;</span><br><span>@@ -252,16 +249,18 @@</span><br><span>   struct abis_om_fom_hdr *foh = msgb_l3(mb);</span><br><span>   struct e1inp_sign_link *sign_link = mb->dst;</span><br><span>      struct gsm_bts *bts = sign_link->trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct gsm_bts_trx *trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+      struct gsm_bts_trx *trx;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (!trx)</span><br><span style="color: hsl(0, 100%, 40%);">-               return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!is_ipaccess_bts(trx->bts))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!is_ipaccess_bts(bts))</span><br><span>           return 0;</span><br><span> </span><br><span>        switch (foh->obj_class) {</span><br><span style="color: hsl(120, 100%, 40%);">+  case NM_OC_SITE_MANAGER:</span><br><span style="color: hsl(120, 100%, 40%);">+              osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_SW_ACT_REP, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span>       case NM_OC_BASEB_TRANSC:</span><br><span style="color: hsl(120, 100%, 40%);">+              if (!(trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr)))</span><br><span style="color: hsl(120, 100%, 40%);">+                   return -EINVAL;</span><br><span>              abis_nm_chg_adm_state(trx->bts, foh->obj_class,</span><br><span>                                      trx->bts->bts_nr, trx->nr, 0xff,</span><br><span>                                    NM_STATE_UNLOCKED);</span><br><span>@@ -272,6 +271,8 @@</span><br><span>                                           3003, trx->rsl_tei);</span><br><span>                 break;</span><br><span>       case NM_OC_RADIO_CARRIER: {</span><br><span style="color: hsl(120, 100%, 40%);">+           if (!(trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr)))</span><br><span style="color: hsl(120, 100%, 40%);">+                   return -EINVAL;</span><br><span>              /*</span><br><span>            * Locking the radio carrier will make it go</span><br><span>                  * offline again and we would come here. The</span><br><span>@@ -312,7 +313,12 @@</span><br><span> static void nm_rx_opstart_ack(struct msgb *oml_msg)</span><br><span> {</span><br><span>      struct abis_om_fom_hdr *foh = msgb_l3(oml_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+       struct e1inp_sign_link *sign_link = oml_msg->dst;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts *bts = sign_link->trx->bts;</span><br><span>     switch (foh->obj_class) {</span><br><span style="color: hsl(120, 100%, 40%);">+  case NM_OC_SITE_MANAGER:</span><br><span style="color: hsl(120, 100%, 40%);">+              osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_ACK, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       case NM_OC_CHANNEL:</span><br><span>          nm_rx_opstart_ack_chan(oml_msg);</span><br><span>             break;</span><br><span>@@ -321,6 +327,20 @@</span><br><span>        }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void nm_rx_opstart_nack(struct msgb *oml_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct abis_om_fom_hdr *foh = msgb_l3(oml_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+       struct e1inp_sign_link *sign_link = oml_msg->dst;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_bts *bts = sign_link->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+      switch (foh->obj_class) {</span><br><span style="color: hsl(120, 100%, 40%);">+  case NM_OC_SITE_MANAGER:</span><br><span style="color: hsl(120, 100%, 40%);">+              osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_NACK, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+         break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void nm_rx_set_radio_attr_ack(struct msgb *oml_msg)</span><br><span> {</span><br><span>    struct abis_om_fom_hdr *foh = msgb_l3(oml_msg);</span><br><span>@@ -352,6 +372,9 @@</span><br><span>        case S_NM_OPSTART_ACK:</span><br><span>               nm_rx_opstart_ack(signal_data);</span><br><span>              return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     case S_NM_OPSTART_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+               nm_rx_opstart_nack(signal_data);</span><br><span style="color: hsl(120, 100%, 40%);">+              return 0;</span><br><span>    case S_NM_SET_RADIO_ATTR_ACK:</span><br><span>                nm_rx_set_radio_attr_ack(signal_data);</span><br><span>               return 0;</span><br><span>@@ -436,6 +459,7 @@</span><br><span>      llist_for_each_entry(trx, &bts->trx_list, list)</span><br><span>               ipaccess_drop_rsl(trx, "OML link drop");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OML_DOWN, NULL);</span><br><span>    gsm_bts_all_ts_dispatch(bts, TS_EV_OML_DOWN, NULL);</span><br><span> </span><br><span>      bts->ip_access.flags = 0;</span><br><span>diff --git a/src/osmo-bsc/nm_bts_sm_fsm.c b/src/osmo-bsc/nm_bts_sm_fsm.c</span><br><span>new file mode 100644</span><br><span>index 0000000..0f66f38</span><br><span>--- /dev/null</span><br><span>+++ b/src/osmo-bsc/nm_bts_sm_fsm.c</span><br><span>@@ -0,0 +1,286 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* NM BTS Site Manager FSM */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* (C) 2020 by sysmocom - s.m.f.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <inttypes.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/tdef.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/protocol/gsm_12_21.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/signal.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/nm_bts_sm_fsm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define X(s) (1 << (s))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define nm_bts_sm_fsm_state_chg(fi, NEXT_STATE) \</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_inst_state_chg(fi, NEXT_STATE, 0, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+//////////////////////////</span><br><span style="color: hsl(120, 100%, 40%);">+// FSM STATE ACTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+//////////////////////////</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_notinstalled_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        bts->site_mgr.opstart_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_SM_EV_SW_ACT_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+         break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_BTS_SM_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+              nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* nanobts always go directly into Reported ENABLED state during</span><br><span style="color: hsl(120, 100%, 40%);">+                         startup, but we still need to OPSTART it, otherwise it won't</span><br><span style="color: hsl(120, 100%, 40%);">+                      connect on RSL later on */</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (bts->type == GSM_BTS_TYPE_NANOBTS) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           bts->site_mgr.opstart_sent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+                         abis_nm_opstart(bts, NM_OC_SITE_MANAGER, 0xff, 0xff, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+                   } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                              LOGPFSML(fi, LOGL_NOTICE, "Received BTS Site Mgr State Report Enabled "</span><br><span style="color: hsl(120, 100%, 40%);">+                                      "without Opstart. You are probably using a nanoBTS but don't "</span><br><span style="color: hsl(120, 100%, 40%);">+                                  "have your .cfg with 'type nanobts'\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                   }</span><br><span style="color: hsl(120, 100%, 40%);">+                     nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                     return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                        return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_dependency(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_SM_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+              nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                        return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_offline_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!bts->site_mgr.opstart_sent) {</span><br><span style="color: hsl(120, 100%, 40%);">+         bts->site_mgr.opstart_sent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+         abis_nm_opstart(bts, NM_OC_SITE_MANAGER, 0xff, 0xff, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_disabled_offline(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_SM_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+              nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_ENABLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                     return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_enabled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      struct nm_statechg_signal_data *nsd;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_nm_state *new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_SM_EV_STATE_CHG_REP:</span><br><span style="color: hsl(120, 100%, 40%);">+              nsd = (struct nm_statechg_signal_data *)data;</span><br><span style="color: hsl(120, 100%, 40%);">+         new_state = nsd->new_state;</span><br><span style="color: hsl(120, 100%, 40%);">+                if (new_state->operational == NM_OPSTATE_ENABLED)</span><br><span style="color: hsl(120, 100%, 40%);">+                  return;</span><br><span style="color: hsl(120, 100%, 40%);">+               switch (new_state->availability) { /* operational = DISABLED */</span><br><span style="color: hsl(120, 100%, 40%);">+            case NM_AVSTATE_NOT_INSTALLED:</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_AVSTATE_POWER_OFF:</span><br><span style="color: hsl(120, 100%, 40%);">+                    nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+                   return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_DEPENDENCY:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+                     return;</span><br><span style="color: hsl(120, 100%, 40%);">+               case NM_AVSTATE_OFF_LINE:</span><br><span style="color: hsl(120, 100%, 40%);">+             case NM_AVSTATE_OK:</span><br><span style="color: hsl(120, 100%, 40%);">+                   nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_OFFLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                        return;</span><br><span style="color: hsl(120, 100%, 40%);">+               default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+     default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void st_op_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case NM_BTS_SM_EV_OPSTART_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_BTS_SM_EV_OPSTART_NACK:</span><br><span style="color: hsl(120, 100%, 40%);">+               /* TODO: if on state OFFLINE and rx NACK, try again? */</span><br><span style="color: hsl(120, 100%, 40%);">+               bts->site_mgr.opstart_sent = false;</span><br><span style="color: hsl(120, 100%, 40%);">+                break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case NM_BTS_SM_EV_OML_DOWN:</span><br><span style="color: hsl(120, 100%, 40%);">+           nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED);</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_fsm_state nm_bts_sm_fsm_states[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+       [NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+           .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_EV_SW_ACT_REP) |</span><br><span style="color: hsl(120, 100%, 40%);">+                  X(NM_BTS_SM_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+                .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_ST_OP_DISABLED_OFFLINE) |</span><br><span style="color: hsl(120, 100%, 40%);">+                 X(NM_BTS_SM_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+           .name = "DISABLED_NOTINSTALLED",</span><br><span style="color: hsl(120, 100%, 40%);">+            .onenter = st_op_disabled_notinstalled_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+              .action = st_op_disabled_notinstalled,</span><br><span style="color: hsl(120, 100%, 40%);">+        },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY] = {</span><br><span style="color: hsl(120, 100%, 40%);">+             .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+                .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(NM_BTS_SM_ST_OP_DISABLED_OFFLINE) |</span><br><span style="color: hsl(120, 100%, 40%);">+                 X(NM_BTS_SM_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+           .name = "DISABLED_DEPENDENCY",</span><br><span style="color: hsl(120, 100%, 40%);">+              .action = st_op_disabled_dependency,</span><br><span style="color: hsl(120, 100%, 40%);">+  },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_SM_ST_OP_DISABLED_OFFLINE] = {</span><br><span style="color: hsl(120, 100%, 40%);">+                .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+                .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_ST_OP_ENABLED),</span><br><span style="color: hsl(120, 100%, 40%);">+           .name = "DISABLED_OFFLINE",</span><br><span style="color: hsl(120, 100%, 40%);">+         .onenter = st_op_disabled_offline_on_enter,</span><br><span style="color: hsl(120, 100%, 40%);">+           .action = st_op_disabled_offline,</span><br><span style="color: hsl(120, 100%, 40%);">+     },</span><br><span style="color: hsl(120, 100%, 40%);">+    [NM_BTS_SM_ST_OP_ENABLED] = {</span><br><span style="color: hsl(120, 100%, 40%);">+         .in_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_EV_STATE_CHG_REP),</span><br><span style="color: hsl(120, 100%, 40%);">+                .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(NM_BTS_SM_ST_OP_DISABLED_NOTINSTALLED) |</span><br><span style="color: hsl(120, 100%, 40%);">+                    X(NM_BTS_SM_ST_OP_DISABLED_DEPENDENCY) |</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(NM_BTS_SM_ST_OP_DISABLED_OFFLINE),</span><br><span style="color: hsl(120, 100%, 40%);">+          .name = "ENABLED",</span><br><span style="color: hsl(120, 100%, 40%);">+          .action = st_op_enabled,</span><br><span style="color: hsl(120, 100%, 40%);">+      },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string nm_bts_sm_fsm_event_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+   { NM_BTS_SM_EV_SW_ACT_REP, "SW_ACT_REP" },</span><br><span style="color: hsl(120, 100%, 40%);">+  { NM_BTS_SM_EV_STATE_CHG_REP, "STATE_CHG_REP" },</span><br><span style="color: hsl(120, 100%, 40%);">+    { NM_BTS_SM_EV_OPSTART_ACK, "OPSTART_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+        { NM_BTS_SM_EV_OPSTART_NACK, "OPSTART_NACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { NM_BTS_SM_EV_OML_DOWN, "OML_DOWN" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct osmo_fsm nm_bts_sm_fsm = {</span><br><span style="color: hsl(120, 100%, 40%);">+  .name = "NM_BTS_SM_OP",</span><br><span style="color: hsl(120, 100%, 40%);">+     .states = nm_bts_sm_fsm_states,</span><br><span style="color: hsl(120, 100%, 40%);">+       .num_states = ARRAY_SIZE(nm_bts_sm_fsm_states),</span><br><span style="color: hsl(120, 100%, 40%);">+       .allstate_event_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                X(NM_BTS_SM_EV_OPSTART_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+         X(NM_BTS_SM_EV_OPSTART_NACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+                X(NM_BTS_SM_EV_OML_DOWN),</span><br><span style="color: hsl(120, 100%, 40%);">+     .allstate_action = st_op_allstate,</span><br><span style="color: hsl(120, 100%, 40%);">+    .event_names = nm_bts_sm_fsm_event_names,</span><br><span style="color: hsl(120, 100%, 40%);">+     .log_subsys = DNM,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static __attribute__((constructor)) void nm_bts_sm_fsm_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(osmo_fsm_register(&nm_bts_sm_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am</span><br><span>index fd03cb3..151437e 100644</span><br><span>--- a/src/utils/Makefile.am</span><br><span>+++ b/src/utils/Makefile.am</span><br><span>@@ -55,6 +55,7 @@</span><br><span>     $(top_builddir)/src/osmo-bsc/e1_config.o \</span><br><span>   $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>@@ -125,6 +126,7 @@</span><br><span>  $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>diff --git a/tests/abis/Makefile.am b/tests/abis/Makefile.am</span><br><span>index a245b51..28c284f 100644</span><br><span>--- a/tests/abis/Makefile.am</span><br><span>+++ b/tests/abis/Makefile.am</span><br><span>@@ -31,6 +31,7 @@</span><br><span>       $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOABIS_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>diff --git a/tests/acc/Makefile.am b/tests/acc/Makefile.am</span><br><span>index 4726ddc..98362a9 100644</span><br><span>--- a/tests/acc/Makefile.am</span><br><span>+++ b/tests/acc/Makefile.am</span><br><span>@@ -31,6 +31,7 @@</span><br><span>    $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span>    $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOABIS_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c</span><br><span>index f463a2e..81b9e8d 100644</span><br><span>--- a/tests/acc/acc_test.c</span><br><span>+++ b/tests/acc/acc_test.c</span><br><span>@@ -497,6 +497,7 @@</span><br><span>      log_set_print_category_hex(osmo_stderr_target, false);</span><br><span>       log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);</span><br><span>      log_set_use_color(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_fsm_log_addr(false);</span><br><span> </span><br><span>        net = gsm_network_init(tall_bsc_ctx);</span><br><span>        if (!net) {</span><br><span>diff --git a/tests/acc/acc_test.ok b/tests/acc/acc_test.ok</span><br><span>index 866502e..6315a92 100644</span><br><span>--- a/tests/acc/acc_test.ok</span><br><span>+++ b/tests/acc/acc_test.ok</span><br><span>@@ -1,4 +1,5 @@</span><br><span> ===test_acc_mgr_no_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_no_ramp()</span><br><span> do_allowed_len_adm_loop(1)</span><br><span>@@ -105,8 +106,10 @@</span><br><span> *** Barring zero ACCs ***</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> pcu_info_update(): t2=0x00 t3=0x00, allowed: 0 1 2 3 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_no_ramp()</span><br><span> ===test_acc_mgr_manual_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_manual_ramp()</span><br><span> do_allowed_len_ramp_loop(1)</span><br><span>@@ -343,8 +346,10 @@</span><br><span> pcu_info_update(): t2=0x03 t3=0xff, allowed:</span><br><span> (bts=0) ACC: New ACC allowed subset 0x24c (active_len=4, ramp_len=4, adm_len=4, perm_len=4, rotation=off)</span><br><span> pcu_info_update(): t2=0x01 t3=0xb3, allowed: 2 3 6 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_manual_ramp()</span><br><span> ===test_acc_mgr_rotate(true, 1)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -412,8 +417,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x001 -> 0x002 (active_len=1, ramp_len=10, adm_len=1, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xfd, allowed: 1</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 1)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x200 (active_len=1, ramp_len=10, adm_len=1, perm_len=10, rotation=on)</span><br><span>@@ -478,8 +485,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x100 -> 0x200 (active_len=1, ramp_len=10, adm_len=1, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x01 t3=0xff, allowed: 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 2)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -547,8 +556,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x101 -> 0x003 (active_len=2, ramp_len=10, adm_len=2, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xfc, allowed: 0 1</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 2)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x300 (active_len=2, ramp_len=10, adm_len=2, perm_len=10, rotation=on)</span><br><span>@@ -613,8 +624,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x180 -> 0x300 (active_len=2, ramp_len=10, adm_len=2, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0xff, allowed: 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 3)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -682,8 +695,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x181 -> 0x103 (active_len=3, ramp_len=10, adm_len=3, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0xfc, allowed: 0 1 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 3)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x380 (active_len=3, ramp_len=10, adm_len=3, perm_len=10, rotation=on)</span><br><span>@@ -748,8 +763,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1c0 -> 0x380 (active_len=3, ramp_len=10, adm_len=3, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x7f, allowed: 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 4)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -817,8 +834,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1c1 -> 0x183 (active_len=4, ramp_len=10, adm_len=4, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x7c, allowed: 0 1 7 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 4)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3c0 (active_len=4, ramp_len=10, adm_len=4, perm_len=10, rotation=on)</span><br><span>@@ -883,8 +902,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1e0 -> 0x3c0 (active_len=4, ramp_len=10, adm_len=4, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x3f, allowed: 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -952,8 +973,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1e1 -> 0x1c3 (active_len=5, ramp_len=10, adm_len=5, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x3c, allowed: 0 1 6 7 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3e0 (active_len=5, ramp_len=10, adm_len=5, perm_len=10, rotation=on)</span><br><span>@@ -1018,8 +1041,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f0 -> 0x3e0 (active_len=5, ramp_len=10, adm_len=5, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x1f, allowed: 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 6)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1087,8 +1112,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f1 -> 0x1e3 (active_len=6, ramp_len=10, adm_len=6, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x1c, allowed: 0 1 5 6 7 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 6)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3f0 (active_len=6, ramp_len=10, adm_len=6, perm_len=10, rotation=on)</span><br><span>@@ -1153,8 +1180,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f8 -> 0x3f0 (active_len=6, ramp_len=10, adm_len=6, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x0f, allowed: 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 7)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1222,8 +1251,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1f9 -> 0x1f3 (active_len=7, ramp_len=10, adm_len=7, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x0c, allowed: 0 1 4 5 6 7 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 7)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3f8 (active_len=7, ramp_len=10, adm_len=7, perm_len=10, rotation=on)</span><br><span>@@ -1288,8 +1319,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fc -> 0x3f8 (active_len=7, ramp_len=10, adm_len=7, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x07, allowed: 3 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(true, 8)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1357,8 +1390,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fd -> 0x1fb (active_len=8, ramp_len=10, adm_len=8, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x02 t3=0x04, allowed: 0 1 3 4 5 6 7 8</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 8)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3fc (active_len=8, ramp_len=10, adm_len=8, perm_len=10, rotation=on)</span><br><span>@@ -1423,8 +1458,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1fe -> 0x3fc (active_len=8, ramp_len=10, adm_len=8, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x03, allowed: 2 3 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_mgr_rotate(false, 9)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_mgr_rotate()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3fe (active_len=9, ramp_len=10, adm_len=9, perm_len=10, rotation=on)</span><br><span>@@ -1489,8 +1526,10 @@</span><br><span> sys={40.000000}: select()</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x1ff -> 0x3fe (active_len=9, ramp_len=10, adm_len=9, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x00 t3=0x01, allowed: 1 2 3 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_mgr_rotate()</span><br><span> ===test_acc_ramp===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x000 (active_len=0, ramp_len=0, adm_len=10, perm_len=10, rotation=off)</span><br><span>@@ -1524,8 +1563,10 @@</span><br><span> sys={450.000000}: select()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x1ff -> 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> pcu_info_update(): t2=0x00 t3=0x00, allowed: 0 1 2 3 4 5 6 7 8 9</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp()</span><br><span> ===test_acc_ramp2===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp2()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x3ff -> 0x3f8 (active_len=7, ramp_len=10, adm_len=7, perm_len=10, rotation=on)</span><br><span>@@ -1541,8 +1582,10 @@</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x03f -> 0x07f (active_len=7, ramp_len=7, adm_len=7, perm_len=10, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0x80, allowed: 0 1 2 3 4 5 6</span><br><span> sys={15.000000}: select()</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp2()</span><br><span> ===test_acc_ramp3===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp3()</span><br><span> *** Barring some ACCs ***</span><br><span>@@ -1574,8 +1617,10 @@</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x15a -> 0x15a (active_len=5, ramp_len=9, adm_len=10, perm_len=5, rotation=off)</span><br><span> sys={45.000000}: select()</span><br><span> (bts=0) ACC: update ACC allowed active subset 0x15a -> 0x15a (active_len=5, ramp_len=10, adm_len=10, perm_len=5, rotation=off)</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp3()</span><br><span> ===test_acc_ramp_up_rotate(0, 100, 100)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1663,8 +1708,10 @@</span><br><span> sys={2750.000000}: select()</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_up_rotate(0, 20, 50)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1752,8 +1799,10 @@</span><br><span> sys={2750.000000}: select()</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_up_rotate(70, 80, 90)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_up_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1841,8 +1890,10 @@</span><br><span> sys={2750.000000}: select()</span><br><span> sys={3000.000000}: select()</span><br><span> sys={3250.000000}: select()</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_up_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(80, 90, 0, 100, 15)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -1960,8 +2011,10 @@</span><br><span> sys={7000.000000}: select(47): chan_load_avg=75</span><br><span> sys={7250.000000}: select(48): chan_load_avg=90</span><br><span> sys={7500.000000}: select(49): chan_load_avg=100</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(30, 50, 10, 100, 15)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -2103,8 +2156,10 @@</span><br><span> sys={4200.000000}: select(49): chan_load_avg=25</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x003 -> 0x006 (active_len=2, ramp_len=2, adm_len=10, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xf9, allowed: 1 2</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(50, 49, 0, 100, 10)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -2256,8 +2311,10 @@</span><br><span> sys={4200.000000}: select(49): chan_load_avg=90</span><br><span> (bts=0) ACC: rotate ACC allowed active subset 0x01c -> 0x038 (active_len=3, ramp_len=3, adm_len=10, perm_len=9, rotation=on)</span><br><span> pcu_info_update(): t2=0x03 t3=0xc7, allowed: 3 4 5</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span> ===test_acc_ramp_updown_rotate(30, 80, 30, 80, 5)===</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP{DISABLED_NOTINSTALLED}: Allocated</span><br><span> (bts=0) ACC: New ACC allowed subset 0x3ff (active_len=10, ramp_len=10, adm_len=10, perm_len=10, rotation=off)</span><br><span> BTS allocation OK in test_acc_ramp_updown_rotate()</span><br><span> *** Barring one ACC ***</span><br><span>@@ -2315,4 +2372,5 @@</span><br><span> sys={12000.000000}: select(47): chan_load_avg=65</span><br><span> sys={12250.000000}: select(48): chan_load_avg=70</span><br><span> sys={12500.000000}: select(49): chan_load_avg=75</span><br><span style="color: hsl(120, 100%, 40%);">+NM_BTS_SM_OP(bts_sm0){DISABLED_NOTINSTALLED}: Deallocated</span><br><span> BTS deallocated OK in test_acc_ramp_updown_rotate()</span><br><span>diff --git a/tests/bsc/Makefile.am b/tests/bsc/Makefile.am</span><br><span>index 468c032..0c5f47f 100644</span><br><span>--- a/tests/bsc/Makefile.am</span><br><span>+++ b/tests/bsc/Makefile.am</span><br><span>@@ -45,6 +45,7 @@</span><br><span>    $(top_builddir)/src/osmo-bsc/handover_logic.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/neighbor_ident.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOVTY_LIBS) \</span><br><span>diff --git a/tests/gsm0408/Makefile.am b/tests/gsm0408/Makefile.am</span><br><span>index 66e4072..5525670 100644</span><br><span>--- a/tests/gsm0408/Makefile.am</span><br><span>+++ b/tests/gsm0408/Makefile.am</span><br><span>@@ -34,6 +34,7 @@</span><br><span>    $(top_builddir)/src/osmo-bsc/rest_octets.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/system_information.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/neighbor_ident.o \</span><br><span style="color: hsl(120, 100%, 40%);">+       $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span>diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am</span><br><span>index 87981d9..c4b6932 100644</span><br><span>--- a/tests/handover/Makefile.am</span><br><span>+++ b/tests/handover/Makefile.am</span><br><span>@@ -80,6 +80,7 @@</span><br><span>       $(top_builddir)/src/osmo-bsc/neighbor_ident.o \</span><br><span>      $(top_builddir)/src/osmo-bsc/neighbor_ident_vty.o \</span><br><span>  $(top_builddir)/src/osmo-bsc/net_init.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(top_builddir)/src/osmo-bsc/osmo_bsc_ctrl.o \</span><br><span>       $(top_builddir)/src/osmo-bsc/osmo_bsc_lcls.o \</span><br><span>       $(top_builddir)/src/osmo-bsc/osmo_bsc_mgcp.o \</span><br><span>diff --git a/tests/nanobts_omlattr/Makefile.am b/tests/nanobts_omlattr/Makefile.am</span><br><span>index 1cdcc50..e4c9581 100644</span><br><span>--- a/tests/nanobts_omlattr/Makefile.am</span><br><span>+++ b/tests/nanobts_omlattr/Makefile.am</span><br><span>@@ -29,6 +29,7 @@</span><br><span>  $(top_builddir)/src/osmo-bsc/bts.o \</span><br><span>         $(top_builddir)/src/osmo-bsc/bts_trx.o \</span><br><span>     $(top_builddir)/src/osmo-bsc/gsm_data.o \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(top_builddir)/src/osmo-bsc/nm_bts_sm_fsm.o \</span><br><span>       $(LIBOSMOCORE_LIBS) \</span><br><span>        $(LIBOSMOGSM_LIBS) \</span><br><span>         $(LIBOSMOABIS_LIBS) \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20400">change 20400</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20400"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e </div>
<div style="display:none"> Gerrit-Change-Number: 20400 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>