<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20348">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">refactor paging: introduce bsc_paging_start()<br><br>Allow starting a paging from elsewhere than a BSSMAP Paging Request. For<br>upcoming Location Services (LCS), a BSSLAP TA Request from the SMLC may require<br>triggering a Paging.<br><br>Change-Id: Iaff91584699d163bd1963927280ff3a8ddd43073<br>---<br>M include/osmocom/bsc/paging.h<br>M src/osmo-bsc/osmo_bsc_bssap.c<br>M tests/handover/handover_test.c<br>3 files changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/20348/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h</span><br><span>index 82dea1b..1a342b8 100644</span><br><span>--- a/include/osmocom/bsc/paging.h</span><br><span>+++ b/include/osmocom/bsc/paging.h</span><br><span>@@ -88,4 +88,5 @@</span><br><span> void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc);</span><br><span> void paging_flush_network(struct gsm_network *net, struct bsc_msc_data *msc);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+int bsc_paging_start(struct bsc_paging_params *params);</span><br><span> #endif</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>index 3c00d68..ad50122 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>@@ -293,7 +293,6 @@</span><br><span>                .msc = msc,</span><br><span>          .tmsi = GSM_RESERVED_TMSI,</span><br><span>   };</span><br><span style="color: hsl(0, 100%, 40%);">-      struct bsc_paging_params *params; // (tmp cosmetic shim, dropped in subsequent patch)</span><br><span> </span><br><span>    tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l4h + 1, payload_length - 1, 0, 0);</span><br><span>         remain = payload_length - 1;</span><br><span>@@ -357,9 +356,13 @@</span><br><span>          LOG_PAGING(&paging, DMSC, LOGL_ERROR, "eMLPP IE present, but eMLPP is not handled\n");</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   rate_ctr_inc(&msc->network->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);</span><br><span style="color: hsl(120, 100%, 40%);">+    return bsc_paging_start(&paging);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    params = &paging;</span><br><span style="color: hsl(120, 100%, 40%);">+int bsc_paging_start(struct bsc_paging_params *params)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      rate_ctr_inc(&bsc_gsmnet->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      switch (params->cil.id_discr) {</span><br><span>   case CELL_IDENT_NO_CELL:</span><br><span>             page_all_bts(params);</span><br><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index ba0ec21..bdf926d 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -48,6 +48,7 @@</span><br><span> #include <osmocom/bsc/handover_fsm.h></span><br><span> #include <osmocom/bsc/bsc_msc_data.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/paging.h></span><br><span> </span><br><span> void *ctx;</span><br><span> </span><br><span>@@ -1798,6 +1799,8 @@</span><br><span> void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr) {}</span><br><span> int bsc_compl_l3(struct gsm_lchan *lchan, struct msgb *msg, uint16_t chosen_channel)</span><br><span> { return 0; }</span><br><span style="color: hsl(120, 100%, 40%);">+int bsc_paging_start(struct bsc_paging_params *params)</span><br><span style="color: hsl(120, 100%, 40%);">+{ return 0; }</span><br><span> void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg) {}</span><br><span> void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) {}</span><br><span> void bsc_cm_update(struct gsm_subscriber_connection *conn,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20348">change 20348</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20348"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaff91584699d163bd1963927280ff3a8ddd43073 </div>
<div style="display:none"> Gerrit-Change-Number: 20348 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>