<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20362">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix BSSAP_LE_Types FIELDORDER<br><br>Change-Id: I6f3d5b238912923431db36a1ba7b4973ae4e2e91<br>---<br>M library/BSSAP_LE_Types.ttcn<br>M library/BSSMAP_LE_Templates.ttcn<br>2 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/20362/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/BSSAP_LE_Types.ttcn b/library/BSSAP_LE_Types.ttcn</span><br><span>index 604fbe0..d46e3a4 100644</span><br><span>--- a/library/BSSAP_LE_Types.ttcn</span><br><span>+++ b/library/BSSAP_LE_Types.ttcn</span><br><span>@@ -195,12 +195,12 @@</span><br><span> type record BSSMAP_LE_IE_APDU {</span><br><span>       BSSMAP_LE_IEI           iei,</span><br><span>         uint16_t                len,</span><br><span style="color: hsl(0, 100%, 40%);">-    BIT1                    spare,</span><br><span>       BSSMAP_LE_ProtocolId    protocol_id,</span><br><span style="color: hsl(120, 100%, 40%);">+  BIT1                    spare,</span><br><span>       octetstring             data</span><br><span> } with {</span><br><span>     variant "PRESENCE(iei = BSSMAP_LE_IEI_APDU)"</span><br><span style="color: hsl(0, 100%, 40%);">-  variant (len) "LENGTHTO(spare,protocol_id,data)"</span><br><span style="color: hsl(120, 100%, 40%);">+    variant (len) "LENGTHTO(protocol_id,spare,data)"</span><br><span> };</span><br><span> type enumerated BSSMAP_LE_ProtocolId {</span><br><span>   BSSMAP_LE_PROT_RESERVED         ('0000000'B),</span><br><span>@@ -591,4 +591,4 @@</span><br><span> with { extension "prototype(convert) decode(RAW)" }</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-} with { encode "RAW" ; variant "FIELDORDER(msb)" }</span><br><span style="color: hsl(120, 100%, 40%);">+} with { encode "RAW" ; }</span><br><span>diff --git a/library/BSSMAP_LE_Templates.ttcn b/library/BSSMAP_LE_Templates.ttcn</span><br><span>index 70805e7..a1fcc75 100644</span><br><span>--- a/library/BSSMAP_LE_Templates.ttcn</span><br><span>+++ b/library/BSSMAP_LE_Templates.ttcn</span><br><span>@@ -262,8 +262,8 @@</span><br><span>                          bsslap_apdu := {</span><br><span>                                     iei := BSSMAP_LE_IEI_APDU,</span><br><span>                                   len := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                                       spare := '0'B,</span><br><span>                                       protocol_id := prot_id,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       spare := '0'B,</span><br><span>                                       data := data</span><br><span>                                 },</span><br><span>                           segmentation := segm</span><br><span>@@ -282,8 +282,8 @@</span><br><span>                           bsslap_apdu := {</span><br><span>                                     iei := BSSMAP_LE_IEI_APDU,</span><br><span>                                   len := ?,</span><br><span style="color: hsl(0, 100%, 40%);">-                                       spare := '0'B,</span><br><span>                                       protocol_id := prot_id,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       spare := '0'B,</span><br><span>                                       data := data</span><br><span>                                 },</span><br><span>                           segmentation := segm</span><br><span>@@ -341,8 +341,8 @@</span><br><span>   var BSSMAP_LE_IE_APDU ie := {</span><br><span>                iei := BSSMAP_LE_IEI_APDU,</span><br><span>           len := 0, // overwritten</span><br><span style="color: hsl(0, 100%, 40%);">-                spare := '0'B,</span><br><span style="color: hsl(0, 100%, 40%);">-          protocol_id := prot_id</span><br><span style="color: hsl(120, 100%, 40%);">+                protocol_id := prot_id,</span><br><span style="color: hsl(120, 100%, 40%);">+               spare := '0'B</span><br><span>        }</span><br><span>    if (istemplatekind(data, "omit")) {</span><br><span>                return omit;</span><br><span>@@ -356,15 +356,15 @@</span><br><span>         var template BSSMAP_LE_IE_APDU ie := {</span><br><span>               iei := BSSMAP_LE_IEI_APDU,</span><br><span>           len := ?,</span><br><span style="color: hsl(0, 100%, 40%);">-               spare := '0'B,</span><br><span style="color: hsl(0, 100%, 40%);">-          protocol_id := prot_id</span><br><span style="color: hsl(120, 100%, 40%);">+                protocol_id := prot_id,</span><br><span style="color: hsl(120, 100%, 40%);">+               spare := '0'B</span><br><span>        }</span><br><span>    if (istemplatekind(data, "omit")) {</span><br><span>                return omit;</span><br><span>         } else if (istemplatekind(data, "*")) {</span><br><span>            return *;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       ie.data := valueof(data);</span><br><span style="color: hsl(120, 100%, 40%);">+     ie.data := data;</span><br><span>     return ie;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20362">change 20362</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20362"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f3d5b238912923431db36a1ba7b4973ae4e2e91 </div>
<div style="display:none"> Gerrit-Change-Number: 20362 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>