<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234">View Change</a></p><p>12 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/include/osmocom/bsc/gsm_data.h">File include/osmocom/bsc/gsm_data.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/include/osmocom/bsc/gsm_data.h@12">Patch Set #9, Line 12:</a> <code style="font-family:monospace,monospace">#include <osmocom/core/sockaddr_str.h></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This include is not needed AFAICT.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c">File src/osmo-bsc/bsc_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@784">Patch Set #9, Line 784:</a> <code style="font-family:monospace,monospace"> osmo_htons(nsvc->remote.u.sin.sin_port), VTY_NEWLINE);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">osmo_sockaddr_port(&nsvc->remote) (and you can also remove the byteswap.h).</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">See the comment. "Can't use remote.port because it's only valid when family != AF_UNSPEC". But I've also added checked the port to be != 0.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c">File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@206">Patch Set #3, Line 206:</a> <code style="font-family:monospace,monospace"> if (bts->gprs.nsvc->remote.u.sa.sa_family == AF_INET6) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">switch?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@208">Patch Set #3, Line 208:</a> <code style="font-family:monospace,monospace"> osmo_store16be(IPPROTO_IPV6, &buf[0]);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Please let's use our own define here, not this define which was nothing to do. That's for IPoverIP.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@212">Patch Set #3, Line 212:</a> <code style="font-family:monospace,monospace"> memcpy(&buf[4], &bts->gprs.nsvc[0].remote.u.sin6.sin6_port, sizeof(uint16_t));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Really? memcpy for a uint16_t?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@218">Patch Set #3, Line 218:</a> <code style="font-family:monospace,monospace"> memcpy(&buf[0], &bts->gprs.nsvc[0].remote.u.sin.sin_port, sizeof(uint16_t));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/4/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c">File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/4/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@216">Patch Set #4, Line 216:</a> <code style="font-family:monospace,monospace"> buf[4] = *(((char *) &bts->gprs.nsvc[0].remote.u.sin6.sin6_port) + 0);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">@pespin: do you like it more than a memcpy?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/5/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c">File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/5/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@216">Patch Set #5, Line 216:</a> <code style="font-family:monospace,monospace"> buf[4] = *(((char *) &bts->gprs.nsvc[0].remote.u.sin6.sin6_port) + 0);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Indeed, good point, my bad then, feel free to move back to memcpy.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c">File src/osmo-bsc/pcu_sock.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c@199">Patch Set #3, Line 199:</a> <code style="font-family:monospace,monospace"> LOGP(DPCU, LOGL_ERROR, "Can not encode IPv6 NSVC!");</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">didn't fixeria already add support for it?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is PCU IF 9. See other patches in line.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c@205">Patch Set #3, Line 205:</a> <code style="font-family:monospace,monospace"> info_ind->nsvci[i] = nsvc->nsvci;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You should have 2 iter variable shere, otherwise if you "continue;" above, you end up with holes in […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's not needed. The PCUIF have 2 nsvcs and is zero initialized. So AF_UNSPEC is the default and will be ignored.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c">File src/osmo-bsc/pcu_sock.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c@196">Patch Set #9, Line 196:</a> <code style="font-family:monospace,monospace"> info_ind->remote_port[i] = osmo_ntohs(nsvc->remote.u.sin.sin_port);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">osmo_sockaddr_port()</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c@197">Patch Set #9, Line 197:</a> <code style="font-family:monospace,monospace"> info_ind->remote_ip[i] = osmo_ntohl(nsvc->remote.u.sin.sin_addr.s_addr);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">So no IPv6 support here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Correct. This is still PCUIF 9.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234">change 20234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20234"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2 </div>
<div style="display:none"> Gerrit-Change-Number: 20234 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Oct 2020 18:50:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>