<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn">File bsc/BSC_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@4496">Patch Set #1, Line 4496:</a> <code style="font-family:monospace,monospace">pri</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">doesn't really look like a LCS related change?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">it's needed in the new test TC_ho_during_lcs_loc_req where the lchan is moved to RSL1</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7537">Patch Set #1, Line 7537:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rivate function f_match_bsslap(PDU_BSSAP_LE got_bsslap_msg,<br> template (present) BSSLAP_PDU expect_bsslap)<br>{<br> var BSSLAP_PDU bsslap := dec_BSSLAP_PDU(got_bsslap_msg.pdu.bssmap.co_info.bsslap_apdu.data);<br> if (not match(bsslap, expect_bsslap)) {<br> log("EXPECTING BSSLAP: ", expect_bsslap);<br> log("GOT BSSLAP: ", bsslap);<br> setverdict(fail, "BSSLAP is not as expected");<br> mtc.stop;<br> }<br> setverdict(pass);<br>}<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">looks like 'decmatch' to me?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">ah? what's decmatch?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7555">Patch Set #1, Line 7555:</a> <code style="font-family:monospace,monospace">?</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">you can put 'decmatch expect_rx_bsslap' here instead of the '?'. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">will take a look</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7565">Patch Set #1, Line 7565:</a> <code style="font-family:monospace,monospace"> f</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I would really want to avoid such function entry/exit statemtns in any programming language. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">this is about getting log markers in the *osmo-bsc* stderr output, not the ttcn tester log.<br>osmo-bsc spams a huge amount of cruft for each test start and stop, and finding the right place to look in the logs is made a million times easier with these markers in stderr.</p><p style="white-space: pre-wrap; word-wrap: break-word;">gsmtap wouldn't help me that much because i prefer reading stderr (because wireshark is a pain to read on a non-wide screen aka laptop, and i don't always trace)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe the test name can be emitted to vty in f_start_handler() instead??<br>The "done" statement below isn't really necessary, could drop that.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373">change 20373</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id3df9439752c088cff5618d21254af42365690ca </div>
<div style="display:none"> Gerrit-Change-Number: 20373 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Oct 2020 14:22:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>