<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20304">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: Introduce MAX_LOG_SIZE for the magic number 4096<br><br>Change-Id: Ia9645098dffecd29242857de8f1aea6b9aca5918<br>---<br>M src/logging.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index 212b0b9..d60d6e4 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -56,6 +56,9 @@</span><br><span> </span><br><span> #include <osmocom/vty/logging.h>     /* for LOGGING_STR. */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* maximum length of the log string of a single log event (typically  line) */</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_LOG_SIZE        4096</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> osmo_static_assert(_LOG_CTX_COUNT <= ARRAY_SIZE(((struct log_context*)NULL)->ctx),</span><br><span>              enum_logging_ctx_items_fit_in_struct_log_context);</span><br><span> osmo_static_assert(_LOG_FLT_COUNT <= ARRAY_SIZE(((struct log_target*)NULL)->filter_data),</span><br><span>@@ -390,7 +393,7 @@</span><br><span>                   unsigned int level, const char *file, int line, int cont,</span><br><span>                    const char *format, va_list ap)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        char buf[4096];</span><br><span style="color: hsl(120, 100%, 40%);">+       char buf[MAX_LOG_SIZE];</span><br><span>      int ret, len = 0, offset = 0, rem = sizeof(buf);</span><br><span>     const char *c_subsys = NULL;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20304">change 20304</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20304"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia9645098dffecd29242857de8f1aea6b9aca5918 </div>
<div style="display:none"> Gerrit-Change-Number: 20304 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>