<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20264">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: vty: fix behavior of vtyvc_by_nsei when vtyvc isn't found<br><br>Fixes the parsing of persistent nsvcs.<br><br>Change-Id: I297409f557f17df680ac76018b4202eb99713021<br>---<br>M src/gb/gprs_ns2_vty.c<br>1 file changed, 8 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index f204ff1..ab869c3 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -138,20 +138,21 @@</span><br><span> </span><br><span> static struct ns2_vty_vc *vtyvc_by_nsei(uint16_t nsei, bool alloc_missing) {</span><br><span>    struct ns2_vty_vc *vtyvc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  llist_for_each_entry(vtyvc, &priv.vtyvc, list) {</span><br><span>                 if (vtyvc->nsei == nsei)</span><br><span>                  return vtyvc;</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (alloc_missing) {</span><br><span style="color: hsl(0, 100%, 40%);">-            vtyvc = vtyvc_alloc(nsei);</span><br><span style="color: hsl(0, 100%, 40%);">-              if (!vtyvc)</span><br><span style="color: hsl(0, 100%, 40%);">-                     return vtyvc;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!alloc_missing)</span><br><span style="color: hsl(120, 100%, 40%);">+           return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                vtyvc->nsei = nsei;</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(120, 100%, 40%);">+     vtyvc = vtyvc_alloc(nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!vtyvc)</span><br><span style="color: hsl(120, 100%, 40%);">+           return vtyvc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  vtyvc->nsei = nsei;</span><br><span style="color: hsl(120, 100%, 40%);">+        return vtyvc;</span><br><span> }</span><br><span> </span><br><span> static int config_write_ns(struct vty *vty)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20264">change 20264</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20264"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I297409f557f17df680ac76018b4202eb99713021 </div>
<div style="display:none"> Gerrit-Change-Number: 20264 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>