<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20262">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb/gprs_bssgb: check if talloc failed on btsctx->fc<br><br>Change-Id: I1cfccc2cb696d9e95f590b99559d0a987031adfe<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 12 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index 9c119fb..e5b4380 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -146,17 +146,25 @@</span><br><span>       ctx->nsei = nsei;</span><br><span>         /* FIXME: BVCI is not unique, only BVCI+NSEI ?!? */</span><br><span>  ctx->ctrg = rate_ctr_group_alloc(ctx, &bssgp_ctrg_desc, bvci);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (!ctx->ctrg) {</span><br><span style="color: hsl(0, 100%, 40%);">-            talloc_free(ctx);</span><br><span style="color: hsl(0, 100%, 40%);">-               return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!ctx->ctrg)</span><br><span style="color: hsl(120, 100%, 40%);">+            goto err_ctrg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     ctx->fc = talloc_zero(ctx, struct bssgp_flow_control);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!ctx->fc)</span><br><span style="color: hsl(120, 100%, 40%);">+              goto err_fc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       /* cofigure for 2Mbit, 30 packets in queue */</span><br><span>        bssgp_fc_init(ctx->fc, 100000, 2*1024*1024/8, 30, &_bssgp_tx_dl_ud);</span><br><span> </span><br><span>      llist_add(&ctx->list, &bssgp_bvc_ctxts);</span><br><span> </span><br><span>      return ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+err_fc:</span><br><span style="color: hsl(120, 100%, 40%);">+        rate_ctr_group_free(ctx->ctrg);</span><br><span style="color: hsl(120, 100%, 40%);">+err_ctrg:</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+     return NULL;</span><br><span> }</span><br><span> </span><br><span> void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20262">change 20262</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20262"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1cfccc2cb696d9e95f590b99559d0a987031adfe </div>
<div style="display:none"> Gerrit-Change-Number: 20262 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>