<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/20277">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CC: fix sanity expectations for call establishment<br><br>Recent 'add full SDP codec information to the MNCC...' patch has added a strict<br>CC state sanity check, which is too strict:<br><br>In tests with 200 concurrent calls, situations came up where the MNCC is faster<br>than the Abis in establishing a call. If that happens, the CC state machine is<br>already in GSM_CSTATE_ACTIVE when the RR channel assignment completes.<br><br>Also allow GSM_CSTATE_ACTIVE state for accepting an Assignment Complete.<br><br>Change-Id: I0e0767ec10232615bbf063181fc7f8738ef94f28<br>---<br>M src/libmsc/gsm_04_08_cc.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/77/20277/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 73b7c37..a1c0519 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -1900,6 +1900,10 @@</span><br><span>              /* MT call */</span><br><span>                break;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    case GSM_CSTATE_ACTIVE:</span><br><span style="color: hsl(120, 100%, 40%);">+               /* already active */</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     default:</span><br><span>             LOG_TRANS(trans, LOGL_ERROR, "Assignment done in unexpected CC state: %d\n", trans->cc.state);</span><br><span>          return -EINVAL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/20277">change 20277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/20277"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0e0767ec10232615bbf063181fc7f8738ef94f28 </div>
<div style="display:none"> Gerrit-Change-Number: 20277 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>