<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20265">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: remove bssgp specific msgb->cb parts<br><br>There shouldn't be any knowledge of the upper layer in the NS layer.<br>The PCU / SGSN / gbproxy have to add the pointer when parsing the primitives.<br><br>Change-Id: Id7edb8feb96436ba170383fc62d43ceb16955d53<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/20265/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index 33a0328..7b07a49 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -469,9 +469,9 @@</span><br><span>   /* TODO: nsh->data[0] -> C/R only valid in IP SNS */</span><br><span>   bvci = nsh->data[1] << 8 | nsh->data[2];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        msgb_bssgph(msg) = &nsh->data[3];</span><br><span style="color: hsl(0, 100%, 40%);">-        msgb_bvci(msg) = nsp.bvci = bvci;</span><br><span style="color: hsl(0, 100%, 40%);">-       msgb_nsei(msg) = nsp.nsei = priv->nsvc->nse->nsei;</span><br><span style="color: hsl(120, 100%, 40%);">+   msg->l3h = &nsh->data[3];</span><br><span style="color: hsl(120, 100%, 40%);">+   nsp.bvci = bvci;</span><br><span style="color: hsl(120, 100%, 40%);">+      nsp.nsei = priv->nsvc->nse->nsei;</span><br><span> </span><br><span>       if (nsh->data[0])</span><br><span>                 nsp.u.unitdata.change = NS_ENDPOINT_REQUEST_CHANGE;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20265">change 20265</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20265"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id7edb8feb96436ba170383fc62d43ceb16955d53 </div>
<div style="display:none"> Gerrit-Change-Number: 20265 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>