<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20251">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Add 'show bts pdch' command<br><br>This allows to see which channels have been enabled according to PCU.<br><br>Change-Id: If72e67ba80aab4e0c68408e6996d74d2ff70c322<br>---<br>M src/pcu_vty.c<br>M src/pcu_vty_functions.cpp<br>M src/pcu_vty_functions.h<br>3 files changed, 38 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_vty.c b/src/pcu_vty.c</span><br><span>index 99c92b7..0756136 100644</span><br><span>--- a/src/pcu_vty.c</span><br><span>+++ b/src/pcu_vty.c</span><br><span>@@ -828,6 +828,14 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(show_bts_pdch,</span><br><span style="color: hsl(120, 100%, 40%);">+ show_bts_pdch_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "show bts pdch",</span><br><span style="color: hsl(120, 100%, 40%);">+ SHOW_STR "BTS related functionality\nPDCH timeslots\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return pcu_vty_show_bts_pdch(vty, bts_main_data());</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #define IDLE_TIME_STR "keep an idle DL TBF alive for the time given\n"</span><br><span> DEFUN_DEPRECATED(cfg_pcu_dl_tbf_idle_time,</span><br><span> cfg_pcu_dl_tbf_idle_time_cmd,</span><br><span>@@ -1273,6 +1281,7 @@</span><br><span> install_element(PCU_NODE, &cfg_pcu_timer_cmd);</span><br><span> </span><br><span> install_element_ve(&show_bts_stats_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element_ve(&show_bts_pdch_cmd);</span><br><span> install_element_ve(&show_tbf_cmd);</span><br><span> install_element_ve(&show_ms_all_cmd);</span><br><span> install_element_ve(&show_ms_tlli_cmd);</span><br><span>diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp</span><br><span>index 3e9973c..33a4637 100644</span><br><span>--- a/src/pcu_vty_functions.cpp</span><br><span>+++ b/src/pcu_vty_functions.cpp</span><br><span>@@ -239,3 +239,31 @@</span><br><span> </span><br><span> return show_ms(vty, ms);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int pcu_vty_show_bts_pdch(struct vty *vty, const struct gprs_rlcmac_bts *bts_data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int trx_nr, ts_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "BTS (%s)%s", bts_data->active ? "active" : "disabled", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (trx_nr = 0; trx_nr < ARRAY_SIZE(bts_data->trx); trx_nr++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct gprs_rlcmac_trx *trx = &bts_data->trx[trx_nr];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (ts_nr = 0; ts_nr < ARRAY_SIZE(trx->pdch); ts_nr++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx->pdch[ts_nr].is_enabled())</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ts_nr == ARRAY_SIZE(trx->pdch))</span><br><span style="color: hsl(120, 100%, 40%);">+ continue; /* no pdch active, skip */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " TRX%u%s", trx->trx_no, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (ts_nr = 0; ts_nr < ARRAY_SIZE(trx->pdch); ts_nr++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct gprs_rlcmac_pdch *pdch = &trx->pdch[ts_nr];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " TS%u: PDCH %s, %u UL TBFs, %u DL TBFs%s", pdch->ts_no,</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch->is_enabled() ? "enabled" : "disabled",</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch->num_tbfs(GPRS_RLCMAC_DL_TBF),</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch->num_tbfs(GPRS_RLCMAC_UL_TBF), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/pcu_vty_functions.h b/src/pcu_vty_functions.h</span><br><span>index 6fbc366..4528fb2 100644</span><br><span>--- a/src/pcu_vty_functions.h</span><br><span>+++ b/src/pcu_vty_functions.h</span><br><span>@@ -33,7 +33,7 @@</span><br><span> uint32_t tlli);</span><br><span> int pcu_vty_show_ms_by_imsi(struct vty *vty, struct gprs_rlcmac_bts *bts_data,</span><br><span> const char *imsi);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+int pcu_vty_show_bts_pdch(struct vty *vty, const struct gprs_rlcmac_bts *bts_data);</span><br><span> #ifdef __cplusplus</span><br><span> }</span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20251">change 20251</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20251"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If72e67ba80aab4e0c68408e6996d74d2ff70c322 </div>
<div style="display:none"> Gerrit-Change-Number: 20251 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>