<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20230">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_strlcpy: Avoid calling memcpy with size=0<br><br>Change-Id: Ic84af86d33c8a20f06036b13d0a10cf312582f0d<br>---<br>M src/utils.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/utils.c b/src/utils.c</span><br><span>index 3c4a8c9..168f85f 100644</span><br><span>--- a/src/utils.c</span><br><span>+++ b/src/utils.c</span><br><span>@@ -545,7 +545,7 @@</span><br><span> </span><br><span> /*! Generic big-endian encoding of big endian number up to 64bit</span><br><span>  *  \param[in] value unsigned integer value to be stored</span><br><span style="color: hsl(0, 100%, 40%);">- *  \param[in] data_len number of octets </span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[in] data_len number of octets</span><br><span>  *  \returns static buffer containing big-endian stored value</span><br><span>  *</span><br><span>  * This is like osmo_store64be_ext, except that this returns a static buffer of</span><br><span>@@ -577,7 +577,7 @@</span><br><span> </span><br><span>       if (siz) {</span><br><span>           size_t len = (ret >= siz) ? siz - 1 : ret;</span><br><span style="color: hsl(0, 100%, 40%);">-           if (src)</span><br><span style="color: hsl(120, 100%, 40%);">+              if (len)</span><br><span>                     memcpy(dst, src, len);</span><br><span>               dst[len] = '\0';</span><br><span>     }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20230">change 20230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic84af86d33c8a20f06036b13d0a10cf312582f0d </div>
<div style="display:none"> Gerrit-Change-Number: 20230 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>