<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/20195">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use generic function hexstr_to_Nbytearr to convert hex string to 3/5 Bytes array<br><br>Change-Id: I1165e4928d063667f0b4dfc3437c9278e7ec7450<br>---<br>M pySim/utils.py<br>M pySim/utils_test.py<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/utils.py b/pySim/utils.py</span><br><span>index e5434a5..43e4c53 100644</span><br><span>--- a/pySim/utils.py</span><br><span>+++ b/pySim/utils.py</span><br><span>@@ -180,7 +180,7 @@</span><br><span> </span><br><span> def format_xplmn_w_act(hexstr):</span><br><span>  s = ""</span><br><span style="color: hsl(0, 100%, 40%);">-        for rec_data in hexstr_to_fivebytearr(hexstr):</span><br><span style="color: hsl(120, 100%, 40%);">+        for rec_data in hexstr_to_Nbytearr(hexstr, 5):</span><br><span>               rec_info = dec_xplmn_w_act(rec_data)</span><br><span>                 if rec_info['mcc'] == 0xFFF and rec_info['mnc'] == 0xFFF:</span><br><span>                    rec_str = "unused"</span><br><span>@@ -229,7 +229,7 @@</span><br><span> </span><br><span> def format_xplmn(hexstr):</span><br><span>  s = ""</span><br><span style="color: hsl(0, 100%, 40%);">-        for rec_data in hexstr_to_threebytearr(hexstr):</span><br><span style="color: hsl(120, 100%, 40%);">+       for rec_data in hexstr_to_Nbytearr(hexstr, 3):</span><br><span>               rec_info = dec_xplmn(rec_data)</span><br><span>               if rec_info['mcc'] == 0xFFF and rec_info['mnc'] == 0xFFF:</span><br><span>                    rec_str = "unused"</span><br><span>diff --git a/pySim/utils_test.py b/pySim/utils_test.py</span><br><span>index ff028da..8db04bd 100644</span><br><span>--- a/pySim/utils_test.py</span><br><span>+++ b/pySim/utils_test.py</span><br><span>@@ -12,7 +12,7 @@</span><br><span>                    "ffffff0002",</span><br><span>                      "ffffff0001",</span><br><span>              ]</span><br><span style="color: hsl(0, 100%, 40%);">-               self.assertEqual(utils.hexstr_to_fivebytearr(input_str), expected)</span><br><span style="color: hsl(120, 100%, 40%);">+            self.assertEqual(utils.hexstr_to_Nbytearr(input_str, 5), expected)</span><br><span> </span><br><span>       def testDecMCCfromPLMN(self):</span><br><span>                self.assertEqual(utils.dec_mcc_from_plmn("92f501"), 295)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/20195">change 20195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/20195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1165e4928d063667f0b4dfc3437c9278e7ec7450 </div>
<div style="display:none"> Gerrit-Change-Number: 20195 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>