<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: print program specific attributes in the XML reference<br><br>Change-Id: I1f35368ba9178e1454f2e3ddfcad9d96576143ef<br>Related: SYS#4937<br>---<br>M src/vty/command.c<br>1 file changed, 26 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 722b3e0..bad2688 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -628,11 +628,36 @@</span><br><span> static int vty_dump_element(struct cmd_element *cmd, print_func_t print_func, void *data, const char *newline)</span><br><span> {</span><br><span>   char *xml_string = xml_escape(cmd->string);</span><br><span style="color: hsl(120, 100%, 40%);">+        unsigned int i;</span><br><span> </span><br><span>  print_func(data, "    <command id='%s'>%s", xml_string, newline);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Print application specific attributes and their description */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (cmd->usrattr != 0x00) { /* ... if at least one flag is set */</span><br><span style="color: hsl(120, 100%, 40%);">+          print_func(data, "      <attributes scope='application'>%s", newline);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+              for (i = 0; i < ARRAY_SIZE(host.app_info->usr_attr_desc); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        char *xml_att_desc;</span><br><span style="color: hsl(120, 100%, 40%);">+                   char flag;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* Skip attribute if *not* set */</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (~cmd->usrattr & (1 << i))</span><br><span style="color: hsl(120, 100%, 40%);">+                            continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   xml_att_desc = xml_escape(host.app_info->usr_attr_desc[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+                        print_func(data, "        <attribute doc='%s'", xml_att_desc);</span><br><span style="color: hsl(120, 100%, 40%);">+                   talloc_free(xml_att_desc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                  if ((flag = host.app_info->usr_attr_letters[i]) != '\0')</span><br><span style="color: hsl(120, 100%, 40%);">+                           print_func(data, " flag='%c'", flag);</span><br><span style="color: hsl(120, 100%, 40%);">+                       print_func(data, " />%s", newline);</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           print_func(data, "      </attributes>%s", newline);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  print_func(data, "      <params>%s", newline);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      int i;</span><br><span>       for (i = 0; i < vector_count(cmd->strvec); ++i) {</span><br><span>              vector descvec = vector_slot(cmd->strvec, i);</span><br><span>             int j;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19668">change 19668</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19668"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f35368ba9178e1454f2e3ddfcad9d96576143ef </div>
<div style="display:none"> Gerrit-Change-Number: 19668 </div>
<div style="display:none"> Gerrit-PatchSet: 13 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>