<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20194">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gmm: on invalid RA id reject the MS with an implicit detach<br><br>As long the SGSN doesn't support PS handover treat unknown RA as invalid<br>and do an implicit detach.<br><br>Fixes ttcn3 crash when an RAU happen within an Attach Request<br><br>Change-Id: I6a0b335d51f58c26349f7e0a62b2107d7d351d07<br>---<br>M src/sgsn/gprs_gmm.c<br>1 file changed, 20 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c</span><br><span>index 182276c..86545f8 100644</span><br><span>--- a/src/sgsn/gprs_gmm.c</span><br><span>+++ b/src/sgsn/gprs_gmm.c</span><br><span>@@ -1663,16 +1663,26 @@</span><br><span> } else if (!gprs_ra_id_equals(&mmctx->ra, &old_ra_id) ||</span><br><span> mmctx->gmm_fsm->state == ST_GMM_DEREGISTERED)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- /* We cannot use the mmctx */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGMMCTXP(LOGL_INFO, mmctx,</span><br><span style="color: hsl(0, 100%, 40%);">- "The MM context cannot be used, RA: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_rai_name(&mmctx->ra));</span><br><span style="color: hsl(0, 100%, 40%);">- /* mmctx is set to NULL and gprs_llgmm_unassign(llme) will be</span><br><span style="color: hsl(0, 100%, 40%);">- called below, let's make sure we don't keep dangling llme</span><br><span style="color: hsl(0, 100%, 40%);">- pointers in mmctx (OS#3957, OS#4245). */</span><br><span style="color: hsl(0, 100%, 40%);">- if (mmctx->ran_type == MM_CTX_T_GERAN_Gb)</span><br><span style="color: hsl(0, 100%, 40%);">- mmctx->gb.llme = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- mmctx = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We've received either a RAU for a MS which isn't registered</span><br><span style="color: hsl(120, 100%, 40%);">+ * or a RAU with an unknown RA ID. As long the SGSN doesn't support</span><br><span style="color: hsl(120, 100%, 40%);">+ * PS handover we treat this as invalid RAU */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_ra_id new_ra_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ char new_ra[32];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bssgp_parse_cell_id(&new_ra_id, msgb_bcid(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_rai_name_buf(new_ra, sizeof(new_ra), &new_ra_id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (mmctx->gmm_fsm->state == ST_GMM_DEREGISTERED)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGMMCTXP(LOGL_INFO, mmctx,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Rejecting RAU - GMM state is deregistered. Old RA: %s New RA: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_rai_name(&old_ra_id), new_ra);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGMMCTXP(LOGL_INFO, mmctx,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Rejecting RAU - Old RA doesn't match MM. Old RA: %s New RA: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_rai_name(&old_ra_id), new_ra);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ reject_cause = GMM_CAUSE_IMPL_DETACHED;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto rejected;</span><br><span> }</span><br><span> </span><br><span> if (!mmctx) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20194">change 20194</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/20194"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6a0b335d51f58c26349f7e0a62b2107d7d351d07 </div>
<div style="display:none"> Gerrit-Change-Number: 20194 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>