<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20197">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess.h: Add more enum values and 'official' names<br><br>Originally we only learned about the protocol from looking at hexdumps<br>without any specification or the like.<br><br>Due to a GPL request to ip.acecss, we actually do have an 'official'<br>resource: The packet-ipa.c from their wireshark-1.0.6ipa27.tar.gz<br><br>Let's use its contents to complete our definitions here.<br><br>Change-Id: Ic1f2b32c72d162f31b422293d2a361d528443f01<br>---<br>M include/osmocom/gsm/protocol/ipaccess.h<br>1 file changed, 23 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/ipaccess.h b/include/osmocom/gsm/protocol/ipaccess.h</span><br><span>index 80413d1..4f1d0b1 100644</span><br><span>--- a/include/osmocom/gsm/protocol/ipaccess.h</span><br><span>+++ b/include/osmocom/gsm/protocol/ipaccess.h</span><br><span>@@ -42,26 +42,35 @@</span><br><span> };</span><br><span> </span><br><span> enum ipaccess_msgtype {</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_MSGT_PING = 0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_MSGT_PONG = 0x01,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_MSGT_ID_GET = 0x04,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_MSGT_ID_RESP = 0x05,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_MSGT_ID_ACK = 0x06,</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_PING = 0x00, /* Heartbeet */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_PONG = 0x01, /* Heartbeat Ack */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_ID_GET = 0x04, /* Identity Request */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_ID_RESP = 0x05, /* Identity */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_ID_ACK = 0x06, /* Identity Ack */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_ID_NACK = 0x07, /* Identity Nack */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_PROXY = 0x08, /* Proxy */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_PROXY_ACK = 0x09, /* Proxy Ack */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_PROXY_NACK = 0x0a, /* Proxy Nack */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_MSGT_SSL_INFO = 0x0b, /* SSL Info */</span><br><span> </span><br><span> /* OpenBSC extension */</span><br><span> IPAC_MSGT_SCCP_OLD = 0xff,</span><br><span> };</span><br><span> </span><br><span> enum ipaccess_id_tags {</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_SERNR = 0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_UNITNAME = 0x01,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_LOCATION1 = 0x02,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_LOCATION2 = 0x03,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_EQUIPVERS = 0x04,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_SWVERSION = 0x05,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_IPADDR = 0x06,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_MACADDR = 0x07,</span><br><span style="color: hsl(0, 100%, 40%);">- IPAC_IDTAG_UNIT = 0x08,</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_SERNR = 0x00, /* Unit Serial Number */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_UNITNAME = 0x01, /* Unit Name */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_LOCATION1 = 0x02, /* Unit Location */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_LOCATION2 = 0x03, /* Unit Type */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_EQUIPVERS = 0x04, /* Hardware Version */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_SWVERSION = 0x05, /* Software Version */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_IPADDR = 0x06, /* IP Address */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_MACADDR = 0x07, /* Ethernet Address */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_UNIT = 0x08, /* Unit ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_USERNAME = 0x09, /* User Name */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_PASSWORD = 0x0a, /* Password */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTAG_ACCESS_CLASS = 0x0b, /* Access Class */</span><br><span style="color: hsl(120, 100%, 40%);">+ IPAC_IDTG_APP_PROTO_VER = 0x0c, /* Application Protocol Version */</span><br><span> };</span><br><span> </span><br><span> /*</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20197">change 20197</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20197"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1f2b32c72d162f31b422293d2a361d528443f01 </div>
<div style="display:none"> Gerrit-Change-Number: 20197 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>