<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/20074">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/ctl.c: Log NOTICE messages whenever client send unexpected requests<br><br>Change-Id: Icd47de13ab84b89ce5fb21c24713bae760611d32<br>---<br>M src/ctl.c<br>1 file changed, 16 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ctl.c b/src/ctl.c</span><br><span>index fee96f8..8da21fd 100644</span><br><span>--- a/src/ctl.c</span><br><span>+++ b/src/ctl.c</span><br><span>@@ -360,16 +360,22 @@</span><br><span> </span><br><span>    /* Process query and find timeslot */</span><br><span>        intf = e1d_find_intf(e1d, hdr->intf);</span><br><span style="color: hsl(0, 100%, 40%);">-        if (!intf)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!intf) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DE1D, LOGL_NOTICE, "Client request for non-existant Interface %u\n", hdr->intf);</span><br><span>           return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        line = e1_intf_find_line(intf, hdr->line);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (!line)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!line) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPIF(intf, DE1D, LOGL_NOTICE, "Client request for non-existant line %u\n", hdr->line);</span><br><span>                return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        ts = _e1d_get_ts(line, hdr->ts);</span><br><span style="color: hsl(0, 100%, 40%);">-     if (!ts)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!ts) {</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGPLI(line, DE1D, LOGL_NOTICE, "Client request for non-existant ts %u\n", hdr->ts);</span><br><span>            return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        /* Select mode */</span><br><span>    switch (cfg->mode) {</span><br><span>@@ -380,19 +386,24 @@</span><br><span>              mode = E1_TS_MODE_HDLCFCS;</span><br><span>           break;</span><br><span>       default:</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPTS(ts, DE1D, LOGL_NOTICE, "Client request for unknown mode %u\n", cfg->mode);</span><br><span>               return 0;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (cfg->read_bufsize == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (cfg->read_bufsize == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPTS(ts, DE1D, LOGL_NOTICE, "Client request for invalid bufsize %u\n", cfg->read_bufsize);</span><br><span>            return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        /* If already open, close previous */</span><br><span>        e1_ts_stop(ts);</span><br><span> </span><br><span>  /* Init */</span><br><span>   ret = _e1d_ts_start(ts, mode, cfg->read_bufsize);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (ret < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (ret < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGPTS(ts, DE1D, LOGL_ERROR, "Unable to start timeslot: %d\n", ret);</span><br><span>               return ret;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> </span><br><span>        *rfd = ret;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/20074">change 20074</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/20074"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd47de13ab84b89ce5fb21c24713bae760611d32 </div>
<div style="display:none"> Gerrit-Change-Number: 20074 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Assignee: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>