<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20061">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Validate RTP addr+port passed from MNCC to MGCP MDCX<br><br>Change-Id: I0b53643ed3a8f8550b2ea6e8832068d603a676e1<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>1 file changed, 21 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/20061/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index 9218c76..6ea4f86 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -1022,14 +1022,28 @@</span><br><span> </span><br><span>              /* MDCX setting up the CN side remote RTP address received from MNCC CONNECT */</span><br><span>              [] MGCP.receive(tr_MDCX) -> value mgcp_cmd {</span><br><span style="color: hsl(120, 100%, 40%);">+                       var SDP_Message sdp;</span><br><span>                         log("f_mt_call_complete 9");</span><br><span style="color: hsl(0, 100%, 40%);">-                  var SDP_Message sdp := valueof(ts_SDP(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_ip,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                         hex2str(cpars.mgcp_call_id), "42",</span><br><span style="color: hsl(0, 100%, 40%);">-                                                            cpars.mgw_conn_2.mgw_rtp_port,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                          { int2str(cpars.rtp_payload_type) },</span><br><span style="color: hsl(0, 100%, 40%);">-                                                            { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                                                 cpars.rtp_sdp_format)),</span><br><span style="color: hsl(0, 100%, 40%);">-                                                           valueof(ts_SDP_ptime(20)) }));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (isvalue(mgcp_cmd.sdp)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                          sdp := mgcp_cmd.sdp;</span><br><span style="color: hsl(120, 100%, 40%);">+                          if (sdp.media_list[0].media_field.ports.port_number != cpars.mncc_rtp_port) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                 setverdict(fail, "Wrong MDCX Connection port received, expected ", cpars.mncc_rtp_port, " and received ", sdp.media_list[0].media_field.ports.port_number)</span><br><span style="color: hsl(120, 100%, 40%);">+                                        mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+                             }</span><br><span style="color: hsl(120, 100%, 40%);">+                             if (sdp.connection.conn_addr.addr != cpars.mncc_rtp_ip) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                     setverdict(fail, "Wrong MDCX Connection address received, expected ", cpars.mncc_rtp_ip, " and received ", sdp.connection.conn_addr.addr)</span><br><span style="color: hsl(120, 100%, 40%);">+                                 mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+                             }</span><br><span style="color: hsl(120, 100%, 40%);">+                     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   sdp := valueof(ts_SDP(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_ip,</span><br><span style="color: hsl(120, 100%, 40%);">+                                               hex2str(cpars.mgcp_call_id), "42",</span><br><span style="color: hsl(120, 100%, 40%);">+                                          cpars.mgw_conn_2.mgw_rtp_port,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                { int2str(cpars.rtp_payload_type) },</span><br><span style="color: hsl(120, 100%, 40%);">+                                          { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                                       cpars.rtp_sdp_format)),</span><br><span style="color: hsl(120, 100%, 40%);">+                                                 valueof(ts_SDP_ptime(20)) }));</span><br><span>                     MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_2.mgcp_connection_id, sdp));</span><br><span>                    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20061">change 20061</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20061"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b53643ed3a8f8550b2ea6e8832068d603a676e1 </div>
<div style="display:none"> Gerrit-Change-Number: 20061 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>