<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20060">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: fix gen_freq_params(): do not check pdch twice<br><br>This is a left-over from an earlier version of [1] that makes<br>Coverity think that there can be NULL pointer dereference,<br>even despite we assert(pdch != NULL).<br><br>[1] I8adc0cdb1b05a87b4df5d4bc196f6d381283a06f<br><br>Change-Id: I3490c38e0c1186dfd2fae63526a05c694547cebb<br>Fixes: CID#214230<br>---<br>M src/encoding.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/20060/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index ecf40de..d581fe9 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -565,7 +565,7 @@</span><br><span>       freq_params->TSC = pdch->tsc;</span><br><span> </span><br><span>      /* If frequency hopping is not in use, encode a single ARFCN */</span><br><span style="color: hsl(0, 100%, 40%);">- if (pdch == NULL || !pdch->fh.enabled) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!pdch->fh.enabled) {</span><br><span>          freq_params->UnionType = 0x00;</span><br><span>            freq_params->u.ARFCN = tbf->trx->arfcn;</span><br><span>             return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20060">change 20060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3490c38e0c1186dfd2fae63526a05c694547cebb </div>
<div style="display:none"> Gerrit-Change-Number: 20060 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>