<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056/1/library/MNCC_EncDec.cc">File library/MNCC_EncDec.cc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056/1/library/MNCC_EncDec.cc@195">Patch Set #1, Line 195:</a> <code style="font-family:monospace,monospace">                 memcpy(((struct sockaddr_in6*)&rtp.addr)->sin6_addr, in.u().rtp().ip().data(),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I still need to figure out how to get a memory buffer point out of an octetstring here, from ip().</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056/1/library/MNCC_Types.ttcn">File library/MNCC_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056/1/library/MNCC_Types.ttcn@377">Patch Set #1, Line 377:</a> <code style="font-family:monospace,monospace">    octetstring     ip, //TODO: define size of octetstring based on is_ipv6 using CROSSTAGS?</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">something like: if is_ipv6 LERNGTHOF(ip = 16), if not is_ipv6 LENGTHOF(ip = 4).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056">change 20056</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20056"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5448ff931ec33f24f4837a51376f1703fe97683b </div>
<div style="display:none"> Gerrit-Change-Number: 20056 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Sep 2020 19:00:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>