<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Introduce tests to verify BSSAP and MGCP handling with IPv6<br><br>It tests IPv6 Transport Address are passed correctly through BSSAP, and<br>forwards handles them correctly as an MGCP client too.<br><br>Change-Id: Id616926dd4a9febc4268eea2ee1e377b2d22753a<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>M msc/MSC_Tests.ttcn<br>2 files changed, 91 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index b24cb8d..24a56b2 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -108,6 +108,7 @@</span><br><span> boolean use_umts_aka,</span><br><span> boolean ran_is_geran,</span><br><span> boolean use_osmux,</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean use_ipv6,</span><br><span> boolean verify_cell_id</span><br><span> };</span><br><span> </span><br><span>@@ -932,7 +933,7 @@</span><br><span> </span><br><span> if (g_pars.ran_is_geran) {</span><br><span> var template BSSMAP_IE_AoIP_TransportLayerAddress tla_ass :=</span><br><span style="color: hsl(0, 100%, 40%);">- tr_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.mgw_conn_1.mgw_rtp_ip), ?);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tr_BSSMAP_IE_AoIP_TLA(cpars.mgw_conn_1.mgw_rtp_ip, ?);</span><br><span> </span><br><span> interleave {</span><br><span> /* Second MGCP CRCX (this time for MSS/CN side) */</span><br><span>@@ -954,8 +955,7 @@</span><br><span> var BSSMAP_IE_SpeechCodec codec;</span><br><span> var BSSMAP_IE_Osmo_OsmuxCID osmuxCID;</span><br><span> log("f_mt_call_complete 6");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- tla := valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip), cpars.bss_rtp_port));</span><br><span style="color: hsl(120, 100%, 40%);">+ tla := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port);</span><br><span> codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));</span><br><span> </span><br><span> if (cpars.use_osmux) {</span><br><span>@@ -1325,7 +1325,7 @@</span><br><span> }</span><br><span> </span><br><span> var template BSSMAP_IE_AoIP_TransportLayerAddress tla_ass :=</span><br><span style="color: hsl(0, 100%, 40%);">- tr_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.mgw_conn_1.mgw_rtp_ip), ?);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tr_BSSMAP_IE_AoIP_TLA(cpars.mgw_conn_1.mgw_rtp_ip, ?);</span><br><span> </span><br><span> var default mdcx := activate(as_optional_mgcp_mdcx(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_port));</span><br><span> var boolean got_mncc_setup_compl_ind := false;</span><br><span>@@ -1378,7 +1378,7 @@</span><br><span> mtc.stop;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- tla := valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip), cpars.bss_rtp_port));</span><br><span style="color: hsl(120, 100%, 40%);">+ tla := valueof(f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port));</span><br><span> codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));</span><br><span> if (cpars.use_osmux) {</span><br><span> if (not ispresent(bssap.pdu.bssmap.assignmentRequest.osmuxCID)) {</span><br><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 2a9b23a..6cb852a 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -408,6 +408,7 @@</span><br><span> use_umts_aka := false,</span><br><span> ran_is_geran := ran_is_geran,</span><br><span> use_osmux := use_osmux,</span><br><span style="color: hsl(120, 100%, 40%);">+ use_ipv6 := false,</span><br><span> verify_cell_id := mp_enable_cell_id_test and verify_cell_id</span><br><span> };</span><br><span> if (not ran_is_geran) {</span><br><span>@@ -767,6 +768,22 @@</span><br><span> vc_conn := f_start_handler(refers(f_tc_lu_and_mo_call), 7);</span><br><span> vc_conn.done;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_lu_and_mo_call_ipv6(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ var CallParameters cpars := valueof(t_CallParams);</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_1.mgw_rtp_ip := "::1";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_2.mgw_rtp_ip := "::2";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.bss_rtp_ip := "::3";</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_call(cpars);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lu_and_mo_call_ipv6() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_lu_and_mo_call_ipv6), 7);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* Verify T(iar) triggers and releases the channel */</span><br><span> friend function f_lu_and_mo_call_sccp_tiar_timeout(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span>@@ -1960,6 +1977,24 @@</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* LU followed by MT call (including paging) */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_lu_and_mt_call_ipv6(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ var CallParameters cpars := valueof(t_CallParams('12345'H, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_1.mgw_rtp_ip := "::1";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_2.mgw_rtp_ip := "::2";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.bss_rtp_ip := "::3";</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_call(cpars);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lu_and_mt_call_ipv6() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_lu_and_mt_call_ipv6), 39);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* MT call while already Paging */</span><br><span> friend function f_tc_lu_and_mt_call_already_paging(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span> var CallParameters cpars := valueof(t_CallParams('123456'H, 0));</span><br><span>@@ -5492,7 +5527,14 @@</span><br><span> }</span><br><span> </span><br><span> private function f_tc_ho_inter_bsc0(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">- var CallParameters cpars := valueof(t_CallParams('12345'H, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ var CallParameters cpars;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars := valueof(t_CallParams('12345'H, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pars.use_ipv6) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_1.mgw_rtp_ip := "::1";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_2.mgw_rtp_ip := "::2";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.bss_rtp_ip := "::3";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> f_init_handler(pars);</span><br><span> </span><br><span>@@ -5547,7 +5589,8 @@</span><br><span> /* new BSS composes a RR Handover Command */</span><br><span> var PDU_ML3_NW_MS rr_ho_cmd := valueof(ts_RR_HandoverCommand);</span><br><span> var octetstring rr_ho_cmd_enc := enc_PDU_ML3_NW_MS(rr_ho_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">- var BSSMAP_IE_AoIP_TransportLayerAddress tla := valueof(ts_BSSMAP_IE_AoIP_TLA4('01020304'O, 2342));</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSMAP_IE_AoIP_TransportLayerAddress tla tla :=</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port));</span><br><span> BSSAP.send(ts_BSSMAP_HandoverRequestAcknowledge(rr_ho_cmd_enc, lengthof(rr_ho_cmd_enc),</span><br><span> tla, ts_BSSMAP_IE_SpeechCodec({ts_CodecFR})));</span><br><span> </span><br><span>@@ -5579,6 +5622,12 @@</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> private function f_tc_ho_inter_bsc1(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var charstring bss_rtp_ip;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pars.use_ipv6) {</span><br><span style="color: hsl(120, 100%, 40%);">+ bss_rtp_ip := "::8";</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ bss_rtp_ip := "1.2.3.4";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> f_init_handler(pars);</span><br><span> f_create_bssmap_exp_handoverRequest(194);</span><br><span> </span><br><span>@@ -5588,7 +5637,8 @@</span><br><span> /* new BSS composes a RR Handover Command */</span><br><span> var PDU_ML3_NW_MS rr_ho_cmd := valueof(ts_RR_HandoverCommand);</span><br><span> var octetstring rr_ho_cmd_enc := enc_PDU_ML3_NW_MS(rr_ho_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">- var BSSMAP_IE_AoIP_TransportLayerAddress tla := valueof(ts_BSSMAP_IE_AoIP_TLA4('01020304'O, 2342));</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSMAP_IE_AoIP_TransportLayerAddress tla :=</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(f_ts_BSSMAP_IE_AoIP_TLA(bss_rtp_ip, 2342));</span><br><span> BSSAP.send(ts_BSSMAP_HandoverRequestAcknowledge(rr_ho_cmd_enc, lengthof(rr_ho_cmd_enc),</span><br><span> tla, ts_BSSMAP_IE_SpeechCodec({ts_CodecFR})));</span><br><span> </span><br><span>@@ -5630,19 +5680,27 @@</span><br><span> f_expect_clear();</span><br><span> setverdict(pass);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_ho_inter_bsc() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tc_ho_inter_bsc_main(boolean use_ipv6 := false) runs on MTC_CT {</span><br><span> var BSC_ConnHdlr vc_conn0;</span><br><span> var BSC_ConnHdlr vc_conn1;</span><br><span> f_init(2);</span><br><span> </span><br><span> var BSC_ConnHdlrPars pars0 := f_init_pars(53);</span><br><span style="color: hsl(120, 100%, 40%);">+ pars0.use_ipv6 := use_ipv6;</span><br><span> var BSC_ConnHdlrPars pars1 := f_init_pars(53);</span><br><span style="color: hsl(120, 100%, 40%);">+ pars1.use_ipv6 := use_ipv6;</span><br><span> </span><br><span> vc_conn0 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc0), pars0, 0);</span><br><span> vc_conn1 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc1), pars1, 1);</span><br><span> vc_conn0.done;</span><br><span> vc_conn1.done;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_ho_inter_bsc() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_ho_inter_bsc_main(false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_ho_inter_bsc_ipv6() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_ho_inter_bsc_main(true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> function f_ML3_patch_seq_nr_MS_NW(in uint2_t seq_nr, inout octetstring enc_l3) {</span><br><span> log("MS_NW patching N(SD)=", seq_nr, " into dtap ", enc_l3);</span><br><span>@@ -5651,7 +5709,14 @@</span><br><span> }</span><br><span> </span><br><span> private function f_tc_ho_inter_msc_out(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">- var CallParameters cpars := valueof(t_CallParams('12345'H, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ var CallParameters cpars;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars := valueof(t_CallParams('12345'H, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pars.use_ipv6) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_1.mgw_rtp_ip := "::1";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.mgw_conn_2.mgw_rtp_ip := "::2";</span><br><span style="color: hsl(120, 100%, 40%);">+ cpars.bss_rtp_ip := "::3";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> var hexstring ho_number := f_gen_msisdn(99999);</span><br><span> </span><br><span> f_init_handler(pars);</span><br><span>@@ -5841,7 +5906,8 @@</span><br><span> /* new BSS composes a RR Handover Command */</span><br><span> rr_ho_cmd := valueof(ts_RR_HandoverCommand);</span><br><span> rr_ho_cmd_enc := enc_PDU_ML3_NW_MS(rr_ho_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">- var BSSMAP_IE_AoIP_TransportLayerAddress tla := valueof(ts_BSSMAP_IE_AoIP_TLA4('01020304'O, 2342));</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSMAP_IE_AoIP_TransportLayerAddress tla :=</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port));</span><br><span> BSSAP.send(ts_BSSMAP_HandoverRequestAcknowledge(rr_ho_cmd_enc, lengthof(rr_ho_cmd_enc),</span><br><span> tla, ts_BSSMAP_IE_SpeechCodec({ts_CodecFR})));</span><br><span> </span><br><span>@@ -5889,6 +5955,16 @@</span><br><span> vc_conn := f_start_handler_with_pars(refers(f_tc_ho_inter_msc_out), pars, 0);</span><br><span> vc_conn.done;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_ho_inter_msc_out_ipv6() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars := f_init_pars(54);</span><br><span style="color: hsl(120, 100%, 40%);">+ pars.use_ipv6 := true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler_with_pars(refers(f_tc_ho_inter_msc_out), pars, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> private function f_tc_lu_imsi_auth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span> pars.net.expect_auth := true;</span><br><span>@@ -6242,6 +6318,7 @@</span><br><span> execute( TC_cmserv_imsi_unknown() );</span><br><span> execute( TC_cmserv_tmsi_unknown() );</span><br><span> execute( TC_lu_and_mo_call() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lu_and_mo_call_ipv6() );</span><br><span> execute( TC_lu_and_mo_call_sccp_tiar_timeout() );</span><br><span> execute( TC_lu_auth_sai_timeout() );</span><br><span> execute( TC_lu_auth_sai_err() );</span><br><span>@@ -6282,6 +6359,7 @@</span><br><span> execute( TC_reset_two() );</span><br><span> </span><br><span> execute( TC_lu_and_mt_call() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lu_and_mt_call_ipv6() );</span><br><span> execute( TC_lu_and_mt_call_already_paging() );</span><br><span> </span><br><span> execute( TC_lu_and_mo_sms() );</span><br><span>@@ -6348,8 +6426,10 @@</span><br><span> </span><br><span> execute( TC_ho_inter_bsc_unknown_cell() );</span><br><span> execute( TC_ho_inter_bsc() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_ho_inter_bsc_ipv6() );</span><br><span> </span><br><span> execute( TC_ho_inter_msc_out() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_ho_inter_msc_out_ipv6() );</span><br><span> </span><br><span> execute( TC_lu_imsi_auth_tmsi_check_imei() );</span><br><span> execute( TC_lu_imsi_auth3g_tmsi_check_imei() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974">change 19974</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id616926dd4a9febc4268eea2ee1e377b2d22753a </div>
<div style="display:none"> Gerrit-Change-Number: 19974 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>