<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20042">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: refactor and simplify log_target_destroy()<br><br>Change-Id: Ic6b9906e6fd24de6af9c869348c100d9ef6a7df6<br>---<br>M src/logging.c<br>1 file changed, 8 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index c14e696..78abc19 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -959,16 +959,14 @@</span><br><span>        log_del_target(target);</span><br><span> </span><br><span> #if (!EMBEDDED)</span><br><span style="color: hsl(0, 100%, 40%);">-  if (target->output == &_file_output) {</span><br><span style="color: hsl(0, 100%, 40%);">-/* since C89/C99 says stderr is a macro, we can safely do this! */</span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef stderr</span><br><span style="color: hsl(0, 100%, 40%);">-            /* don't close stderr */</span><br><span style="color: hsl(0, 100%, 40%);">-            if (target->tgt_file.out != stderr)</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-            {</span><br><span style="color: hsl(0, 100%, 40%);">-                       fclose(target->tgt_file.out);</span><br><span style="color: hsl(0, 100%, 40%);">-                        target->tgt_file.out = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(120, 100%, 40%);">+     switch (target->type) {</span><br><span style="color: hsl(120, 100%, 40%);">+    case LOG_TGT_TYPE_FILE:</span><br><span style="color: hsl(120, 100%, 40%);">+               fclose(target->tgt_file.out);</span><br><span style="color: hsl(120, 100%, 40%);">+              target->tgt_file.out = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              /* make GCC happy */</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       }</span><br><span> #endif</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20042">change 20042</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20042"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic6b9906e6fd24de6af9c869348c100d9ef6a7df6 </div>
<div style="display:none"> Gerrit-Change-Number: 20042 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>