<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19953">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve; Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client: copy back Connection Information from MDCX ACK<br><br>This is needed in case MGW changes the local IP address (for instance<br>because it initlaly offered an IPv4 address, and a client submitted a<br>remote IPv6 address, so MGW needs then to offer a local IPv6 address for<br>the RTP connection to be possible).<br><br>Change-Id: Ie964412b81fe6e10914790baaea724ca5f772adc<br>---<br>M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c<br>1 file changed, 11 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c</span><br><span>index c68d8b3..c1fc0de 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c</span><br><span>@@ -469,14 +469,12 @@</span><br><span> </span><br><span>    ci->pending = false;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   rtp_info = data;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   switch (ci->verb) {</span><br><span>       case MGCP_VERB_CRCX:</span><br><span>                 /* If we sent a wildcarded endpoint name on CRCX, we need to store the resulting endpoint</span><br><span>             * name here. Also, we receive the MGW's RTP port information. */</span><br><span style="color: hsl(0, 100%, 40%);">-           rtp_info = data;</span><br><span style="color: hsl(0, 100%, 40%);">-                OSMO_ASSERT(rtp_info);</span><br><span style="color: hsl(0, 100%, 40%);">-          ci->got_port_info = true;</span><br><span style="color: hsl(0, 100%, 40%);">-            ci->rtp_info = *rtp_info;</span><br><span>                 osmo_strlcpy(ci->mgcp_ci_str, mgcp_conn_get_ci(ci->mgcp_client_fi),</span><br><span>                    sizeof(ci->mgcp_ci_str));</span><br><span>                 if (rtp_info->endpoint[0]) {</span><br><span>@@ -486,6 +484,15 @@</span><br><span>                               return;</span><br><span>              }</span><br><span>            ci->ep->first_crcx_complete = true;</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(rtp_info);</span><br><span style="color: hsl(120, 100%, 40%);">+                /* fall through */</span><br><span style="color: hsl(120, 100%, 40%);">+    case MGCP_VERB_MDCX:</span><br><span style="color: hsl(120, 100%, 40%);">+          /* Always update the received RTP ip/port information, since MGW</span><br><span style="color: hsl(120, 100%, 40%);">+               * may provide new one after remote end params changed */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (rtp_info) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       ci->got_port_info = true;</span><br><span style="color: hsl(120, 100%, 40%);">+                  ci->rtp_info = *rtp_info;</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>            break;</span><br><span> </span><br><span>   default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19953">change 19953</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19953"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie964412b81fe6e10914790baaea724ca5f772adc </div>
<div style="display:none"> Gerrit-Change-Number: 19953 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Assignee: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>