<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20044">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: fix memleak in log_target_create_file()<br><br>Change-Id: If16d8c6417698bbb5cf87716f9507c7256aeaecb<br>---<br>M src/logging.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/20044/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index 80ff72c..db04cf7 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -915,8 +915,10 @@</span><br><span> </span><br><span>  target->type = LOG_TGT_TYPE_FILE;</span><br><span>         target->tgt_file.out = fopen(fname, "a");</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!target->tgt_file.out)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!target->tgt_file.out) {</span><br><span style="color: hsl(120, 100%, 40%);">+               log_target_destroy(target);</span><br><span>          return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        target->output = _file_output;</span><br><span> </span><br><span>@@ -966,6 +968,8 @@</span><br><span> #if (!EMBEDDED)</span><br><span>       switch (target->type) {</span><br><span>   case LOG_TGT_TYPE_FILE:</span><br><span style="color: hsl(120, 100%, 40%);">+               if (target->tgt_file.out == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+                  break;</span><br><span>               fclose(target->tgt_file.out);</span><br><span>             target->tgt_file.out = NULL;</span><br><span>              break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20044">change 20044</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20044"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If16d8c6417698bbb5cf87716f9507c7256aeaecb </div>
<div style="display:none"> Gerrit-Change-Number: 20044 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>