<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20014">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: clarify docstring for write_packet_downlink_assignment()<br><br>Change-Id: I7c4458c2e7767b6cf03462ba79acdd9c9904ee83<br>---<br>M src/encoding.cpp<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/14/20014/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 76a1cec..2cee251 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -628,15 +628,14 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* generate downlink assignment */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Generate Packet Downlink Assignment as per 3GPP TS 44.060, section 11.2.7.</span><br><span style="color: hsl(120, 100%, 40%);">+ * NOTE: 'block' is expected to be zero-initialized by the caller. */</span><br><span> void Encoding::write_packet_downlink_assignment(RlcMacDownlink_t * block,</span><br><span>       bool old_tfi_is_valid, uint8_t old_tfi, uint8_t old_downlink,</span><br><span>        const struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,</span><br><span>    uint8_t alpha, uint8_t gamma, int8_t ta_idx,</span><br><span>         uint8_t ta_ts, bool use_egprs)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     // Packet downlink assignment TS 44.060 11.2.7</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       PDA_AdditionsR99_t *pda_r99;</span><br><span> </span><br><span>     uint8_t tn;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/20014">change 20014</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/20014"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7c4458c2e7767b6cf03462ba79acdd9c9904ee83 </div>
<div style="display:none"> Gerrit-Change-Number: 20014 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>