<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19995">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests/hopping: fix: do not reduce Mobile Allocation bit-mask<br><br>My initial assumption was that we can skip redundant '0'B bits or<br>even '00'O octets in the Mobile Allocation IE, and thus reduce<br>the overall size of this element. Unfortunately, this is wrong.<br><br>3GPP TS 44.018, section 10.5.2.21 clearly states that the Mobile<br>Allocation IE contains a bit-string of size NF, where NF is the<br>number of frequencies in the cell allocation. If NF % 8 != 0,<br>then '0'B padding bits must be appended to make it octet-aligned.<br><br>In other words, if the cell allocation contains let's say 13<br>frequencies, but a hopping timeslot makes use of only a small<br>fraction of it (e.g. 4 first channels), we would still need to<br>transmit at least 13 bits (+padding), including all redundant<br>bits and octets.<br><br>Change-Id: Ia79efc9aa07b5088913d6679715f351d30f48d13<br>Related: SYS#4868, OS#4545<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 8944447..de35e23 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -6889,7 +6889,6 @@</span><br><span> var bitstring full_mask := f_pad_bit(''B, 1024, '0'B);</span><br><span> var bitstring slot_mask := f_pad_bit(''B, 1024, '0'B);</span><br><span> var bitstring ma_mask := ''B;</span><br><span style="color: hsl(0, 100%, 40%);">- var integer ma_mask_len := 0;</span><br><span> </span><br><span> /* Compose the full bit-mask (all channels, up to 1024 entries) */</span><br><span> for (var integer i := 0; i < lengthof(fhp); i := i + 1) {</span><br><span>@@ -6913,15 +6912,13 @@</span><br><span> /* FIXME: ma_mask := ma_mask & slot_mask[i]; // triggers a bug in TITAN */</span><br><span> if (slot_mask[i] == '1'B) {</span><br><span> ma_mask := ma_mask & '1'B;</span><br><span style="color: hsl(0, 100%, 40%);">- ma_mask_len := lengthof(ma_mask);</span><br><span> } else {</span><br><span> ma_mask := ma_mask & '0'B;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span> /* Ensure that ma_mask is octet-aligned */</span><br><span style="color: hsl(0, 100%, 40%);">- ma_mask := substr(ma_mask, 0, ma_mask_len);</span><br><span style="color: hsl(0, 100%, 40%);">- ma_mask_len := (ma_mask_len + 8 - 1) / 8;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer ma_mask_len := (lengthof(ma_mask) + 8 - 1) / 8;</span><br><span> ma_mask := f_pad_bit(ma_mask, ma_mask_len * 8, '0'B);</span><br><span> </span><br><span> return { len := ma_mask_len, ma := ma_mask };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19995">change 19995</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19995"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia79efc9aa07b5088913d6679715f351d30f48d13 </div>
<div style="display:none"> Gerrit-Change-Number: 19995 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>