<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "sip: Specify invite contact tag"<br><br>This reverts commit 52b2afce2ca902bbae4a550d03d471be784efe28.<br>The contact header is generated by the original sofia-sip library.<br>By adding the contact header explicit as user header it violates the<br>SIP RFC because sofia will add the Contact header to the BYE message as<br>well.<br><br>Let's fix the bugs in the freeswitch sofia-sip and make it compatible<br>(not bug compatible) with the original sofia-sip.<br><br>Change-Id: I712f17fecbc372d1e486e80673a548e281b37800<br>---<br>M src/sip.c<br>1 file changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/92/19992/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index 61916c9..c635542 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -597,9 +597,6 @@</span><br><span>                          called_num,</span><br><span>                          agent->app->sip.remote_addr,</span><br><span>                           agent->app->sip.remote_port);</span><br><span style="color: hsl(0, 100%, 40%);">-     char *contact = talloc_asprintf(leg, "sip:%s:%d",</span><br><span style="color: hsl(0, 100%, 40%);">-                                     agent->app->sip.local_addr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                       agent->app->sip.local_port);</span><br><span>   char *sdp = sdp_create_file(leg, other, sdp_sendrecv);</span><br><span> </span><br><span>   leg->state = SIP_CC_INITIAL;</span><br><span>@@ -607,7 +604,6 @@</span><br><span>        nua_invite(leg->nua_handle,</span><br><span>                       SIPTAG_FROM_STR(from),</span><br><span>                       SIPTAG_TO_STR(to),</span><br><span style="color: hsl(0, 100%, 40%);">-                      SIPTAG_CONTACT_STR(contact),</span><br><span>                         NUTAG_MEDIA_ENABLE(0),</span><br><span>                       SIPTAG_CONTENT_TYPE_STR("application/sdp"),</span><br><span>                        SIPTAG_PAYLOAD_STR(sdp),</span><br><span>@@ -616,7 +612,6 @@</span><br><span>       leg->base.call->remote = &leg->base;</span><br><span>    talloc_free(from);</span><br><span>   talloc_free(to);</span><br><span style="color: hsl(0, 100%, 40%);">-        talloc_free(contact);</span><br><span>        talloc_free(sdp);</span><br><span>    return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992">change 19992</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I712f17fecbc372d1e486e80673a548e281b37800 </div>
<div style="display:none"> Gerrit-Change-Number: 19992 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>