<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19978">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: add 'gsmtap-sapi (enable-all|disable-all)' command<br><br>It's more convenient to use one command to enable/disable sending<br>of all kinds of UL/DL messages at once, rather than specifying<br>all of them individually.<br><br>Adjust config_write_bts_single(), so it would not print unknown<br>GSMTAP SAPI entries if gsmtap_sapi_mask is set to UINT32_MAX.<br><br>Change-Id: Icd7fce860ecdcf8ffa107bdfee7ec94ea9ea6cb2<br>---<br>M src/common/vty.c<br>1 file changed, 23 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/78/19978/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 49e6edf..d5993d6 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -251,9 +251,12 @@</span><br><span>                      bts->agch_queue.thresh_level, bts->agch_queue.low_level,</span><br><span>                       bts->agch_queue.high_level, VTY_NEWLINE);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        for (i = 0; i < 32; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < sizeof(uint32_t) * 8; i++) {</span><br><span>              if (gsmtap_sapi_mask & ((uint32_t) 1 << i)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, i));</span><br><span style="color: hsl(120, 100%, 40%);">+                  sapi_buf = get_value_string_or_null(gsmtap_sapi_names, i);</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (sapi_buf == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+                         continue;</span><br><span style="color: hsl(120, 100%, 40%);">+                     sapi_buf = osmo_str_tolower(sapi_buf);</span><br><span>                       vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);</span><br><span>          }</span><br><span>    }</span><br><span>@@ -1410,6 +1413,23 @@</span><br><span>   "logical channel commands\n"  \</span><br><span>    "logical channel number\n"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_trx_gsmtap_sapi_all, cfg_trx_gsmtap_sapi_all_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "gsmtap-sapi (enable-all|disable-all)",</span><br><span style="color: hsl(120, 100%, 40%);">+     "Enable/disable sending of UL/DL messages over GSMTAP\n"</span><br><span style="color: hsl(120, 100%, 40%);">+    "Enable all kinds of messages (all SAPI)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Disable all kinds of messages (all SAPI)\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    if (argv[0][0] == 'e') {</span><br><span style="color: hsl(120, 100%, 40%);">+              gsmtap_sapi_mask = UINT32_MAX;</span><br><span style="color: hsl(120, 100%, 40%);">+                gsmtap_sapi_acch = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              gsmtap_sapi_mask = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+              gsmtap_sapi_acch = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_trx_gsmtap_sapi, cfg_trx_gsmtap_sapi_cmd,</span><br><span>      "HIDDEN", "HIDDEN")</span><br><span> {</span><br><span>@@ -1721,6 +1741,7 @@</span><br><span>         install_element(BTS_NODE, &cfg_bts_smscb_tgt_qlen_cmd);</span><br><span>  install_element(BTS_NODE, &cfg_bts_smscb_qhyst_cmd);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  install_element(BTS_NODE, &cfg_trx_gsmtap_sapi_all_cmd);</span><br><span>         install_element(BTS_NODE, &cfg_trx_gsmtap_sapi_cmd);</span><br><span>     install_element(BTS_NODE, &cfg_trx_no_gsmtap_sapi_cmd);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19978">change 19978</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19978"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd7fce860ecdcf8ffa107bdfee7ec94ea9ea6cb2 </div>
<div style="display:none"> Gerrit-Change-Number: 19978 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>