<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19976">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enum osmo_sccp_ssn: rename to OSMO_SCCP_SSN_SMLC_BSSAP_LE<br><br>Quoting 3GPP TS 23.003 8.2:<br><br> 1111 1010 BSC (BSSAP-LE);<br> 1111 1011 MSC (BSSAP-LE);<br> 1111 1100 SMLC (BSSAP-LE);<br><br>Hence the SMLC one should also be named *_BSSAP_LE.<br><br>I'm certain no other osmocom code is using this SSN yet, but anyway keep a<br>backwards compat shim #define.<br><br>Change-Id: I3e0c1be0ebbd3883d024174d1e7e9167a8281cfb<br>---<br>M include/osmocom/sigtran/sccp_sap.h<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/76/19976/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h</span><br><span>index e012635..817ac45 100644</span><br><span>--- a/include/osmocom/sigtran/sccp_sap.h</span><br><span>+++ b/include/osmocom/sigtran/sccp_sap.h</span><br><span>@@ -131,11 +131,14 @@</span><br><span>    OSMO_SCCP_SSN_PCAP              = 249,</span><br><span>       OSMO_SCCP_SSN_BSC_BSSAP_LE      = 250,</span><br><span>       OSMO_SCCP_SSN_MSC_BSSAP_LE      = 251,</span><br><span style="color: hsl(0, 100%, 40%);">-  OSMO_SCCP_SSN_SMLC_BSSAP        = 252,</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_SCCP_SSN_SMLC_BSSAP_LE     = 252,</span><br><span>       OSMO_SCCP_SSN_BSS_OAM           = 253,</span><br><span>       OSMO_SCCP_SSN_BSSAP             = 254,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* legacy shim for name change */</span><br><span style="color: hsl(120, 100%, 40%);">+#define OSMO_SCCP_SSN_SMLC_BSSAP OSMO_SCCP_SSN_SMLC_BSSAP_LE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> extern const struct value_string osmo_sccp_ssn_names[];</span><br><span> static inline const char *osmo_sccp_ssn_name(enum osmo_sccp_ssn val)</span><br><span> { return get_value_string(osmo_sccp_ssn_names, val); }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19976">change 19976</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19976"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3e0c1be0ebbd3883d024174d1e7e9167a8281cfb </div>
<div style="display:none"> Gerrit-Change-Number: 19976 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>