<p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969/1/src/libosmo-mgcp/mgcp_network.c">File src/libosmo-mgcp/mgcp_network.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969/1/src/libosmo-mgcp/mgcp_network.c@80">Patch Set #1, Line 80:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static bool addr_is_any(struct osmo_sockaddr *osa) {<br> if (osa->u.sa.sa_family == AF_INET6) {<br> struct in6_addr ip6_any = IN6ADDR_ANY_INIT;<br> return memcmp(&osa->u.sin6.sin6_addr,<br> &ip6_any, sizeof(ip6_any)) == 0;<br> } else {<br> return osa->u.sin.sin_addr.s_addr == 0;<br> }<br>}<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">shouldn't we by now have a generic helper for this in libosmocore? I think I've seen something like […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">In the other place where you saw it it was checked against strings, not against sockaddr, so no use here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969/1/src/libosmo-mgcp/mgcp_sdp.c">File src/libosmo-mgcp/mgcp_sdp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969/1/src/libosmo-mgcp/mgcp_sdp.c@266">Patch Set #1, Line 266:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static int audio_ip_from_sdp(struct osmo_sockaddr *dst_addr, char *sdp)<br>{<br> bool is_ipv6;<br> char ipbuf[INET6_ADDRSTRLEN];<br> if (strncmp("c=IN IP", sdp, 7) != 0)<br> return -1;<br> sdp += 7;<br> if (*sdp == '6')<br> is_ipv6 = true;<br> else if (*sdp == '4')<br> is_ipv6 = false;<br> else<br> return -1;<br> sdp++;<br> if (*sdp != ' ')<br> return -1;<br> sdp++;<br> if (is_ipv6) {<br> /* 45 = INET6_ADDRSTRLEN -1 */<br> if (sscanf(sdp, "%45s", ipbuf) != 1)<br> return -1;<br> if (inet_pton(AF_INET6, ipbuf, &dst_addr->u.sin6.sin6_addr) != 1)<br> return -1;<br> dst_addr->u.sa.sa_family = AF_INET6;<br> } else {<br> /* 15 = INET_ADDRSTRLEN -1 */<br> if (sscanf(sdp, "%15s", ipbuf) != 1)<br> return -1;<br> if (inet_pton(AF_INET, ipbuf, &dst_addr->u.sin.sin_addr) != 1)<br> return -1;<br> dst_addr->u.sa.sa_family = AF_INET;<br> }<br> return 0;<br>}<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I thoguht something like this was also in libosmo-mgcp-client patches recently? Is there a chance to […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">There's already been discussions about work needed to merge all code in general from here and libosmo-mgcp-client, but that's really a different task than the one at hand, and the current task I'm facing is already messy enough (lots of changes in lots of places), so let's better deferr that for another moment.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969">change 19969</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19969"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I504ca776d88fd852bbaef07060c125980db3fdd7 </div>
<div style="display:none"> Gerrit-Change-Number: 19969 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 03 Sep 2020 14:00:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>