<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19963">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: propagate result of gsm_bts_set_system_infos()<br><br>We should not return CMD_SUCCESS if this functions fails.<br><br>Change-Id: Id8a761593fe89cc07c2fb6e69558f44494537c47<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/19963/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index e588ba2..3524506 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -3684,7 +3684,11 @@</span><br><span>   if (acc_ramp_is_enabled(&bts->acc_ramp)) {</span><br><span>            acc_ramp_abort(&bts->acc_ramp);</span><br><span>               acc_ramp_set_enabled(&bts->acc_ramp, false);</span><br><span style="color: hsl(0, 100%, 40%);">-             gsm_bts_set_system_infos(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+                if (gsm_bts_set_system_infos(bts) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     vty_out(vty, "%% Filed to (re)generate System Information "</span><br><span style="color: hsl(120, 100%, 40%);">+                         "messages, check the logs%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>    }</span><br><span> </span><br><span>        return CMD_SUCCESS;</span><br><span>@@ -4828,7 +4832,11 @@</span><br><span>                 return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   gsm_bts_set_system_infos(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (gsm_bts_set_system_infos(bts) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+             vty_out(vty, "%% Filed to (re)generate System Information "</span><br><span style="color: hsl(120, 100%, 40%);">+                 "messages, check the logs%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> </span><br><span>        return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19963">change 19963</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19963"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id8a761593fe89cc07c2fb6e69558f44494537c47 </div>
<div style="display:none"> Gerrit-Change-Number: 19963 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>