<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19939">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types: add minimalistic HandoverCommand<br><br>Similar to [1], the existing implementation [2] is unfriendly<br>to use, so let's work this around by defining a minimalistic<br>implementation of (RR) Handover Command.<br><br>[1] If1a5244a688abed6e6de2bf3f6e19e0e28129ea5<br>[2] titan.ProtocolModules.MobileL3_v13.4.0<br>    MobileL3_RRM_Types.PDU_RRM_HandoverCommand_NW_MS<br><br>Change-Id: I08e6d33a725f99e2c92f93153b2369c4c764c012<br>Related: SYS#4868, OS#4545<br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 32 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index c2c9d1b..2cb50bc 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -694,6 +694,36 @@</span><br><span>              )"</span><br><span>      };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* 3GPP TS 44.018, section 9.1.15 (minimalistic implementation) */</span><br><span style="color: hsl(120, 100%, 40%);">+    type record HandoverCommand {</span><br><span style="color: hsl(120, 100%, 40%);">+         CellDescriptionV                cell_desc,</span><br><span style="color: hsl(120, 100%, 40%);">+            ChannelDescription              chan_desc,</span><br><span style="color: hsl(120, 100%, 40%);">+            OCT1                            ho_ref,</span><br><span style="color: hsl(120, 100%, 40%);">+               PowerCommandAndAccesstype_V     power_cmd_acc_type,</span><br><span style="color: hsl(120, 100%, 40%);">+           FrequencyList_TLV               freq_list_at optional,</span><br><span style="color: hsl(120, 100%, 40%);">+                CellChannelDescription_TV       cell_chan_desc optional,</span><br><span style="color: hsl(120, 100%, 40%);">+              ChannelMode_TV                  chan1_mode optional,</span><br><span style="color: hsl(120, 100%, 40%);">+          ChannelMode_TV                  chan2_mode optional,</span><br><span style="color: hsl(120, 100%, 40%);">+          /* TODO: Mode of Channel Set 3..8 IE */</span><br><span style="color: hsl(120, 100%, 40%);">+               MobileAllocationTLV             mobile_allocation optional</span><br><span style="color: hsl(120, 100%, 40%);">+            /* TODO: more optional IEs... */</span><br><span style="color: hsl(120, 100%, 40%);">+      } with {</span><br><span style="color: hsl(120, 100%, 40%);">+              variant "TAG(</span><br><span style="color: hsl(120, 100%, 40%);">+                    freq_list_at,           elementIdentifier = '05'O;</span><br><span style="color: hsl(120, 100%, 40%);">+                    cell_chan_desc,         elementIdentifier = '62'O;</span><br><span style="color: hsl(120, 100%, 40%);">+                    chan1_mode,             elementIdentifier = '63'O;</span><br><span style="color: hsl(120, 100%, 40%);">+                    chan2_mode,             elementIdentifier = '11'O;</span><br><span style="color: hsl(120, 100%, 40%);">+                    mobile_allocation,      iei = '72'O;</span><br><span style="color: hsl(120, 100%, 40%);">+          )"</span><br><span style="color: hsl(120, 100%, 40%);">+       };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* 10.5.2.2 Cell Description IE */</span><br><span style="color: hsl(120, 100%, 40%);">+    type record CellDescriptionV {</span><br><span style="color: hsl(120, 100%, 40%);">+                uint3_t                         bcc, /* PLMN colour code */</span><br><span style="color: hsl(120, 100%, 40%);">+           uint3_t                         ncc, /* BS colour code */</span><br><span style="color: hsl(120, 100%, 40%);">+             uint10_t                        bcch_arfcn</span><br><span style="color: hsl(120, 100%, 40%);">+    } with { variant "FIELDORDER(lsb)" };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span>        /* 9.1.18 */</span><br><span>         type record ImmediateAssignment {</span><br><span>@@ -853,6 +883,7 @@</span><br><span>              PagingResponse          paging_response,</span><br><span>             MeasurementReport       meas_rep,</span><br><span>            AssignmentCommand       ass_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+              HandoverCommand         ho_cmd,</span><br><span>              octetstring             other</span><br><span>        };</span><br><span> </span><br><span>@@ -863,6 +894,7 @@</span><br><span>                                 paging_response, header.message_type = PAGING_RESPONSE;</span><br><span>                              meas_rep, header.message_type = MEASUREMENT_REPORT;</span><br><span>                          ass_cmd, header.message_type = ASSIGNMENT_COMMAND;</span><br><span style="color: hsl(120, 100%, 40%);">+                            ho_cmd, header.message_type = HANDOVER_COMMAND;</span><br><span>                              other, OTHERWISE;</span><br><span>            )" }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19939">change 19939</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19939"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I08e6d33a725f99e2c92f93153b2369c4c764c012 </div>
<div style="display:none"> Gerrit-Change-Number: 19939 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>