<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19948">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">iso7816_fsm: ignore RX_SINGLE events during transmit<br><br>When logging is enabled, we get a lot of LOGL_ERROR events<br>about RX_SINGLE events not being permitted.  This is not very<br>useful in debugging, so suppress those error messages.<br><br>Change-Id: I7aec5fb2eaa76076e1bd0c6b8e8d09dc840c3630<br>---<br>M ccid_common/iso7816_fsm.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/48/19948/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c</span><br><span>index 02e7c0d..ffb5b05 100644</span><br><span>--- a/ccid_common/iso7816_fsm.c</span><br><span>+++ b/ccid_common/iso7816_fsm.c</span><br><span>@@ -1218,6 +1218,8 @@</span><br><span>         struct iso7816_3_priv *ip = get_iso7816_3_priv(parent_fi);</span><br><span>   OSMO_ASSERT(fi->fsm == &tpdu_fsm);</span><br><span>    switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case ISO7816_E_RX_SINGLE:</span><br><span style="color: hsl(120, 100%, 40%);">+             return;</span><br><span>      case ISO7816_E_TX_COMPL:</span><br><span> </span><br><span>                 card_uart_set_rx_threshold(ip->uart, 1);</span><br><span>@@ -1307,6 +1309,8 @@</span><br><span>  struct iso7816_3_priv *ip = get_iso7816_3_priv(parent_fi);</span><br><span> </span><br><span>       switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case ISO7816_E_RX_SINGLE:</span><br><span style="color: hsl(120, 100%, 40%);">+             return;</span><br><span>      case ISO7816_E_TX_COMPL:</span><br><span>             card_uart_set_rx_threshold(ip->uart, 1);</span><br><span>          card_uart_ctrl(ip->uart, CUART_CTL_RX_TIMER_HINT, 1);</span><br><span>@@ -1484,7 +1488,7 @@</span><br><span>     },</span><br><span>   [TPDU_S_TX_HDR] = {</span><br><span>          .name = "TX_HDR",</span><br><span style="color: hsl(0, 100%, 40%);">-             .in_event_mask = S(ISO7816_E_TX_COMPL),</span><br><span style="color: hsl(120, 100%, 40%);">+               .in_event_mask = S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_SINGLE),</span><br><span>             .out_state_mask = S(TPDU_S_INIT) |</span><br><span>                             S(TPDU_S_PROCEDURE),</span><br><span>               .action = tpdu_s_tx_hdr_action,</span><br><span>@@ -1503,7 +1507,7 @@</span><br><span>      },</span><br><span>   [TPDU_S_TX_REMAINING] = {</span><br><span>            .name = "TX_REMAINING",</span><br><span style="color: hsl(0, 100%, 40%);">-               .in_event_mask = S(ISO7816_E_TX_COMPL),</span><br><span style="color: hsl(120, 100%, 40%);">+               .in_event_mask = S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_SINGLE),</span><br><span>             .out_state_mask = S(TPDU_S_INIT) |</span><br><span>                             S(TPDU_S_SW1),</span><br><span>             .action = tpdu_s_tx_remaining_action,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19948">change 19948</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19948"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7aec5fb2eaa76076e1bd0c6b8e8d09dc840c3630 </div>
<div style="display:none"> Gerrit-Change-Number: 19948 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>