<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/19949">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Support handling IPv6 Transport Address in Assignment Complete<br><br>Change-Id: Ib650bb063404a3068b4cf3c376c6080dc29bebfe<br>---<br>M src/libmsc/ran_msg_a.c<br>1 file changed, 3 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/49/19949/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c</span><br><span>index 936cd5b..4bfd8dc 100644</span><br><span>--- a/src/libmsc/ran_msg_a.c</span><br><span>+++ b/src/libmsc/ran_msg_a.c</span><br><span>@@ -278,8 +278,7 @@</span><br><span>         struct tlv_p_entry *ie_speech_codec = TLVP_GET(tp, GSM0808_IE_SPEECH_CODEC);</span><br><span>         struct tlv_p_entry *ie_codec_list_bss_supported = TLVP_GET(tp, GSM0808_IE_SPEECH_CODEC_LIST);</span><br><span>        struct tlv_p_entry *ie_osmux_cid = TLVP_GET(tp, GSM0808_IE_OSMO_OSMUX_CID);</span><br><span style="color: hsl(0, 100%, 40%);">-     struct sockaddr_storage rtp_addr;</span><br><span style="color: hsl(0, 100%, 40%);">-       struct sockaddr_in *rtp_addr_in;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct osmo_sockaddr rtp_addr;</span><br><span>       struct gsm0808_speech_codec sc;</span><br><span>      struct gsm0808_speech_codec_list codec_list_bss_supported;</span><br><span>   int rc;</span><br><span>@@ -290,21 +289,13 @@</span><br><span> </span><br><span>  if (ie_aoip_transp_addr) {</span><br><span>           /* Decode AoIP transport address element */</span><br><span style="color: hsl(0, 100%, 40%);">-             rc = gsm0808_dec_aoip_trasp_addr(&rtp_addr, ie_aoip_transp_addr->val, ie_aoip_transp_addr->len);</span><br><span style="color: hsl(120, 100%, 40%);">+            rc = gsm0808_dec_aoip_trasp_addr(&rtp_addr.u.sa, ie_aoip_transp_addr->val, ie_aoip_transp_addr->len);</span><br><span>              if (rc < 0) {</span><br><span>                     LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Unable to decode AoIP Transport Layer Address\n");</span><br><span>                  return -EINVAL;</span><br><span>              }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           rtp_addr_in = (struct sockaddr_in*)&rtp_addr;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               if (rtp_addr.ss_family != AF_INET) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Assignment Complete: IE AoIP Transport Address:"</span><br><span style="color: hsl(0, 100%, 40%);">-                                " unsupported addressing scheme (only IPV4 supported)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                   return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               if (osmo_sockaddr_str_from_sockaddr_in(&ran_dec_msg.assignment_complete.remote_rtp, rtp_addr_in)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               if (osmo_sockaddr_str_from_sockaddr(&ran_dec_msg.assignment_complete.remote_rtp, &rtp_addr.u.sa)) {</span><br><span>                  LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Assignment Complete: unable to decode remote RTP IP address\n");</span><br><span>                    return -EINVAL;</span><br><span>              }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/19949">change 19949</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/19949"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib650bb063404a3068b4cf3c376c6080dc29bebfe </div>
<div style="display:none"> Gerrit-Change-Number: 19949 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>