<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19951">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">iso7816_fsm: Fix APDU case with P3=0<br><br>If P3=0 and we only receive a status word directly, we were<br>returning a very long mostly zero-initialized buffer instead<br>of the status word.  Reason: We used msgb_put() instaed of<br>msgb_put_u8(), so the SW1 determined the size of the message.<br><br>Change-Id: I01e688db020b3b8a8735d615e653cc816caa7a13<br>Closes: OS#4744<br>---<br>M ccid_common/iso7816_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/51/19951/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c</span><br><span>index 02e7c0d..a9d6ca1 100644</span><br><span>--- a/ccid_common/iso7816_fsm.c</span><br><span>+++ b/ccid_common/iso7816_fsm.c</span><br><span>@@ -1253,7 +1253,7 @@</span><br><span>                       osmo_fsm_inst_state_chg(fi, TPDU_S_PROCEDURE, 0, 0);</span><br><span>                 } else if ((byte >= 0x60 && byte <= 0x6f) || (byte >= 0x90 && byte <= 0x9f)) {</span><br><span>                   //msgb_apdu_sw(tfp->apdu) = byte << 8;</span><br><span style="color: hsl(0, 100%, 40%);">-                 msgb_put(tfp->tpdu, byte);</span><br><span style="color: hsl(120, 100%, 40%);">+                 msgb_put_u8(tfp->tpdu, byte);</span><br><span>                     /* receive second SW byte (SW2) */</span><br><span>                   card_uart_set_rx_threshold(ip->uart, 1);</span><br><span>                  card_uart_ctrl(ip->uart, CUART_CTL_RX_TIMER_HINT, 1);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19951">change 19951</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19951"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I01e688db020b3b8a8735d615e653cc816caa7a13 </div>
<div style="display:none"> Gerrit-Change-Number: 19951 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>