<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19934">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Hide show running-config ACC ramping params if not enabled<br><br>If the feature is not enabled there's no real use in displaying default<br>values for it.<br><br>Related: SYS#4912<br>Change-Id: I759eb0c31dd3c9b6f5f3d2bf57c6efc9ac5f74f1<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 8 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index fc7dd16..ef10c49 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -955,12 +955,14 @@</span><br><span>      if (bts->acc_mgr.rotation_time_sec != ACC_MGR_QUANTUM_DEFAULT)</span><br><span>            vty_out(vty, "  access-control-class-rotate-quantum %" PRIu32 "%s", bts->acc_mgr.rotation_time_sec, VTY_NEWLINE);</span><br><span>     vty_out(vty, "  %saccess-control-class-ramping%s", acc_ramp_is_enabled(&bts->acc_ramp) ? "" : "no ", VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">- vty_out(vty, "  access-control-class-ramping-step-interval %u%s",</span><br><span style="color: hsl(0, 100%, 40%);">-             acc_ramp_get_step_interval(&bts->acc_ramp), VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-        vty_out(vty, "  access-control-class-ramping-step-size %u%s", acc_ramp_get_step_size(&bts->acc_ramp),</span><br><span style="color: hsl(0, 100%, 40%);">-          VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-   vty_out(vty, "  access-control-class-ramping-chan-load %u %u%s",</span><br><span style="color: hsl(0, 100%, 40%);">-              bts->acc_ramp.chan_load_lower_threshold, bts->acc_ramp.chan_load_upper_threshold, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (acc_ramp_is_enabled(&bts->acc_ramp)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             vty_out(vty, "  access-control-class-ramping-step-interval %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+                   acc_ramp_get_step_interval(&bts->acc_ramp), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+              vty_out(vty, "  access-control-class-ramping-step-size %u%s", acc_ramp_get_step_size(&bts->acc_ramp),</span><br><span style="color: hsl(120, 100%, 40%);">+                        VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         vty_out(vty, "  access-control-class-ramping-chan-load %u %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+                    bts->acc_ramp.chan_load_lower_threshold, bts->acc_ramp.chan_load_upper_threshold, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span>    if (!bts->si_unused_send_empty)</span><br><span>           vty_out(vty, "  no system-information unused-send-empty%s", VTY_NEWLINE);</span><br><span>  for (i = SYSINFO_TYPE_1; i < _MAX_SYSINFO_TYPE; i++) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19934">change 19934</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19934"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I759eb0c31dd3c9b6f5f3d2bf57c6efc9ac5f74f1 </div>
<div style="display:none"> Gerrit-Change-Number: 19934 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>