<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19893">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: dissolve error-goto with single source in handover_start()<br><br>Change-Id: I9c7d10c36f3f868100c1aa2d0433ceed74161175<br>---<br>M src/osmo-bsc/handover_fsm.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index 90fa20b..bb5dcb1 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -330,8 +330,10 @@</span><br><span> ho->target_cell = req->target_nik;</span><br><span> </span><br><span> if (find_handover_target_cell(&local_target_cell, &remote_target_cell,</span><br><span style="color: hsl(0, 100%, 40%);">- conn, search_for, true))</span><br><span style="color: hsl(0, 100%, 40%);">- goto no_handover;</span><br><span style="color: hsl(120, 100%, 40%);">+ conn, search_for, true)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ handover_end(conn, HO_RESULT_FAIL_NO_CHANNEL);</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> if (local_target_cell) {</span><br><span> ho->new_bts = local_target_cell;</span><br><span>@@ -346,9 +348,6 @@</span><br><span> </span><br><span> /* should never reach this, because find_handover_target_cell() would have returned error. */</span><br><span> OSMO_ASSERT(false);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-no_handover:</span><br><span style="color: hsl(0, 100%, 40%);">- handover_end(conn, HO_RESULT_FAIL_NO_CHANNEL);</span><br><span> }</span><br><span> </span><br><span> /*! Hand over the specified logical channel to the specified new BTS and possibly change the lchan type.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19893">change 19893</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19893"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c7d10c36f3f868100c1aa2d0433ceed74161175 </div>
<div style="display:none"> Gerrit-Change-Number: 19893 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>